consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3268 from consul/budget-polish

Browse Source 
[Backport] Budgets UI minor fixes
This commit is contained in:
Alberto
2019-02-06 14:31:26 +01:00
committed by GitHub
parent 75c0d98d47 5c7cc5a20f
commit 6a7fcde9a6
9 changed files with 104 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
spec/features/admin/budget_investments_spec.rb
View File

@@ -359,20 +359,30 @@ feature 'Admin budget investments' do
end
scenario "Disable 'Calculate winner' button if incorrect phase" do
budget.update(phase: 'reviewing_ballots')
budget.update(phase: "reviewing_ballots")
visit admin_budget_budget_investments_path(budget)
click_link 'Winners'
click_link "Winners"
expect(page).to have_link "Calculate Winner Investments"
budget.update(phase: 'accepting')
visit edit_admin_budget_path(budget)
expect(page).to have_link "Calculate Winner Investments"
budget.update(phase: "accepting")
visit admin_budget_budget_investments_path(budget)
click_link 'Winners'
click_link "Winners"
expect(page).not_to have_link "Calculate Winner Investments"
expect(page).to have_content 'The budget has to stay on phase "Balloting projects", '\
'"Reviewing Ballots" or "Finished budget" in order '\
"to calculate winners projects"
visit edit_admin_budget_path(budget)
expect(page).not_to have_link "Calculate Winner Investments"
expect(page).to have_content 'The budget has to stay on phase "Balloting projects", "Reviewing Ballots" or "Finished budget" in order to calculate winners projects'
end
scenario "Filtering by minimum number of votes", :js do

29
spec/features/admin/budgets_spec.rb
View File

@@ -220,14 +220,33 @@ feature 'Admin budgets' do
expect(page).to have_content 'See results'
end
scenario 'For a finished Budget' do
budget = create(:budget, phase: 'finished')
allow_any_instance_of(Budget).to receive(:has_winning_investments?).and_return true
scenario "For a finished Budget" do
budget = create(:budget, phase: "finished")
allow_any_instance_of(Budget).to receive(:has_winning_investments?).and_return(true)
visit edit_admin_budget_path(budget)
expect(page).not_to have_content 'Calculate Winner Investments'
expect(page).to have_content 'See results'
expect(page).to have_content "Calculate Winner Investments"
expect(page).to have_content "See results"
end
scenario "Recalculate for a finished Budget" do
budget = create(:budget, phase: "finished")
group = create(:budget_group, budget: budget)
heading = create(:budget_heading, group: group)
create(:budget_investment, :winner, heading: heading)
visit edit_admin_budget_path(budget)
expect(page).to have_content "Recalculate Winner Investments"
expect(page).to have_content "See results"
expect(page).not_to have_content "Calculate Winner Investments"
visit admin_budget_budget_investments_path(budget)
click_link "Winners"
expect(page).to have_content "Recalculate Winner Investments"
expect(page).not_to have_content "Calculate Winner Investments"
end
end