From 67a13d5fea43d539ef6a1f200401c82319b4478e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Fri, 3 Sep 2021 20:22:20 +0200
Subject: [PATCH] Use local variables in user profile partials

This way we'll be able to render the partials from places like a
component.
---
 app/views/users/_activity_page.html.erb      | 10 +++++-----
 app/views/users/_budget_investments.html.erb |  4 ++--
 app/views/users/_comments.html.erb           |  4 ++--
 app/views/users/_debates.html.erb            |  4 ++--
 app/views/users/_following.html.erb          |  6 +++---
 app/views/users/_proposals.html.erb          |  4 ++--
 6 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/app/views/users/_activity_page.html.erb b/app/views/users/_activity_page.html.erb
index eaa8a73b7..410a71aa1 100644
--- a/app/views/users/_activity_page.html.erb
+++ b/app/views/users/_activity_page.html.erb
@@ -1,5 +1,5 @@
-<%= render "following" if @follows.present? %>
-<%= render "proposals" if @proposals.present? && feature?(:proposals) %>
-<%= render "debates" if @debates.present? && feature?(:debates) %>
-<%= render "budget_investments" if @budget_investments.present? && feature?(:budgets) %>
-<%= render "comments" if @comments.present? %>
+<%= render "following", user: @user, follows: @follows if @follows.present? %>
+<%= render "proposals", proposals: @proposals if @proposals.present? && feature?(:proposals) %>
+<%= render "debates", debates: @debates if @debates.present? && feature?(:debates) %>
+<%= render "budget_investments", budge_investments: @budge_investments if @budge_investments.present? && feature?(:budgets) %>
+<%= render "comments", comments: @comments if @comments.present? %>
diff --git a/app/views/users/_budget_investments.html.erb b/app/views/users/_budget_investments.html.erb
index 9c6775265..a2b523133 100644
--- a/app/views/users/_budget_investments.html.erb
+++ b/app/views/users/_budget_investments.html.erb
@@ -6,10 +6,10 @@
     </tr>
   </thead>
   <tbody>
-    <% @budget_investments.each do |budget_investment| %>
+    <% budget_investments.each do |budget_investment| %>
       <%= render "budget_investment", budget_investment: budget_investment %>
     <% end %>
   </tbody>
 </table>
 
-<%= paginate @budget_investments %>
+<%= paginate budget_investments %>
diff --git a/app/views/users/_comments.html.erb b/app/views/users/_comments.html.erb
index 7b7cf5165..be264ce05 100644
--- a/app/views/users/_comments.html.erb
+++ b/app/views/users/_comments.html.erb
@@ -5,7 +5,7 @@
     </tr>
   </thead>
   <tbody>
-    <% @comments.each do |comment| %>
+    <% comments.each do |comment| %>
       <tr id="comment_<%= comment.id %>">
         <td>
           <%= comment_commentable_title(comment) %>
@@ -17,4 +17,4 @@
   </tbody>
 </table>
 
-<%= paginate @comments %>
+<%= paginate comments %>
diff --git a/app/views/users/_debates.html.erb b/app/views/users/_debates.html.erb
index 5b293b1a4..be8dbe7bc 100644
--- a/app/views/users/_debates.html.erb
+++ b/app/views/users/_debates.html.erb
@@ -5,7 +5,7 @@
     </tr>
   </thead>
   <tbody>
-    <% @debates.each do |debate| %>
+    <% debates.each do |debate| %>
       <tr id="debate_<%= debate.id %>">
         <td>
           <%= link_to debate.title, debate %>
@@ -15,4 +15,4 @@
   </tbody>
 </table>
 
-<%= paginate @debates %>
+<%= paginate debates %>
diff --git a/app/views/users/_following.html.erb b/app/views/users/_following.html.erb
index 91fa8562a..480bb2da2 100644
--- a/app/views/users/_following.html.erb
+++ b/app/views/users/_following.html.erb
@@ -1,12 +1,12 @@
 <div class="row following margin-top" data-equalizer data-equalize-on="medium">
   <div class="small-12 medium-8 column" data-equalizer-watch>
     <ul class="menu simple clear">
-      <% @follows.each do |followable_type, follows| %>
+      <% follows.each do |followable_type, follows| %>
         <li><%= link_to followable_type_title(followable_type), "##{followable_type_title(followable_type).parameterize.underscore}" %></li>
       <% end %>
     </ul>
 
-    <% @follows.each do |followable_type, follows| %>
+    <% follows.each do |followable_type, follows| %>
 
       <h3 id="<%= followable_type_title(followable_type).parameterize.underscore %>">
         <span class="icon-<%= followable_icon(followable_type) %>"></span>
@@ -22,6 +22,6 @@
   </div>
 
   <div class="small-12 medium-4 column interests" data-equalizer-watch>
-    <%= render "interests", user: @user if valid_interests_access? %>
+    <%= render "interests", user: user if valid_interests_access? %>
   </div>
 </div>
diff --git a/app/views/users/_proposals.html.erb b/app/views/users/_proposals.html.erb
index 6604ac160..76758bfd3 100644
--- a/app/views/users/_proposals.html.erb
+++ b/app/views/users/_proposals.html.erb
@@ -7,10 +7,10 @@
     </tr>
   </thead>
   <tbody>
-    <% @proposals.each do |proposal| %>
+    <% proposals.each do |proposal| %>
       <%= render "proposal", proposal: proposal %>
     <% end %>
   </tbody>
 </table>
 
-<%= paginate @proposals %>
+<%= paginate proposals %>