consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply StringConcatenation rule in some places

Browse Source 
This rule was added in Rubocop 0.89.0. However, there are some false
positives when we don't use interpolation but simply concatenate in
order to avoid long lines. Even if there weren't false positives, there
are places where we concatenate to emphasize the point that we're adding
a certain character to a text.

We might reconsider this rule in the future, since we generally prefer
interpolation over concatenation.
This commit is contained in:
Javi Martín
2020-10-10 22:00:55 +02:00
parent efd8f47596
commit 66759d2dc0
8 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/system/admin/site_customization/documents_spec.rb
View File

@@ -58,7 +58,7 @@ describe "Documents" do
scenario "Create" do
visit new_admin_site_customization_document_path
attach_file("document_attachment", Rails.root + "spec/fixtures/files/logo.pdf")
attach_file("document_attachment", "#{Rails.root}/spec/fixtures/files/logo.pdf")
click_button "Upload"
expect(page).to have_content "Document uploaded succesfully"