consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply Layout/RedundantLineBreak rule to short lines

Browse Source 
We're not adding the rule because it would apply the current line length
rule of 110 characters per line. We still haven't decided whether we'll
keep that rule or make lines shorter so they're easier to read,
particularly when vertically splitting the editor window.

So, for now, I'm applying the rule to lines which are about 90
characters long.
This commit is contained in:
Javi Martín
2021-08-11 19:17:31 +02:00
parent ac5c9459c7
commit 65c9786db7
44 changed files with 103 additions and 310 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
spec/models/budget/investment_spec.rb
View File

@@ -430,9 +430,7 @@ describe Budget::Investment do
describe "with without_admin filter" do
let(:params) { { advanced_filters: ["without_admin"], budget_id: budget.id } }
it "returns only investment without admin" do
create(:budget_investment,
:with_administrator,
budget: budget)
create(:budget_investment, :with_administrator, budget: budget)
investment2 = create(:budget_investment, budget: budget)
expect(Budget::Investment.scoped_filter(params, "all")).to eq([investment2])
@@ -442,14 +440,9 @@ describe Budget::Investment do
describe "with without_valuator filter" do
let(:params) { { advanced_filters: ["without_valuator"], budget_id: budget.id } }
it "returns only investment without valuator" do
create(:budget_investment,
:with_valuator,
budget: budget)
investment2 = create(:budget_investment,
:with_administrator,
budget: budget)
investment3 = create(:budget_investment,
budget: budget)
create(:budget_investment, :with_valuator, budget: budget)
investment2 = create(:budget_investment, :with_administrator, budget: budget)
investment3 = create(:budget_investment, budget: budget)
expect(Budget::Investment.scoped_filter(params, "all"))
.to contain_exactly(investment2, investment3)
@@ -471,14 +464,9 @@ describe Budget::Investment do
describe "with valuation_finished filter" do
let(:params) { { advanced_filters: ["valuation_finished"], budget_id: budget.id } }
it "returns only investment with valuation finished" do
investment1 = create(:budget_investment,
:selected,
budget: budget)
create(:budget_investment,
:with_administrator,
budget: budget)
create(:budget_investment,
budget: budget)
investment1 = create(:budget_investment, :selected, budget: budget)
create(:budget_investment, :with_administrator, budget: budget)
create(:budget_investment, budget: budget)
expect(Budget::Investment.scoped_filter(params, "all")).to eq([investment1])
end