From 6562d8b9d887c6624e5bb72060ca79ccd3a7d367 Mon Sep 17 00:00:00 2001 From: Bertocq Date: Wed, 21 Jun 2017 22:34:16 +0200 Subject: [PATCH] Fix all Layout/SpaceBeforeFirstArg rubocop issues and remove from rubocop_todo list --- .rubocop_todo.yml | 7 ------- spec/factories.rb | 2 +- spec/features/tags/budget_investments_spec.rb | 2 +- spec/models/budget/investment_spec.rb | 8 ++++---- 4 files changed, 6 insertions(+), 13 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 148e3b4b2..701bacf1a 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -620,13 +620,6 @@ Layout/SpaceBeforeComma: - 'spec/controllers/management/sessions_controller_spec.rb' - 'spec/controllers/management/users_controller_spec.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: AllowForAlignment. -Layout/SpaceBeforeFirstArg: - Exclude: - - 'spec/factories.rb' - # Offense count: 9 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. diff --git a/spec/factories.rb b/spec/factories.rb index 31a14ed50..3e7b1b674 100644 --- a/spec/factories.rb +++ b/spec/factories.rb @@ -99,7 +99,7 @@ FactoryGirl.define do factory :verified_user do document_number - document_type 'dni' + document_type 'dni' end factory :debate do diff --git a/spec/features/tags/budget_investments_spec.rb b/spec/features/tags/budget_investments_spec.rb index 4c978c740..1269b0a21 100644 --- a/spec/features/tags/budget_investments_spec.rb +++ b/spec/features/tags/budget_investments_spec.rb @@ -87,7 +87,7 @@ feature 'Tags' do select 'Health: More hospitals', from: 'budget_investment_heading_id' fill_in 'budget_investment_title', with: 'Build a skyscraper' fill_in_ckeditor 'budget_investment_description', with: 'If I had a gym near my place I could go do Zumba' - check 'budget_investment_terms_of_service' + check 'budget_investment_terms_of_service' find('.js-add-tag-link', text: 'Education').click click_button 'Create Investment' diff --git a/spec/models/budget/investment_spec.rb b/spec/models/budget/investment_spec.rb index c5af04ea1..3f1e89d60 100644 --- a/spec/models/budget/investment_spec.rb +++ b/spec/models/budget/investment_spec.rb @@ -591,10 +591,10 @@ describe Budget::Investment do least_voted2 = create(:budget_investment, cached_votes_up: 1) - expect(Budget::Investment.sort_by_confidence_score.first).to eq most_voted2 - expect(Budget::Investment.sort_by_confidence_score.second).to eq most_voted - expect(Budget::Investment.sort_by_confidence_score.third).to eq least_voted2 - expect(Budget::Investment.sort_by_confidence_score.fourth).to eq least_voted + expect(Budget::Investment.sort_by_confidence_score.first).to eq most_voted2 + expect(Budget::Investment.sort_by_confidence_score.second).to eq most_voted + expect(Budget::Investment.sort_by_confidence_score.third).to eq least_voted2 + expect(Budget::Investment.sort_by_confidence_score.fourth).to eq least_voted end end end