From 64f5c4e7f19ac52216fc191626b0207eb47ab398 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= Date: Wed, 5 Aug 2015 17:56:14 +0200 Subject: [PATCH] shows "0%" when there's zero votes Closes #97 --- app/helpers/application_helper.rb | 2 +- spec/features/votes_spec.rb | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 499265f5a..c417ef6b0 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -5,7 +5,7 @@ module ApplicationHelper end def percentage(vote, debate) - return if debate.total_votes == 0 + return "0%" if debate.total_votes == 0 debate.send(vote).percent_of(debate.total_votes).to_s + "%" end diff --git a/spec/features/votes_spec.rb b/spec/features/votes_spec.rb index 3e44f4f0e..f498bbd8f 100644 --- a/spec/features/votes_spec.rb +++ b/spec/features/votes_spec.rb @@ -13,6 +13,20 @@ feature 'Votes' do visit debate_path(@debate) end + scenario 'Show no votes' do + visit debate_path(@debate) + + expect(page).to have_content "0 votes" + + within('#in_favor') do + expect(page).to have_content "0%" + end + + within('#against') do + expect(page).to have_content "0%" + end + end + scenario 'Show' do vote = create(:vote, voter: @manuela, votable: @debate, vote_flag: true) vote = create(:vote, voter: @pablo, votable: @debate, vote_flag: false)