consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix queries and scopes after column deletion

Browse Source 
Some queries were accessing original column instead of the new translatable one. This should have been causing unexpected behavior for requests maded in a different locale than the application default.
This commit is contained in:
taitus
2019-03-26 12:51:23 +01:00
committed by Julian Herrero
parent fbfe5b3468
commit 638c80760f
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/budget/group.rb
View File

@@ -28,7 +28,7 @@ class Budget
validates :budget_id, presence: true validates :budget_id, presence: true
validates :slug, presence: true, format: /\A[a-z0-9\-_]+\z/ validates :slug, presence: true, format: /\A[a-z0-9\-_]+\z/
scope :sort_by_name, -> { includes(:translations).order(:name) } scope :sort_by_name, -> { joins(:translations).order(:name) }
def single_heading_group? def single_heading_group?
headings.count == 1 headings.count == 1

2
app/models/user.rb
View File

@@ -128,7 +128,7 @@ class User < ActiveRecord::Base
end end
def headings_voted_within_group(group) def headings_voted_within_group(group)
Budget::Heading.order("name").where(id: voted_investments.by_group(group).pluck(:heading_id)) Budget::Heading.joins(:translations).order("name").where(id: voted_investments.by_group(group).pluck(:heading_id))
end end
def voted_investments def voted_investments