From 6214bda9410c29cd5a9e4579d19611314db3611b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 24 Oct 2019 00:30:44 +0200 Subject: [PATCH] Move already in use Rails rules to basic cops We were already applying the FindEach rule since commit cae210c1, while the EnumUniqueness rule is essential when we use `enum`, and the EnvironmentComparison rule is very useful since it forces us to use a format the UnknownEnv rule will recognize. --- .rubocop.yml | 9 --------- .rubocop_basic.yml | 9 +++++++++ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 911117346..07be03932 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -15,18 +15,9 @@ Performance/EndWith: Performance/StartWith: Enabled: true -Rails/EnumUniqueness: - Enabled: true - -Rails/EnvironmentComparison: - Enabled: true - Rails/Exit: Enabled: true -Rails/FindEach: - Enabled: true - Rails/HasAndBelongsToMany: Enabled: true diff --git a/.rubocop_basic.yml b/.rubocop_basic.yml index de014d83f..5e4e33887 100644 --- a/.rubocop_basic.yml +++ b/.rubocop_basic.yml @@ -191,9 +191,18 @@ Rails/DynamicFindBy: Enabled: true Severity: refactor +Rails/EnumUniqueness: + Enabled: true + +Rails/EnvironmentComparison: + Enabled: true + Rails/FindBy: Enabled: true +Rails/FindEach: + Enabled: true + Rails/HttpPositionalArguments: Enabled: true