From 6188281d33296c4e093e723c046e9ed62c6ed1f5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Tue, 14 May 2024 00:16:52 +0200
Subject: [PATCH] Don't use instace variables in component views

Just like we do every else (sometimes even on that very same file), we
use the method instead of the instance variable.

We're doing this change now because we're about to modify one of these
files (the poll question answers documents index component).
---
 .../poll/questions/answers/documents/index_component.html.erb | 4 ++--
 .../admin/site_customization/pages/edit_component.html.erb    | 2 +-
 app/components/admin/tenants/index_component.html.erb         | 2 +-
 app/components/sdg/goals/help_page_component.html.erb         | 4 ++--
 app/components/sdg/goals/targets_component.html.erb           | 2 +-
 .../sdg_management/relations/index_component.html.erb         | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/components/admin/poll/questions/answers/documents/index_component.html.erb b/app/components/admin/poll/questions/answers/documents/index_component.html.erb
index 627159982..644bb18b2 100644
--- a/app/components/admin/poll/questions/answers/documents/index_component.html.erb
+++ b/app/components/admin/poll/questions/answers/documents/index_component.html.erb
@@ -1,4 +1,4 @@
-<%= back_link_to admin_question_path(@answer.question) %>
+<%= back_link_to admin_question_path(answer.question) %>
 
 <h2><%= t("admin.questions.show.answers.documents_list") %></h2>
 
@@ -8,7 +8,7 @@
 </ul>
 
 <div class="poll-question-form">
-  <% if can?(:update, @answer) %>
+  <% if can?(:update, answer) %>
     <%= form_for(Poll::Question::Answer.new, url: admin_answer_documents_path(answer)) do |f| %>
       <%= render "shared/errors", resource: answer %>
 
diff --git a/app/components/admin/site_customization/pages/edit_component.html.erb b/app/components/admin/site_customization/pages/edit_component.html.erb
index 2cc012275..f408bd9ef 100644
--- a/app/components/admin/site_customization/pages/edit_component.html.erb
+++ b/app/components/admin/site_customization/pages/edit_component.html.erb
@@ -4,7 +4,7 @@
 <%= header do %>
   <%= render Admin::ActionComponent.new(
     :destroy,
-    @page,
+    page,
     text: t("admin.site_customization.pages.index.delete"),
     confirm: true,
     class: "delete"
diff --git a/app/components/admin/tenants/index_component.html.erb b/app/components/admin/tenants/index_component.html.erb
index 63bb3504e..cfccdff62 100644
--- a/app/components/admin/tenants/index_component.html.erb
+++ b/app/components/admin/tenants/index_component.html.erb
@@ -14,7 +14,7 @@
   </thead>
 
   <tbody>
-    <% @tenants.each do |tenant| %>
+    <% tenants.each do |tenant| %>
       <%= render Admin::Tenants::RowComponent.new(tenant) %>
     <% end %>
   </tbody>
diff --git a/app/components/sdg/goals/help_page_component.html.erb b/app/components/sdg/goals/help_page_component.html.erb
index 613cd2aaf..af052dd8b 100644
--- a/app/components/sdg/goals/help_page_component.html.erb
+++ b/app/components/sdg/goals/help_page_component.html.erb
@@ -8,7 +8,7 @@
   <h1><%= t("sdg.goals.help.title") %></h1>
   <p><%= t("sdg.goals.help.description") %></p>
   <ul class="tabs" id="help_tabs" data-deep-link="true" data-tabs>
-    <% @goals.each do |goal| %>
+    <% goals.each do |goal| %>
       <li class="tabs-title <%= is_active?(goal) %>">
         <%= link_to "#goal_#{goal.code}_tab" do %>
           <% render SDG::Goals::IconComponent.new(goal) %>
@@ -18,7 +18,7 @@
   </ul>
 
   <div class="tabs-content" data-tabs-content="help_tabs">
-    <% @goals.each do |goal| %>
+    <% goals.each do |goal| %>
       <div id="goal_<%= goal.code %>_tab" class="tabs-panel <%= is_active?(goal) %>">
         <h2><%= goal.code_and_title %></h2>
         <p><%= sanitize t("sdg.goals.goal_#{goal.code}.description") %></p>
diff --git a/app/components/sdg/goals/targets_component.html.erb b/app/components/sdg/goals/targets_component.html.erb
index b05a67391..d114b15e3 100644
--- a/app/components/sdg/goals/targets_component.html.erb
+++ b/app/components/sdg/goals/targets_component.html.erb
@@ -2,7 +2,7 @@
   <ul class="tabs" id="goal_<%= goal.code %>_targets" data-deep-link="true" data-tabs>
     <% [global_targets, local_targets].each do |targets| %>
       <li class="tabs-title <%= active(targets) %>">
-        <%= link_to title(targets), "#goal_#{@goal.code}_tab_#{type(targets)}_targets" %>
+        <%= link_to title(targets), "#goal_#{goal.code}_tab_#{type(targets)}_targets" %>
       </li>
     <% end %>
   </ul>
diff --git a/app/components/sdg_management/relations/index_component.html.erb b/app/components/sdg_management/relations/index_component.html.erb
index 57127a51f..544d1b041 100644
--- a/app/components/sdg_management/relations/index_component.html.erb
+++ b/app/components/sdg_management/relations/index_component.html.erb
@@ -14,7 +14,7 @@
   </thead>
 
   <tbody>
-    <% @records.each do |record| %>
+    <% records.each do |record| %>
       <tr>
         <td><%= record.title %></td>
         <td><%= record.sdg_goal_list %></td>