From 651861c4623d80ed8c7cbe62a87254fc4f794658 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Thu, 20 Feb 2020 18:30:39 +0100
Subject: [PATCH] Fix hidden active elements in admin menu

In the admin menu, some links take you to a section, and some links open
a submenu with more links.

When we disable the "multi-open" property of the menu and the active
element is a link which takes you to a section, Foundation will hide it
whenever we click a link which opens a submenu.

The easiest solution is to enable "multi-open" property.
---
 app/views/admin/_menu.html.erb |  2 +-
 spec/features/admin_spec.rb    | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/app/views/admin/_menu.html.erb b/app/views/admin/_menu.html.erb
index 525dbf770..dfcc53e26 100644
--- a/app/views/admin/_menu.html.erb
+++ b/app/views/admin/_menu.html.erb
@@ -1,5 +1,5 @@
 <div class="admin-sidebar">
-  <ul id="admin_menu" data-accordion-menu data-multi-open="false">
+  <ul id="admin_menu" data-accordion-menu data-multi-open="true">
     <% if feature?(:proposals) %>
       <li class="section-title">
         <%= link_to admin_proposals_path do %>
diff --git a/spec/features/admin_spec.rb b/spec/features/admin_spec.rb
index 982956398..c32ec037e 100644
--- a/spec/features/admin_spec.rb
+++ b/spec/features/admin_spec.rb
@@ -84,4 +84,17 @@ describe "Admin" do
     expect(page).not_to have_css("#moderation_menu")
     expect(page).not_to have_css("#valuation_menu")
   end
+
+  scenario "Admin menu does not hide active elements", :js do
+    login_as(administrator)
+    visit admin_budgets_path
+
+    within("#admin_menu") do
+      expect(page).to have_link "Participatory budgets"
+
+      click_link "Site content"
+
+      expect(page).to have_link "Participatory budgets"
+    end
+  end
 end