Simplify controller tests requiring admin login

Similar to what we did in commit 3da4ee00b for system tests.
This commit is contained in:
Javi Martín
2021-03-25 15:00:54 +01:00
parent 24caa749e7
commit 5ef6c9c2b5
5 changed files with 9 additions and 16 deletions

View File

@@ -1,12 +1,9 @@
require "rails_helper"
describe Admin::Api::StatsController do
describe Admin::Api::StatsController, :admin do
describe "GET index" do
let(:user) { create(:administrator).user }
context "events or visits not present" do
it "responds with bad_request" do
sign_in user
get :show
expect(response).not_to be_ok
@@ -29,7 +26,6 @@ describe Admin::Api::StatsController do
end
it "returns single events formated for working with c3.js" do
sign_in user
get :show, params: { event: "foo" }
expect(response).to be_ok
@@ -48,7 +44,6 @@ describe Admin::Api::StatsController do
create :visit, started_at: time_1
create :visit, started_at: time_2
sign_in user
get :show, params: { visits: true }
expect(response).to be_ok
@@ -67,7 +62,6 @@ describe Admin::Api::StatsController do
create(:budget_investment, created_at: time_2)
create(:budget_investment, created_at: time_2)
sign_in user
get :show, params: { budget_investments: true }
expect(response).to be_ok

View File

@@ -1,10 +1,9 @@
require "rails_helper"
describe Admin::BudgetInvestmentsController do
describe Admin::BudgetInvestmentsController, :admin do
describe "PATCH update" do
it "does not redirect on AJAX requests" do
investment = create(:budget_investment)
sign_in(create(:administrator).user)
patch :update, params: {
id: investment,

View File

@@ -1,8 +1,6 @@
require "rails_helper"
describe Admin::HiddenDebatesController do
before { sign_in create(:administrator).user }
describe Admin::HiddenDebatesController, :admin do
describe "PUT confirm_hide" do
it "keeps query parameters while using protected redirects" do
debate = create(:debate, :hidden)

View File

@@ -1,8 +1,6 @@
require "rails_helper"
describe Admin::OrganizationsController do
before { sign_in create(:administrator).user }
describe Admin::OrganizationsController, :admin do
describe "PUT verify" do
it "keeps query parameters while using protected redirects" do
organization = create(:organization)

View File

@@ -70,10 +70,14 @@ RSpec.configure do |config|
Bullet.end_request
end
config.before(:each, :admin) do
config.before(:each, :admin, type: :system) do
login_as(create(:administrator).user)
end
config.before(:each, :admin, type: :controller) do
sign_in(create(:administrator).user)
end
config.before(:each, :delay_jobs) do
Delayed::Worker.delay_jobs = true
end