consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor communities controller. Add missing specs on topics order.

Browse Source
This commit is contained in:
taitus
2017-09-06 12:34:38 +02:00
parent 65e1867af8
commit 5ea16976f7
2 changed files with 45 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/controllers/communities_controller.rb
View File

@@ -1,8 +1,8 @@
class CommunitiesController < ApplicationController
TOPIC_ORDERS = %w{newest most_commented oldest}.freeze
before_action :set_order, :set_community, :load_topics, :load_participants
before_action :set_order, :set_community, :load_topics, :load_participants, only: :show
has_orders %w{newest most_commented oldest}, only: :show
has_orders TOPIC_ORDERS
skip_authorization_check
@@ -13,7 +13,7 @@ class CommunitiesController < ApplicationController
private
def set_order
@order = params[:order].present? ? params[:order] : "newest"
@order = valid_order? ? params[:order] : "newest"
end
def set_community
@@ -27,4 +27,8 @@ class CommunitiesController < ApplicationController
def load_participants
@participants = @community.participants
end
def valid_order?
params[:order].present? && TOPIC_ORDERS.include?(params[:order])
end
end