consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use the same color for solid and hollow buttons

Browse Source 
Should hollow buttons use the same color as links do or the same color
as solid buttons do? In the default scenario, it doesn't matter, since
links and solid buttons use the same color. However, it matters when
people customize the application so links and solid buttons don't use
the same color.

I'm choosing to use the same color for solid and hollow buttons because
these elements are usually isolated and so from the UX perspective they
are similar; links, on the other hand, are often in the middle of some
text.

Note we're talking about links and buttons while many of the "buttons"
we use in the application are actually links styled as buttons. Here,
"buttons" means "things that look like buttons".
This commit is contained in:
Javi Martín
2022-10-12 15:13:21 +02:00
parent a16247b258
commit 5dbd694861
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/stylesheets/layout.scss
View File

@@ -146,9 +146,8 @@ button,
}
.button.hollow {
@include normal-selection;
@include brand-text;
border: 1px solid;
color: $link;
}
.button.hollow.error {

2
app/assets/stylesheets/mixins/buttons.scss
View File

@@ -23,7 +23,7 @@
@include base-button;
}
@mixin hollow-button($color: $link) {
@mixin hollow-button($color: $brand) {
@include button($style: hollow, $background: $color);
@include normal-selection;
@include base-button;