consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #4820 from consul/legislation_processes_alert

Browse Source 
Remove unnecessary alert on legislation processes
This commit is contained in:
Sebastia
2022-06-01 11:03:02 +02:00
committed by GitHub
parent a1186ffe56 00f0c4410d
commit 5c6ab81c38
6 changed files with 0 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
app/views/legislation/processes/_debate.html.erb
View File

@@ -1,17 +0,0 @@
<div class="small-12 medium-9 column">
<div class="debate-list">
<% if process.questions.empty? %>
<p><%= t("legislation.processes.debate.empty_questions") %></p>
<% else %>
<%= render process.questions %>
<% end %>
</div>
</div>
<% if process.questions.any? %>
<div class="small-12 medium-3 column">
<div class="callout success">
<p><%= t("legislation.processes.debate.participate") %></p>
</div>
</div>
<% end %>

8
app/views/legislation/processes/debate.html.erb
View File

@@ -20,14 +20,6 @@
<% end %> <% end %>
</div> </div>
</div> </div>
<% if @process.questions.any? %>
<div class="small-12 medium-3 column">
<div class="callout success">
<p><%= t("legislation.processes.debate.participate") %></p>
</div>
</div>
<% end %>
</div> </div>
</div> </div>
</div> </div>

1
config/locales/en/legislation.yml
View File

@@ -54,7 +54,6 @@ en:
winners: Selected winners: Selected
debate: debate:
empty_questions: There aren't any questions empty_questions: There aren't any questions
participate: Participate in the debate
index: index:
filter: Filter filter: Filter
filters: filters:

1
config/locales/es/legislation.yml
View File

@@ -54,7 +54,6 @@ es:
winners: Seleccionadas winners: Seleccionadas
debate: debate:
empty_questions: No hay preguntas empty_questions: No hay preguntas
participate: Realiza tus aportaciones al debate previo participando en los siguientes temas.
index: index:
filter: Filtro filter: Filtro
filters: filters:

4
spec/system/legislation/processes_spec.rb
View File

@@ -255,7 +255,6 @@ describe "Legislation" do
end end
expect(page).to have_content("This is the process homepage") expect(page).to have_content("This is the process homepage")
expect(page).not_to have_content("Participate in the debate")
end end
scenario "disabled", :with_frozen_time do scenario "disabled", :with_frozen_time do
@@ -282,7 +281,6 @@ describe "Legislation" do
visit legislation_process_path(process) visit legislation_process_path(process)
expect(page).to have_content("This phase is not open yet") expect(page).to have_content("This phase is not open yet")
expect(page).not_to have_content("Participate in the debate")
end end
scenario "open without questions" do scenario "open without questions" do
@@ -290,7 +288,6 @@ describe "Legislation" do
visit legislation_process_path(process) visit legislation_process_path(process)
expect(page).not_to have_content("Participate in the debate")
expect(page).not_to have_content("This phase is not open yet") expect(page).not_to have_content("This phase is not open yet")
end end
@@ -303,7 +300,6 @@ describe "Legislation" do
expect(page).to have_content("Question 1") expect(page).to have_content("Question 1")
expect(page).to have_content("Question 2") expect(page).to have_content("Question 2")
expect(page).to have_content("Participate in the debate")
expect(page).not_to have_content("This phase is not open yet") expect(page).not_to have_content("This phase is not open yet")
end end

2
spec/system/legislation/questions_spec.rb
View File

@@ -17,8 +17,6 @@ describe "Legislation" do
scenario "shows question list" do scenario "shows question list" do
visit legislation_process_path(process) visit legislation_process_path(process)
expect(page).to have_content("Participate in the debate")
expect(page).to have_content("Question 1") expect(page).to have_content("Question 1")
expect(page).to have_content("Question 2") expect(page).to have_content("Question 2")
expect(page).to have_content("Question 3") expect(page).to have_content("Question 3")