cleans up routes: use blocks only when necessary

config/routes.rb

@@ -67,9 +67,7 @@ Rails.application.routes.draw do
 
   scope '/participatory_budget' do
     resources :spending_proposals, only: [:index, :new, :create, :show, :destroy], path: 'investment_projects' do
-      member do
+      post :vote, on: :member
-        post :vote
-      end
     end
   end
 
@@ -78,19 +76,17 @@ Rails.application.routes.draw do
   resources :legislations, only: [:show]
 
   resources :annotations do
-    collection do
+    get :search, on: :collection
-      get :search
-    end
   end
 
   resources :users, only: [:show]
 
   resource :account, controller: "account", only: [:show, :update, :delete] do
-    collection { get :erase }
+    get :erase, on: :collection
   end
 
   resources :notifications, only: [:index, :show] do
-    collection { put :mark_all_as_read }
+    put :mark_all_as_read, on: :collection
   end
 
   resource :verification, controller: "verification", only: [:show]
@@ -106,7 +102,7 @@ Rails.application.routes.draw do
   namespace :admin do
     root to: "dashboard#index"
     resources :organizations, only: :index do
-      collection { get :search }
+      get :search, on: :collection
       member do
         put :verify
         put :reject
@@ -150,20 +146,20 @@ Rails.application.routes.draw do
 
     resources :tags, only: [:index, :create, :update, :destroy]
     resources :officials, only: [:index, :edit, :update, :destroy] do
-      collection { get :search}
+      get :search, on: :collection
     end
 
     resources :settings, only: [:index, :update]
     resources :moderators, only: [:index, :create, :destroy] do
-      collection { get :search }
+      get :search, on: :collection
     end
 
     resources :valuators, only: [:index, :create] do
-      collection { get :search }
+      get :search, on: :collection
     end
 
     resources :verifications, controller: :verifications, only: :index do
-      collection { get :search}
+      get :search, on: :collection
     end
 
     resource :activity, controller: :activity, only: :show
@@ -185,30 +181,18 @@ Rails.application.routes.draw do
     end
 
     resources :debates, only: :index do
-      member do
+      put :hide, on: :member
-        put :hide
+      put :moderate, on: :collection
-      end
-      collection do
-        put :moderate
-      end
     end
 
     resources :proposals, only: :index do
-      member do
+      put :hide, on: :member
-        put :hide
+      put :moderate, on: :collection
-      end
-      collection do
-        put :moderate
-      end
     end
 
     resources :comments, only: :index do
-      member do
+      put :hide, on: :member
-        put :hide
+      put :moderate, on: :collection
-      end
-      collection do
-        put :moderate
-      end
     end
   end
 
@@ -216,9 +200,7 @@ Rails.application.routes.draw do
     root to: "spending_proposals#index"
 
     resources :spending_proposals, only: [:index, :show, :edit] do
-      member do
+      patch :valuate, on: :member
-        patch :valuate
-      end
     end
   end
 
@@ -226,30 +208,21 @@ Rails.application.routes.draw do
     root to: "dashboard#index"
 
     resources :document_verifications, only: [:index, :new, :create] do
-      collection do
+      post :check, on: :collection
-        post :check
-      end
     end
 
     resources :email_verifications, only: [:new, :create]
 
     resources :users, only: [:new, :create] do
-      collection do
+      delete :logout, on: :collection
-        delete :logout
-      end
     end
 
     get 'sign_in', to: 'sessions#create'
 
     resource :session, only: [:create, :destroy]
     resources :proposals, only: [:index, :new, :create, :show] do
-      member do
+      post :vote, on: :member
-        post :vote
+      get :print, on: :collection
-      end
-
-      collection do
-        get :print
-      end
     end
 
     resources :spending_proposals, only: [:index, :new, :create, :show] do