consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove Poll White/Null/Total Results models, tables, specs and references

Browse Source
This commit is contained in:
Bertocq
2017-10-02 16:24:53 +02:00
parent b5cf28cb35
commit 58069b35a3
11 changed files with 242 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.rubocop_todo.yml
View File

@@ -283,10 +283,7 @@ Lint/ParenthesesAsGroupedExpression:
# Cop supports --auto-correct. # Cop supports --auto-correct.
Lint/StringConversionInInterpolation: Lint/StringConversionInInterpolation:
Exclude: Exclude:
- 'app/models/poll/null_result.rb'
- 'app/models/poll/partial_result.rb' - 'app/models/poll/partial_result.rb'
- 'app/models/poll/white_result.rb'
- 'app/models/poll/total_result.rb'
# Offense count: 15 # Offense count: 15
# Cop supports --auto-correct. # Cop supports --auto-correct.
@@ -533,10 +530,7 @@ Style/MutableConstant:
- 'app/models/activity.rb' - 'app/models/activity.rb'
- 'app/models/budget/reclassified_vote.rb' - 'app/models/budget/reclassified_vote.rb'
- 'app/models/legislation/draft_version.rb' - 'app/models/legislation/draft_version.rb'
- 'app/models/poll/null_result.rb'
- 'app/models/poll/partial_result.rb' - 'app/models/poll/partial_result.rb'
- 'app/models/poll/white_result.rb'
- 'app/models/poll/total_result.rb'
- 'app/models/proposal.rb' - 'app/models/proposal.rb'
- 'app/models/signature_sheet.rb' - 'app/models/signature_sheet.rb'
- 'app/models/site_customization/content_block.rb' - 'app/models/site_customization/content_block.rb'

23
app/models/poll/null_result.rb
View File

@@ -1,23 +0,0 @@
class Poll::NullResult < ActiveRecord::Base
VALID_ORIGINS = %w{web booth}
belongs_to :author, -> { with_hidden }, class_name: 'User', foreign_key: 'author_id'
belongs_to :booth_assignment
belongs_to :officer_assignment
validates :author, presence: true
validates :origin, inclusion: {in: VALID_ORIGINS}
scope :by_author, ->(author_id) { where(author_id: author_id) }
before_save :update_logs
def update_logs
if amount_changed? && amount_was.present?
self.amount_log += ":#{amount_was.to_s}"
self.officer_assignment_id_log += ":#{officer_assignment_id_was.to_s}"
self.author_id_log += ":#{author_id_was.to_s}"
end
end
end

23
app/models/poll/total_result.rb
View File

@@ -1,23 +0,0 @@
class Poll::TotalResult < ActiveRecord::Base
VALID_ORIGINS = %w{web booth}
belongs_to :author, -> { with_hidden }, class_name: 'User', foreign_key: 'author_id'
belongs_to :booth_assignment
belongs_to :officer_assignment
validates :author, presence: true
validates :origin, inclusion: {in: VALID_ORIGINS}
scope :by_author, ->(author_id) { where(author_id: author_id) }
before_save :update_logs
def update_logs
if amount_changed? && amount_was.present?
self.amount_log += ":#{amount_was.to_s}"
self.officer_assignment_id_log += ":#{officer_assignment_id_was.to_s}"
self.author_id_log += ":#{author_id_was.to_s}"
end
end
end

23
app/models/poll/white_result.rb
View File

@@ -1,23 +0,0 @@
class Poll::WhiteResult < ActiveRecord::Base
VALID_ORIGINS = %w{web booth}
belongs_to :author, -> { with_hidden }, class_name: 'User', foreign_key: 'author_id'
belongs_to :booth_assignment
belongs_to :officer_assignment
validates :author, presence: true
validates :origin, inclusion: {in: VALID_ORIGINS}
scope :by_author, ->(author_id) { where(author_id: author_id) }
before_save :update_logs
def update_logs
if amount_changed? && amount_was.present?
self.amount_log += ":#{amount_was.to_s}"
self.officer_assignment_id_log += ":#{officer_assignment_id_was.to_s}"
self.author_id_log += ":#{author_id_was.to_s}"
end
end
end

16
db/migrate/20171002133547_remove_poll_white_null_total_results.rb Normal file
View File

@@ -0,0 +1,16 @@
class RemovePollWhiteNullTotalResults < ActiveRecord::Migration
def change
remove_index :poll_null_results, column: [:booth_assignment_id]
remove_index :poll_null_results, column: [:officer_assignment_id]
remove_index :poll_white_results, column: [:booth_assignment_id]
remove_index :poll_white_results, column: [:officer_assignment_id]
remove_index :poll_total_results, column: [:booth_assignment_id]
remove_index :poll_total_results, column: [:officer_assignment_id]
drop_table :poll_null_results
drop_table :poll_total_results
drop_table :poll_white_results
end
end

51
db/schema.rb
View File

@@ -11,7 +11,7 @@
# #
# It's strongly recommended that you check this file into your version control system. # It's strongly recommended that you check this file into your version control system.
ActiveRecord::Schema.define(version: 20171002122312) do ActiveRecord::Schema.define(version: 20171002133547) do
# These are extensions that must be enabled in order to support this database # These are extensions that must be enabled in order to support this database
enable_extension "plpgsql" enable_extension "plpgsql"
@@ -613,21 +613,6 @@ ActiveRecord::Schema.define(version: 20171002122312) do
t.string "location" t.string "location"
end end
create_table "poll_null_results", force: :cascade do |t|
t.integer "author_id"
t.integer "amount"
t.string "origin"
t.date "date"
t.integer "booth_assignment_id"
t.integer "officer_assignment_id"
t.text "amount_log", default: ""
t.text "officer_assignment_id_log", default: ""
t.text "author_id_log", default: ""
end
add_index "poll_null_results", ["booth_assignment_id"], name: "index_poll_null_results_on_booth_assignment_id", using: :btree
add_index "poll_null_results", ["officer_assignment_id"], name: "index_poll_null_results_on_officer_assignment_id", using: :btree
create_table "poll_officer_assignments", force: :cascade do |t| create_table "poll_officer_assignments", force: :cascade do |t|
t.integer "booth_assignment_id" t.integer "booth_assignment_id"
t.integer "officer_id" t.integer "officer_id"
@@ -724,21 +709,6 @@ ActiveRecord::Schema.define(version: 20171002122312) do
add_index "poll_shifts", ["booth_id"], name: "index_poll_shifts_on_booth_id", using: :btree add_index "poll_shifts", ["booth_id"], name: "index_poll_shifts_on_booth_id", using: :btree
add_index "poll_shifts", ["officer_id"], name: "index_poll_shifts_on_officer_id", using: :btree add_index "poll_shifts", ["officer_id"], name: "index_poll_shifts_on_officer_id", using: :btree
create_table "poll_total_results", force: :cascade do |t|
t.integer "author_id"
t.integer "amount"
t.string "origin"
t.date "date"
t.integer "booth_assignment_id"
t.integer "officer_assignment_id"
t.text "amount_log", default: ""
t.text "officer_assignment_id_log", default: ""
t.text "author_id_log", default: ""
end
add_index "poll_total_results", ["booth_assignment_id"], name: "index_poll_total_results_on_booth_assignment_id", using: :btree
add_index "poll_total_results", ["officer_assignment_id"], name: "index_poll_total_results_on_officer_assignment_id", using: :btree
create_table "poll_voters", force: :cascade do |t| create_table "poll_voters", force: :cascade do |t|
t.string "document_number" t.string "document_number"
t.string "document_type" t.string "document_type"
@@ -761,21 +731,6 @@ ActiveRecord::Schema.define(version: 20171002122312) do
add_index "poll_voters", ["poll_id"], name: "index_poll_voters_on_poll_id", using: :btree add_index "poll_voters", ["poll_id"], name: "index_poll_voters_on_poll_id", using: :btree
add_index "poll_voters", ["user_id"], name: "index_poll_voters_on_user_id", using: :btree add_index "poll_voters", ["user_id"], name: "index_poll_voters_on_user_id", using: :btree
create_table "poll_white_results", force: :cascade do |t|
t.integer "author_id"
t.integer "amount"
t.string "origin"
t.date "date"
t.integer "booth_assignment_id"
t.integer "officer_assignment_id"
t.text "amount_log", default: ""
t.text "officer_assignment_id_log", default: ""
t.text "author_id_log", default: ""
end
add_index "poll_white_results", ["booth_assignment_id"], name: "index_poll_white_results_on_booth_assignment_id", using: :btree
add_index "poll_white_results", ["officer_assignment_id"], name: "index_poll_white_results_on_officer_assignment_id", using: :btree
create_table "polls", force: :cascade do |t| create_table "polls", force: :cascade do |t|
t.string "name" t.string "name"
t.datetime "starts_at" t.datetime "starts_at"
@@ -1135,8 +1090,6 @@ ActiveRecord::Schema.define(version: 20171002122312) do
add_foreign_key "organizations", "users" add_foreign_key "organizations", "users"
add_foreign_key "poll_answers", "poll_questions", column: "question_id" add_foreign_key "poll_answers", "poll_questions", column: "question_id"
add_foreign_key "poll_booth_assignments", "polls" add_foreign_key "poll_booth_assignments", "polls"
add_foreign_key "poll_null_results", "poll_booth_assignments", column: "booth_assignment_id"
add_foreign_key "poll_null_results", "poll_officer_assignments", column: "officer_assignment_id"
add_foreign_key "poll_officer_assignments", "poll_booth_assignments", column: "booth_assignment_id" add_foreign_key "poll_officer_assignments", "poll_booth_assignments", column: "booth_assignment_id"
add_foreign_key "poll_partial_results", "poll_booth_assignments", column: "booth_assignment_id" add_foreign_key "poll_partial_results", "poll_booth_assignments", column: "booth_assignment_id"
add_foreign_key "poll_partial_results", "poll_officer_assignments", column: "officer_assignment_id" add_foreign_key "poll_partial_results", "poll_officer_assignments", column: "officer_assignment_id"
@@ -1148,8 +1101,6 @@ ActiveRecord::Schema.define(version: 20171002122312) do
add_foreign_key "poll_recounts", "poll_booth_assignments", column: "booth_assignment_id" add_foreign_key "poll_recounts", "poll_booth_assignments", column: "booth_assignment_id"
add_foreign_key "poll_recounts", "poll_officer_assignments", column: "officer_assignment_id" add_foreign_key "poll_recounts", "poll_officer_assignments", column: "officer_assignment_id"
add_foreign_key "poll_voters", "polls" add_foreign_key "poll_voters", "polls"
add_foreign_key "poll_white_results", "poll_booth_assignments", column: "booth_assignment_id"
add_foreign_key "poll_white_results", "poll_officer_assignments", column: "officer_assignment_id"
add_foreign_key "proposals", "communities" add_foreign_key "proposals", "communities"
add_foreign_key "users", "geozones" add_foreign_key "users", "geozones"
add_foreign_key "valuators", "users" add_foreign_key "valuators", "users"

449
knapsack_rspec_report.json
View File

@@ -1,226 +1,227 @@
{ {
"spec/helpers/comments_helper_spec.rb": 0.010898828506469727, "spec/models/setting_spec.rb": 0.07869887351989746,
"spec/controllers/graphql_controller_spec.rb": 0.7817962169647217, "spec/features/admin/managers_spec.rb": 5.029380798339844,
"spec/controllers/concerns/has_orders_spec.rb": 0.09597063064575195, "spec/features/management/managed_users_spec.rb": 3.1642160415649414,
"spec/features/officing/results_spec.rb": 2.6492855548858643, "spec/features/admin/poll/booths_spec.rb": 1.4152588844299316,
"spec/models/poll/question_spec.rb": 0.09519433975219727, "spec/features/admin/comments_spec.rb": 3.889301061630249,
"spec/features/organizations_spec.rb": 1.9025108814239502, "spec/helpers/admin_helper_spec.rb": 0.005057334899902344,
"spec/models/legislation/process_spec.rb": 0.09253501892089844, "spec/models/abilities/moderator_spec.rb": 2.3274271488189697,
"spec/lib/acts_as_paranoid_aliases_spec.rb": 0.2438969612121582, "spec/controllers/admin/api/stats_controller_spec.rb": 0.4249396324157715,
"spec/features/officing_spec.rb": 1.4767742156982422, "spec/features/admin/organizations_spec.rb": 3.339292049407959,
"spec/lib/age_spec.rb": 0.0006227493286132812, "spec/features/admin/newsletters_spec.rb": 0.2460641860961914,
"spec/models/proposal_spec.rb": 5.535696983337402, "spec/helpers/geozones_helper_spec.rb": 0.08249163627624512,
"spec/models/abilities/administrator_spec.rb": 2.2431821823120117, "spec/lib/graph_ql/api_types_creator_spec.rb": 0.006573915481567383,
"spec/models/poll/final_recount_spec.rb": 0.1787703037261963, "spec/features/emails_spec.rb": 18.91256046295166,
"spec/lib/graph_ql/query_type_creator_spec.rb": 0.012041091918945312, "spec/features/admin/hidden_users_spec.rb": 1.3854436874389648,
"spec/models/verification/management/email_spec.rb": 0.06403493881225586, "spec/features/welcome_spec.rb": 1.1956276893615723,
"spec/models/flag_spec.rb": 0.46442556381225586, "spec/features/sessions_spec.rb": 0.3943772315979004,
"spec/features/tags/budget_investments_spec.rb": 23.748523235321045, "spec/models/custom/residence_spec.rb": 0.07002687454223633,
"spec/features/campaigns_spec.rb": 1.3289697170257568, "spec/models/poll/booth_spec.rb": 0.05489993095397949,
"spec/features/admin/activity_spec.rb": 7.763890743255615, "spec/models/direct_message_spec.rb": 0.3973381519317627,
"spec/features/polls/questions_spec.rb": 2.61055326461792, "spec/features/valuation/budget_investments_spec.rb": 7.6013023853302,
"spec/features/polls/polls_spec.rb": 2.313369035720825, "spec/models/map_location_spec.rb": 0.12476563453674316,
"spec/features/home_spec.rb": 0.9780440330505371, "spec/models/budget/heading_spec.rb": 0.09248590469360352,
"spec/models/poll/partial_result_spec.rb": 0.3302469253540039, "spec/models/user_spec.rb": 2.9006423950195312,
"spec/models/lock_spec.rb": 0.09437012672424316, "spec/features/admin/site_customization/content_blocks_spec.rb": 1.6733989715576172,
"spec/lib/graph_ql/api_types_creator_spec.rb": 0.0069005489349365234, "spec/mailers/mailer_spec.rb": 0.08513784408569336,
"spec/helpers/users_helper_spec.rb": 0.3229796886444092, "spec/models/site_customization/page_spec.rb": 0.015056133270263672,
"spec/lib/local_census_spec.rb": 0.011091947555541992, "spec/features/management/budget_investments_spec.rb": 8.112786293029785,
"spec/helpers/text_helper_spec.rb": 0.0005347728729248047, "spec/features/admin/activity_spec.rb": 12.442089080810547,
"spec/customization_engine_spec.rb": 1.3630127906799316, "spec/features/registration_form_spec.rb": 1.0509357452392578,
"spec/models/legislation/answer_spec.rb": 0.6906075477600098, "spec/controllers/legislation/annotations_controller_spec.rb": 0.8151364326477051,
"spec/models/budget/ballot/line_spec.rb": 0.5054352283477783, "spec/lib/census_caller_spec.rb": 0.018165111541748047,
"spec/features/admin/proposals_spec.rb": 1.6710176467895508, "spec/features/users_auth_spec.rb": 6.5102221965789795,
"spec/features/proposal_ballots_spec.rb": 0.3399386405944824, "spec/features/tags/proposals_spec.rb": 10.001718521118164,
"spec/models/site_customization/content_block_spec.rb": 0.014521121978759766, "spec/features/account_spec.rb": 2.2510504722595215,
"spec/features/admin/site_customization/content_blocks_spec.rb": 1.2890841960906982, "spec/features/admin/users_spec.rb": 0.4342050552368164,
"spec/models/site_customization/page_spec.rb": 0.011090993881225586, "spec/lib/cache_spec.rb": 0.057682037353515625,
"spec/features/verification/email_spec.rb": 1.0991628170013428, "spec/features/valuation_spec.rb": 1.3436784744262695,
"spec/models/proposal_notification_spec.rb": 0.2569601535797119, "spec/models/budget/investment_spec.rb": 12.89230751991272,
"spec/features/registration_form_spec.rb": 0.7285032272338867, "spec/lib/migrate_spending_proposals_to_investments_spec.rb": 0.904367208480835,
"spec/features/communities_spec.rb": 1.7133822441101074, "spec/helpers/settings_helper_spec.rb": 0.02300858497619629,
"spec/features/admin/moderators_spec.rb": 1.2922589778900146, "spec/helpers/application_helper_spec.rb": 0.09152626991271973,
"spec/helpers/geozones_helper_spec.rb": 0.09812736511230469, "spec/models/legislation/draft_version_spec.rb": 0.020322084426879883,
"spec/features/welcome_spec.rb": 1.5019774436950684, "spec/models/legislation/question_spec.rb": 0.3402721881866455,
"spec/controllers/comments_controller_spec.rb": 0.36508607864379883, "spec/models/document_spec.rb": 1.3238348960876465,
"spec/features/admin/legislation/questions_spec.rb": 3.81538724899292, "spec/models/poll/question_spec.rb": 0.12588191032409668,
"spec/controllers/users/registrations_controller_spec.rb": 0.018311023712158203, "spec/features/admin/poll/polls_spec.rb": 11.77881646156311,
"spec/features/comments/debates_spec.rb": 12.265411615371704, "spec/lib/manager_authenticator_spec.rb": 0.006296873092651367,
"spec/features/users_spec.rb": 11.05901050567627, "spec/features/admin/debates_spec.rb": 1.688420295715332,
"spec/models/budget/group_spec.rb": 0.04957008361816406, "spec/features/moderation/debates_spec.rb": 5.343512773513794,
"spec/features/admin/poll/questions_spec.rb": 1.9041199684143066, "spec/controllers/debates_controller_spec.rb": 0.40573883056640625,
"spec/helpers/admin_helper_spec.rb": 0.00651097297668457, "spec/models/tag_cloud_spec.rb": 1.6984672546386719,
"spec/models/abilities/organization_spec.rb": 0.24821996688842773, "spec/models/budget/investment/milestone_spec.rb": 0.15051603317260742,
"spec/features/moderation/comments_spec.rb": 6.318082332611084, "spec/models/proposal_notification_spec.rb": 0.2914905548095703,
"spec/features/admin/poll/polls_spec.rb": 8.88325023651123, "spec/features/budgets/investments_spec.rb": 93.5263159275055,
"spec/models/activity_spec.rb": 0.9704892635345459, "spec/i18n_spec.rb": 96.26275777816772,
"spec/features/verification/level_two_verification_spec.rb": 0.421832799911499, "spec/models/community_spec.rb": 0.16270899772644043,
"spec/models/poll/officer_assignment_spec.rb": 0.029267072677612305, "spec/controllers/graphql_controller_spec.rb": 0.5831413269042969,
"spec/features/admin/verifications_spec.rb": 0.507885217666626, "spec/models/legislation/annotation_spec.rb": 0.16232728958129883,
"spec/mailers/mailer_spec.rb": 0.07406282424926758, "spec/lib/acts_as_taggable_on_spec.rb": 0.5747356414794922,
"spec/models/legislation/draft_version_spec.rb": 0.025011777877807617, "spec/lib/census_api_spec.rb": 0.0021581649780273438,
"spec/models/budget/investment_spec.rb": 9.084597826004028, "spec/features/moderation/comments_spec.rb": 6.70704984664917,
"spec/features/proposals_spec.rb": 183.71455550193787, "spec/models/poll/voter_spec.rb": 0.32018303871154785,
"spec/features/tags_spec.rb": 2.949070453643799, "spec/features/proposal_notifications_spec.rb": 3.906450033187866,
"spec/features/tags/debates_spec.rb": 4.345250368118286, "spec/models/budget/result_spec.rb": 0.8468267917633057,
"spec/features/admin/geozones_spec.rb": 1.935765027999878, "spec/helpers/users_helper_spec.rb": 0.25751638412475586,
"spec/features/admin/feature_flags_spec.rb": 0.8357558250427246, "spec/features/valuation/budgets_spec.rb": 0.2564871311187744,
"spec/models/user_spec.rb": 2.436626434326172, "spec/controllers/users/registrations_controller_spec.rb": 0.022383689880371094,
"spec/features/moderation/debates_spec.rb": 6.05112886428833, "spec/controllers/management/base_controller_spec.rb": 0.06711888313293457,
"spec/models/legislation/annotation_spec.rb": 0.21427702903747559, "spec/features/admin/officials_spec.rb": 0.893528938293457,
"spec/features/comments/proposals_spec.rb": 32.52879500389099, "spec/features/comments/topics_spec.rb": 29.998314142227173,
"spec/controllers/legislation/answers_controller_spec.rb": 0.3481717109680176, "spec/features/users_spec.rb": 11.885858297348022,
"spec/features/verification/sms_spec.rb": 1.2817349433898926, "spec/models/topic_spec.rb": 0.27634167671203613,
"spec/features/admin/budget_investments_spec.rb": 16.1332266330719, "spec/models/follow_spec.rb": 0.1256728172302246,
"spec/features/notifications_spec.rb": 14.857182264328003, "spec/lib/local_census_spec.rb": 0.005529880523681641,
"spec/lib/tag_sanitizer_spec.rb": 0.0005936622619628906, "spec/features/verification/sms_spec.rb": 1.5214743614196777,
"spec/controllers/admin/api/stats_controller_spec.rb": 0.3948392868041992, "spec/helpers/comments_helper_spec.rb": 0.010879278182983398,
"spec/features/comments/topics_spec.rb": 29.646622896194458, "spec/models/valuator_spec.rb": 0.02650904655456543,
"spec/models/debate_spec.rb": 5.2278876304626465, "spec/features/proposal_ballots_spec.rb": 0.3937220573425293,
"spec/lib/email_digests_spec.rb": 0.6660604476928711, "spec/features/proposals_spec.rb": 142.48229122161865,
"spec/models/abilities/everyone_spec.rb": 0.06328749656677246, "spec/features/legislation/processes_spec.rb": 2.863476514816284,
"spec/features/direct_messages_spec.rb": 1.3006987571716309, "spec/features/ckeditor_spec.rb": 0.8433480262756348,
"spec/features/debates_spec.rb": 28.736626386642456, "spec/models/letter_spec.rb": 0.0695810317993164,
"spec/models/setting_spec.rb": 0.07938265800476074, "spec/features/admin/budget_investments_spec.rb": 18.484699964523315,
"spec/models/legislation/question_option_spec.rb": 0.058206796646118164, "spec/models/officing/residence_spec.rb": 0.3402073383331299,
"spec/models/verification/management/document_spec.rb": 0.013574600219726562, "spec/controllers/concerns/has_orders_spec.rb": 0.1844041347503662,
"spec/models/poll/booth_spec.rb": 0.07824325561523438, "spec/features/admin/legislation/processes_spec.rb": 4.020649433135986,
"spec/features/admin/legislation/draft_versions_spec.rb": 3.750009059906006, "spec/features/management/users_spec.rb": 2.288966178894043,
"spec/features/admin/poll/officers_spec.rb": 1.4151291847229004, "spec/lib/tasks/communities_spec.rb": 0.15353775024414062,
"spec/features/moderation_spec.rb": 1.9578778743743896, "spec/models/abilities/organization_spec.rb": 0.24793481826782227,
"spec/features/legislation/questions_spec.rb": 1.7689197063446045, "spec/features/polls/polls_spec.rb": 2.591568946838379,
"spec/features/officing/residence_spec.rb": 0.971078634262085, "spec/features/communities_spec.rb": 1.6137127876281738,
"spec/models/follow_spec.rb": 0.12199592590332031, "spec/models/legislation/process/phase_spec.rb": 0.07121586799621582,
"spec/lib/census_api_spec.rb": 0.0019702911376953125, "spec/features/officing_spec.rb": 0.979363203048706,
"spec/models/tag_cloud_spec.rb": 1.5725350379943848, "spec/features/site_customization/custom_pages_spec.rb": 0.5588700771331787,
"spec/models/budget_spec.rb": 0.2335052490234375, "spec/features/comments/legislation_questions_spec.rb": 14.133169889450073,
"spec/features/management/localization_spec.rb": 1.1911811828613281, "spec/features/organizations_spec.rb": 0.46280837059020996,
"spec/features/legislation/draft_versions_spec.rb": 8.151643514633179, "spec/controllers/legislation/answers_controller_spec.rb": 0.39082813262939453,
"spec/models/budget/heading_spec.rb": 0.09901237487792969, "spec/models/image_spec.rb": 7.636544466018677,
"spec/models/poll/poll_spec.rb": 0.46999382972717285, "spec/features/management/account_spec.rb": 1.150636911392212,
"spec/models/custom/residence_spec.rb": 0.050164222717285156, "spec/models/abilities/common_spec.rb": 5.959435701370239,
"spec/models/notification_spec.rb": 0.39408183097839355, "spec/features/comments/debates_spec.rb": 13.69457721710205,
"spec/features/budgets/ballots_spec.rb": 27.406018257141113, "spec/models/poll/shift_spec.rb": 0.19109749794006348,
"spec/mailers/devise_mailer_spec.rb": 0.16486406326293945, "spec/features/site_customization/content_blocks_spec.rb": 0.3058288097381592,
"spec/features/admin/debates_spec.rb": 1.546919345855713, "spec/models/poll/recount_spec.rb": 0.1983809471130371,
"spec/features/valuation/budgets_spec.rb": 0.2552778720855713, "spec/features/verification/level_two_verification_spec.rb": 0.4596068859100342,
"spec/models/abilities/common_spec.rb": 6.724466562271118, "spec/features/verification/level_three_verification_spec.rb": 1.456559658050537,
"spec/models/residence_spec.rb": 0.24986696243286133, "spec/lib/tasks/settings_spec.rb": 0.04654407501220703,
"spec/features/officing/voters_spec.rb": 2.954087257385254, "spec/features/admin/budget_investment_milestones_spec.rb": 1.3974273204803467,
"spec/models/vote_spec.rb": 1.3241477012634277, "spec/features/management/localization_spec.rb": 1.1653187274932861,
"spec/lib/migrate_spending_proposals_to_investments_spec.rb": 1.1774518489837646, "spec/features/admin/tags_spec.rb": 1.0751111507415771,
"spec/controllers/management/users_controller_spec.rb": 0.007733821868896484, "spec/features/officing/results_spec.rb": 1.2672057151794434,
"spec/helpers/proposals_helper_spec.rb": 0.21885180473327637, "spec/features/admin/poll/booth_assigments_spec.rb": 4.1742753982543945,
"spec/features/ckeditor_spec.rb": 0.7726309299468994, "spec/models/poll/officer_assignment_spec.rb": 0.024514198303222656,
"spec/lib/census_caller_spec.rb": 0.009332895278930664, "spec/controllers/management/sessions_controller_spec.rb": 0.07244610786437988,
"spec/features/tracks_spec.rb": 2.7082908153533936, "spec/features/admin/signature_sheets_spec.rb": 1.4268932342529297,
"spec/features/admin/budgets_spec.rb": 4.468225002288818, "spec/models/debate_spec.rb": 4.550540924072266,
"spec/features/admin/valuators_spec.rb": 1.3326430320739746, "spec/features/comments/proposals_spec.rb": 25.726442337036133,
"spec/features/admin/banners_spec.rb": 3.302579164505005, "spec/models/poll/partial_result_spec.rb": 0.32181620597839355,
"spec/features/account_spec.rb": 2.30243182182312, "spec/features/admin/legislation/draft_versions_spec.rb": 3.4613990783691406,
"spec/features/budgets/budgets_spec.rb": 1.0318260192871094, "spec/models/budget_spec.rb": 0.14807415008544922,
"spec/models/poll/answer_spec.rb": 0.11362218856811523, "spec/models/sms_spec.rb": 0.018825769424438477,
"spec/features/comments/budget_investments_spec.rb": 16.92409658432007, "spec/features/admin/proposals_spec.rb": 1.837270975112915,
"spec/features/budgets/results_spec.rb": 2.589841365814209, "spec/models/geozone_spec.rb": 0.11852264404296875,
"spec/features/valuation_spec.rb": 2.126727819442749, "spec/features/admin/banners_spec.rb": 3.0584604740142822,
"spec/features/stats_spec.rb": 0.8516559600830078, "spec/models/legislation/process/publication_spec.rb": 0.06270265579223633,
"spec/features/admin/poll/booths_spec.rb": 1.766916275024414, "spec/lib/graph_ql/query_type_creator_spec.rb": 0.009456157684326172,
"spec/models/legislation/process/phase_spec.rb": 0.0886683464050293, "spec/features/moderation_spec.rb": 1.001516342163086,
"spec/models/budget/investment/milestone_spec.rb": 0.1419520378112793, "spec/features/campaigns_spec.rb": 0.8359789848327637,
"spec/models/letter_spec.rb": 0.08197903633117676, "spec/features/admin/verifications_spec.rb": 0.6421175003051758,
"spec/features/admin/stats_spec.rb": 3.6946730613708496, "spec/features/localization_spec.rb": 0.756089448928833,
"spec/models/identity_spec.rb": 0.004762887954711914, "spec/features/admin/poll/questions_spec.rb": 41.59848093986511,
"spec/features/verification/letter_spec.rb": 1.7480952739715576, "spec/features/tags/debates_spec.rb": 3.4022486209869385,
"spec/models/topic_spec.rb": 0.30414509773254395, "spec/helpers/text_helper_spec.rb": 0.0006229877471923828,
"spec/features/users_auth_spec.rb": 7.242254257202148, "spec/features/admin/moderators_spec.rb": 1.3467354774475098,
"spec/lib/acts_as_taggable_on_spec.rb": 0.7477433681488037, "spec/models/flag_spec.rb": 0.5202171802520752,
"spec/features/official_positions_spec.rb": 1.9427640438079834, "spec/mailers/devise_mailer_spec.rb": 0.2588930130004883,
"spec/features/admin/newsletters_spec.rb": 0.22768402099609375, "spec/features/user_invites_spec.rb": 0.18819189071655273,
"spec/features/admin/hidden_users_spec.rb": 1.4156956672668457, "spec/features/legislation/draft_versions_spec.rb": 9.352471828460693,
"spec/features/comments/legislation_annotations_spec.rb": 18.616747856140137, "spec/features/home_spec.rb": 3.0868682861328125,
"spec/features/admin/site_customization/pages_spec.rb": 1.0219447612762451, "spec/features/budgets/results_spec.rb": 2.4918482303619385,
"spec/models/poll/shift_spec.rb": 0.2051677703857422, "spec/features/budgets/votes_spec.rb": 4.285862922668457,
"spec/models/geozone_spec.rb": 0.12972474098205566, "spec/features/comments/budget_investments_spec.rb": 16.1397545337677,
"spec/helpers/verification_helper_spec.rb": 0.0009250640869140625, "spec/features/admin/stats_spec.rb": 2.678718090057373,
"spec/lib/cache_spec.rb": 0.06447911262512207, "spec/features/polls/questions_spec.rb": 2.594414472579956,
"spec/features/verification/verification_path_spec.rb": 1.2300751209259033, "spec/features/admin/poll/shifts_spec.rb": 4.629284143447876,
"spec/features/sessions_spec.rb": 0.3665180206298828, "spec/helpers/votes_helper_spec.rb": 0.31733107566833496,
"spec/controllers/management/base_controller_spec.rb": 0.019928932189941406, "spec/models/ahoy/data_source_spec.rb": 0.04695439338684082,
"spec/features/verification/verified_user_spec.rb": 0.787623405456543, "spec/models/residence_spec.rb": 0.20260858535766602,
"spec/models/direct_message_spec.rb": 0.49156641960144043, "spec/features/admin_spec.rb": 0.6963987350463867,
"spec/features/admin/tags_spec.rb": 1.045637845993042, "spec/controllers/comments_controller_spec.rb": 0.2683417797088623,
"spec/features/admin/comments_spec.rb": 3.4312756061553955, "spec/lib/age_spec.rb": 0.0007379055023193359,
"spec/features/moderation/users_spec.rb": 1.1841027736663818, "spec/models/legislation/answer_spec.rb": 0.14532899856567383,
"spec/models/budget/reclassified_vote_spec.rb": 0.22663235664367676, "spec/features/tags_spec.rb": 3.0131027698516846,
"spec/features/admin/organizations_spec.rb": 3.4465878009796143, "spec/features/admin/valuators_spec.rb": 1.0099408626556396,
"spec/features/proposal_notifications_spec.rb": 4.40612268447876, "spec/models/notification_spec.rb": 0.37938618659973145,
"spec/features/emails_spec.rb": 13.047018051147461, "spec/views/welcome/index.html.erb_spec.rb": 0.1471250057220459,
"spec/controllers/debates_controller_spec.rb": 0.3078582286834717, "spec/customization_engine_spec.rb": 1.5587348937988281,
"spec/features/budgets/investments_spec.rb": 126.55784440040588, "spec/models/poll/officer_spec.rb": 0.2980079650878906,
"spec/features/verification/residence_spec.rb": 1.8894774913787842, "spec/features/budgets/ballots_spec.rb": 25.24861741065979,
"spec/models/abilities/moderator_spec.rb": 2.7029502391815186, "spec/controllers/concerns/has_filters_spec.rb": 0.1412961483001709,
"spec/helpers/votes_helper_spec.rb": 0.363523006439209, "spec/features/moderation/proposals_spec.rb": 5.947849273681641,
"spec/features/tags/proposals_spec.rb": 8.272820949554443, "spec/features/management/document_verifications_spec.rb": 0.9574480056762695,
"spec/models/signature_spec.rb": 1.6858570575714111, "spec/features/legislation/questions_spec.rb": 1.605849027633667,
"spec/models/legislation/process/publication_spec.rb": 0.0707387924194336, "spec/models/proposal_spec.rb": 5.872406482696533,
"spec/models/community_spec.rb": 0.13965797424316406, "spec/models/legislation/question_option_spec.rb": 0.0395960807800293,
"spec/models/sms_spec.rb": 0.024147987365722656, "spec/features/budgets/budgets_spec.rb": 0.8722023963928223,
"spec/lib/graphql_spec.rb": 3.7293970584869385, "spec/lib/email_digests_spec.rb": 0.440814733505249,
"spec/lib/tasks/communities_spec.rb": 0.17484474182128906, "spec/features/official_positions_spec.rb": 1.5717194080352783,
"spec/features/management/proposals_spec.rb": 4.549585580825806, "spec/features/officing/residence_spec.rb": 0.9819045066833496,
"spec/models/document_spec.rb": 1.2667145729064941, "spec/features/officing/voters_spec.rb": 2.078903913497925,
"spec/features/site_customization/content_blocks_spec.rb": 0.3020951747894287, "spec/features/direct_messages_spec.rb": 1.6070659160614014,
"spec/features/localization_spec.rb": 0.5679850578308105, "spec/models/abilities/everyone_spec.rb": 0.059804677963256836,
"spec/models/signature_sheet_spec.rb": 0.7970001697540283, "spec/lib/acts_as_paranoid_aliases_spec.rb": 0.33096909523010254,
"spec/features/budgets/votes_spec.rb": 4.38911509513855, "spec/features/debates_spec.rb": 32.84718298912048,
"spec/features/verification/level_three_verification_spec.rb": 1.2754230499267578, "spec/features/votes_spec.rb": 18.217467069625854,
"spec/features/admin/users_spec.rb": 0.3584918975830078, "spec/models/activity_spec.rb": 1.0154414176940918,
"spec/models/abilities/valuator_spec.rb": 1.1300320625305176, "spec/controllers/pages_controller_spec.rb": 0.19468045234680176,
"spec/models/officing/residence_spec.rb": 0.3599817752838135, "spec/features/admin/feature_flags_spec.rb": 0.726452112197876,
"spec/features/admin/officials_spec.rb": 0.940401554107666, "spec/models/signature_sheet_spec.rb": 0.6403882503509521,
"spec/features/admin/settings_spec.rb": 0.37268495559692383, "spec/features/admin/poll/officers_spec.rb": 1.2912020683288574,
"spec/models/ahoy/data_source_spec.rb": 0.04887723922729492, "spec/models/lock_spec.rb": 0.08562397956848145,
"spec/helpers/settings_helper_spec.rb": 0.020088911056518555, "spec/helpers/proposals_helper_spec.rb": 0.17275524139404297,
"spec/models/budget/result_spec.rb": 0.7962813377380371, "spec/features/tags/budget_investments_spec.rb": 14.154245615005493,
"spec/models/poll/null_result_spec.rb": 0.17995309829711914, "spec/models/vote_spec.rb": 0.9258472919464111,
"spec/models/valuator_spec.rb": 0.02411341667175293, "spec/features/admin/site_customization/pages_spec.rb": 1.0365827083587646,
"spec/lib/manager_authenticator_spec.rb": 0.0031435489654541016, "spec/features/moderation/users_spec.rb": 1.3000907897949219,
"spec/lib/tasks/settings_spec.rb": 0.07562613487243652, "spec/features/comments/legislation_annotations_spec.rb": 19.67066717147827,
"spec/controllers/legislation/annotations_controller_spec.rb": 0.712010383605957, "spec/features/admin/legislation/questions_spec.rb": 4.043334007263184,
"spec/models/comment_spec.rb": 1.7274408340454102, "spec/models/comment_spec.rb": 1.6633994579315186,
"spec/features/comments/legislation_questions_spec.rb": 15.219935894012451, "spec/features/admin/site_customization/images_spec.rb": 1.2299704551696777,
"spec/features/admin_spec.rb": 1.1390578746795654, "spec/models/abilities/valuator_spec.rb": 1.1985805034637451,
"spec/features/admin/poll/booth_assigments_spec.rb": 3.737426280975342, "spec/models/organization_spec.rb": 0.12121891975402832,
"spec/controllers/pages_controller_spec.rb": 0.3043200969696045, "spec/models/budget/ballot_spec.rb": 0.6403298377990723,
"spec/features/admin/administrators_spec.rb": 2.7916433811187744, "spec/lib/wysiwyg_sanitizer_spec.rb": 0.0018651485443115234,
"spec/models/poll/total_result_spec.rb": 0.549537181854248, "spec/features/stats_spec.rb": 0.8169982433319092,
"spec/features/management/managed_users_spec.rb": 4.38576078414917, "spec/models/poll/answer_spec.rb": 0.13266730308532715,
"spec/models/poll/officer_spec.rb": 0.49225711822509766, "spec/features/admin/settings_spec.rb": 3.1228368282318115,
"spec/features/user_invites_spec.rb": 0.21891093254089355, "spec/features/verification/verification_path_spec.rb": 1.1146795749664307,
"spec/helpers/application_helper_spec.rb": 0.13661718368530273, "spec/controllers/management/users_controller_spec.rb": 0.004178762435913086,
"spec/features/management/account_spec.rb": 0.9717822074890137, "spec/models/direct_upload_spec.rb": 1.1311051845550537,
"spec/features/management/document_verifications_spec.rb": 1.0395607948303223, "spec/features/management/email_verifications_spec.rb": 0.3727388381958008,
"spec/features/admin/site_customization/images_spec.rb": 1.2623581886291504, "spec/models/abilities/administrator_spec.rb": 2.355985164642334,
"spec/models/organization_spec.rb": 0.16587495803833008, "spec/models/budget/ballot/line_spec.rb": 0.49976515769958496,
"spec/features/management/email_verifications_spec.rb": 0.46370506286621094, "spec/features/verification/letter_spec.rb": 1.5464122295379639,
"spec/features/legislation/processes_spec.rb": 3.2473270893096924, "spec/features/notifications_spec.rb": 19.54401397705078,
"spec/features/admin/managers_spec.rb": 1.1836414337158203, "spec/features/admin/administrators_spec.rb": 1.7901337146759033,
"spec/models/legislation/question_spec.rb": 0.4404168128967285, "spec/models/signature_spec.rb": 1.5397937297821045,
"spec/features/management/budget_investments_spec.rb": 7.179029703140259, "spec/models/identity_spec.rb": 0.0023458003997802734,
"spec/features/admin/signature_sheets_spec.rb": 1.4004056453704834, "spec/models/verification/management/document_spec.rb": 0.017922163009643555,
"spec/features/admin/poll/shifts_spec.rb": 2.6800806522369385, "spec/models/legislation/process_spec.rb": 0.09648776054382324,
"spec/i18n_spec.rb": 58.107173204422, "spec/models/budget/group_spec.rb": 0.049637794494628906,
"spec/features/site_customization/custom_pages_spec.rb": 0.454498291015625, "spec/models/verification/management/email_spec.rb": 0.057023048400878906,
"spec/features/admin/legislation/processes_spec.rb": 3.3492519855499268, "spec/helpers/verification_helper_spec.rb": 0.0009088516235351562,
"spec/features/votes_spec.rb": 16.538654088974, "spec/features/verification/residence_spec.rb": 2.2246382236480713,
"spec/features/admin/budget_investment_milestones_spec.rb": 1.3747622966766357, "spec/features/tracks_spec.rb": 2.320988178253174,
"spec/models/poll/white_result_spec.rb": 0.23045921325683594, "spec/lib/tag_sanitizer_spec.rb": 0.0005729198455810547,
"spec/controllers/management/sessions_controller_spec.rb": 0.06758952140808105, "spec/features/admin/budgets_spec.rb": 4.4486541748046875,
"spec/features/management/users_spec.rb": 2.044326066970825, "spec/models/site_customization/content_block_spec.rb": 0.010473012924194336,
"spec/controllers/concerns/has_filters_spec.rb": 0.275907039642334, "spec/features/verification/email_spec.rb": 0.5266687870025635,
"spec/features/moderation/proposals_spec.rb": 5.00596022605896, "spec/models/budget/reclassified_vote_spec.rb": 0.19786882400512695,
"spec/lib/wysiwyg_sanitizer_spec.rb": 0.0016448497772216797, "spec/features/management/proposals_spec.rb": 4.107697486877441,
"spec/models/budget/ballot_spec.rb": 0.6595156192779541, "spec/models/poll/poll_spec.rb": 0.38217735290527344,
"spec/models/poll/voter_spec.rb": 0.2982313632965088, "spec/features/admin/geozones_spec.rb": 1.561723232269287,
"spec/features/valuation/budget_investments_spec.rb": 6.490516185760498 "spec/lib/graphql_spec.rb": 3.063258647918701,
"spec/features/verification/verified_user_spec.rb": 0.8179008960723877
} }

15
spec/factories.rb
View File

@@ -554,21 +554,6 @@ FactoryGirl.define do
answer { question.valid_answers.sample } answer { question.valid_answers.sample }
end end
factory :poll_white_result, class: 'Poll::WhiteResult' do
association :author, factory: :user
origin { 'web' }
end
factory :poll_null_result, class: 'Poll::NullResult' do
association :author, factory: :user
origin { 'web' }
end
factory :poll_total_result, class: 'Poll::TotalResult' do
association :author, factory: :user
origin { 'web' }
end
factory :poll_recount, class: 'Poll::Recount' do factory :poll_recount, class: 'Poll::Recount' do
association :author, factory: :user association :author, factory: :user
origin { 'web' } origin { 'web' }

70
spec/models/poll/null_result_spec.rb
View File

@@ -1,70 +0,0 @@
require 'rails_helper'
describe Poll::NullResult do
describe "logging changes" do
it "should update amount_log if amount changes" do
null_result = create(:poll_null_result, amount: 33)
expect(null_result.amount_log).to eq("")
null_result.amount = 33
null_result.save
null_result.amount = 32
null_result.save
null_result.amount = 34
null_result.save
expect(null_result.amount_log).to eq(":33:32")
end
it "should update officer_assignment_id_log if amount changes" do
null_result = create(:poll_null_result, amount: 33)
expect(null_result.amount_log).to eq("")
expect(null_result.officer_assignment_id_log).to eq("")
null_result.amount = 33
null_result.officer_assignment = create(:poll_officer_assignment, id: 101)
null_result.save
null_result.amount = 32
null_result.officer_assignment = create(:poll_officer_assignment, id: 102)
null_result.save
null_result.amount = 34
null_result.officer_assignment = create(:poll_officer_assignment, id: 103)
null_result.save
expect(null_result.amount_log).to eq(":33:32")
expect(null_result.officer_assignment_id_log).to eq(":101:102")
end
it "should update author_id if amount changes" do
null_result = create(:poll_null_result, amount: 33)
expect(null_result.amount_log).to eq("")
expect(null_result.author_id_log).to eq("")
author_A = create(:poll_officer).user
author_B = create(:poll_officer).user
author_C = create(:poll_officer).user
null_result.amount = 33
null_result.author_id = author_A.id
null_result.save!
null_result.amount = 32
null_result.author_id = author_B.id
null_result.save!
null_result.amount = 34
null_result.author_id = author_C.id
null_result.save!
expect(null_result.amount_log).to eq(":33:32")
expect(null_result.author_id_log).to eq(":#{author_A.id}:#{author_B.id}")
end
end
end

70
spec/models/poll/total_result_spec.rb
View File

@@ -1,70 +0,0 @@
require 'rails_helper'
describe Poll::TotalResult do
describe "logging changes" do
it "should update amount_log if amount changes" do
total_result = create(:poll_total_result, amount: 33)
expect(total_result.amount_log).to eq("")
total_result.amount = 33
total_result.save
total_result.amount = 32
total_result.save
total_result.amount = 34
total_result.save
expect(total_result.amount_log).to eq(":33:32")
end
it "should update officer_assignment_id_log if amount changes" do
total_result = create(:poll_total_result, amount: 33)
expect(total_result.amount_log).to eq("")
expect(total_result.officer_assignment_id_log).to eq("")
total_result.amount = 33
total_result.officer_assignment = create(:poll_officer_assignment, id: 101)
total_result.save
total_result.amount = 32
total_result.officer_assignment = create(:poll_officer_assignment, id: 102)
total_result.save
total_result.amount = 34
total_result.officer_assignment = create(:poll_officer_assignment, id: 103)
total_result.save
expect(total_result.amount_log).to eq(":33:32")
expect(total_result.officer_assignment_id_log).to eq(":101:102")
end
it "should update author_id if amount changes" do
total_result = create(:poll_total_result, amount: 33)
expect(total_result.amount_log).to eq("")
expect(total_result.author_id_log).to eq("")
author_A = create(:poll_officer).user
author_B = create(:poll_officer).user
author_C = create(:poll_officer).user
total_result.amount = 33
total_result.author_id = author_A.id
total_result.save!
total_result.amount = 32
total_result.author_id = author_B.id
total_result.save!
total_result.amount = 34
total_result.author_id = author_C.id
total_result.save!
expect(total_result.amount_log).to eq(":33:32")
expect(total_result.author_id_log).to eq(":#{author_A.id}:#{author_B.id}")
end
end
end

70
spec/models/poll/white_result_spec.rb
View File

@@ -1,70 +0,0 @@
require 'rails_helper'
describe Poll::WhiteResult do
describe "logging changes" do
it "should update amount_log if amount changes" do
white_result = create(:poll_white_result, amount: 33)
expect(white_result.amount_log).to eq("")
white_result.amount = 33
white_result.save
white_result.amount = 32
white_result.save
white_result.amount = 34
white_result.save
expect(white_result.amount_log).to eq(":33:32")
end
it "should update officer_assignment_id_log if amount changes" do
white_result = create(:poll_white_result, amount: 33)
expect(white_result.amount_log).to eq("")
expect(white_result.officer_assignment_id_log).to eq("")
white_result.amount = 33
white_result.officer_assignment = create(:poll_officer_assignment, id: 21)
white_result.save
white_result.amount = 32
white_result.officer_assignment = create(:poll_officer_assignment, id: 22)
white_result.save
white_result.amount = 34
white_result.officer_assignment = create(:poll_officer_assignment, id: 23)
white_result.save
expect(white_result.amount_log).to eq(":33:32")
expect(white_result.officer_assignment_id_log).to eq(":21:22")
end
it "should update author_id if amount changes" do
white_result = create(:poll_white_result, amount: 33)
expect(white_result.amount_log).to eq("")
expect(white_result.author_id_log).to eq("")
author_A = create(:poll_officer).user
author_B = create(:poll_officer).user
author_C = create(:poll_officer).user
white_result.amount = 33
white_result.author_id = author_A.id
white_result.save!
white_result.amount = 32
white_result.author_id = author_B.id
white_result.save!
white_result.amount = 34
white_result.author_id = author_C.id
white_result.save!
expect(white_result.amount_log).to eq(":33:32")
expect(white_result.author_id_log).to eq(":#{author_A.id}:#{author_B.id}")
end
end
end