consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Feature flag spending proposals

Browse Source
This commit is contained in:
Josep Jaume Rey Peroy
2016-01-18 12:04:24 +01:00
parent 2d45828cad
commit 57f5296e49
5 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/admin/spending_proposals_controller.rb
View File

@@ -1,8 +1,12 @@
class Admin::SpendingProposalsController < Admin::BaseController class Admin::SpendingProposalsController < Admin::BaseController
include FeatureFlags
has_filters %w{unresolved accepted rejected}, only: :index has_filters %w{unresolved accepted rejected}, only: :index
load_and_authorize_resource load_and_authorize_resource
feature_flag :spending_proposals
def index def index
@spending_proposals = @spending_proposals.includes([:geozone]).send(@current_filter).order(created_at: :desc).page(params[:page]) @spending_proposals = @spending_proposals.includes([:geozone]).send(@current_filter).order(created_at: :desc).page(params[:page])
end end

4
app/controllers/spending_proposals_controller.rb
View File

@@ -1,8 +1,12 @@
class SpendingProposalsController < ApplicationController class SpendingProposalsController < ApplicationController
include FeatureFlags
before_action :authenticate_user!, except: [:index] before_action :authenticate_user!, except: [:index]
load_and_authorize_resource load_and_authorize_resource
feature_flag :spending_proposals
def index def index
end end

2
app/views/layouts/_header.html.erb
View File

@@ -39,7 +39,9 @@
<%= link_to t("layouts.header.debates"), debates_path, class: ("active" if controller_name == "debates") %> <%= link_to t("layouts.header.debates"), debates_path, class: ("active" if controller_name == "debates") %>
<% end %> <% end %>
<%= link_to t("layouts.header.proposals"), proposals_path, class: ("active" if controller_name == "proposals") %> <%= link_to t("layouts.header.proposals"), proposals_path, class: ("active" if controller_name == "proposals") %>
<% if feature?(:spending_proposals) %>
<%= link_to t("layouts.header.spending_proposals"), spending_proposals_path, class: ("active" if controller_name == "spending_proposals") %> <%= link_to t("layouts.header.spending_proposals"), spending_proposals_path, class: ("active" if controller_name == "spending_proposals") %>
<% end %>
<%= link_to t("layouts.header.more_information"), page_path('more_information'), class: ("active" if current_page?("/more_information")) %> <%= link_to t("layouts.header.more_information"), page_path('more_information'), class: ("active" if current_page?("/more_information")) %>
<% if Setting['blog_url'] %> <% if Setting['blog_url'] %>
<%= link_to Setting['blog_url'], target: "_blank" do %> <%= link_to Setting['blog_url'], target: "_blank" do %>

1
db/seeds.rb
View File

@@ -52,3 +52,4 @@ Setting["place_name"] = "Consul-land"
# Feature flags # Feature flags
Setting['feature.debates'] = true Setting['feature.debates'] = true
Setting['feature.spending_proposals'] = true

5
spec/features/admin/spending_proposals_spec.rb
View File

@@ -7,6 +7,11 @@ feature 'Admin spending proposals' do
login_as(admin.user) login_as(admin.user)
end end
scenario 'Disabled with a feature flag' do
Setting['feature.spending_proposals'] = nil
expect{ visit admin_spending_proposals_path }.to raise_exception(FeatureFlags::FeatureDisabled)
end
scenario 'Index shows spending proposals' do scenario 'Index shows spending proposals' do
spending_proposal = create(:spending_proposal) spending_proposal = create(:spending_proposal)
visit admin_spending_proposals_path visit admin_spending_proposals_path