Add and apply Layout/ExtraSpacing rubocop rule

.rubocop_basic.yml

@@ -52,6 +52,9 @@ Layout/EmptyLinesAroundMethodBody:
 Layout/EmptyLinesAroundModuleBody:
   Enabled: true
 
+Layout/ExtraSpacing:
+  Enabled: true
+
 Layout/SpaceAroundEqualsInParameterDefault:
   Enabled: true
 

app/models/ahoy/data_source.rb

@@ -8,7 +8,7 @@ module Ahoy
     # Name is the name of the collection and will be showed in the
     # chart
     def add(name, collection)
-      collections.push data:  collection, name: name
+      collections.push data: collection, name: name
       collection.each_key { |key| add_key key }
     end
 

app/models/budget/investment.rb

@@ -154,7 +154,7 @@ class Budget
       results = results.search_by_title_or_id(params[:title_or_id].strip)  if params[:title_or_id]
       results = advanced_filters(params, results)                          if params[:advanced_filters].present?
 
-      results = results.send(current_filter)                        if current_filter.present?
+      results = results.send(current_filter) if current_filter.present?
       results.includes(:heading, :group, :budget, administrator: :user, valuators: :user)
     end
 

app/models/budget/investment/change_log.rb

@@ -5,5 +5,5 @@ class Budget::Investment::ChangeLog < ApplicationRecord
   validates :new_value, presence: true
   validates :field, presence: true
 
-  scope :by_investment,     ->(investment_id) { where(investment_id: investment_id) }
+  scope :by_investment, ->(investment_id) { where(investment_id: investment_id) }
 end

app/models/local_census_record.rb

@@ -7,7 +7,7 @@ class LocalCensusRecord < ApplicationRecord
   validates :postal_code, presence: true
   validates :document_number, uniqueness: { scope: :document_type }
 
-  scope :search,  -> (terms) { where("document_number ILIKE ?", "%#{terms}%") }
+  scope :search, -> (terms) { where("document_number ILIKE ?", "%#{terms}%") }
 
   private
 

app/models/poll.rb

@@ -46,7 +46,7 @@ class Poll < ApplicationRecord
   scope :published, -> { where("published = ?", true) }
   scope :by_geozone_id, ->(geozone_id) { where(geozones: { id: geozone_id }.joins(:geozones)) }
   scope :public_for_api, -> { all }
-  scope :not_budget,    -> { where(budget_id: nil) }
+  scope :not_budget, -> { where(budget_id: nil) }
   scope :created_by_admin, -> { where(related_type: nil) }
 
   def self.sort_for_list

app/models/proposal_notification.rb

@@ -10,9 +10,9 @@ class ProposalNotification < ApplicationRecord
   validates :proposal, presence: true
   validate :minimum_interval
 
-  scope :public_for_api,           -> { where(proposal_id: Proposal.public_for_api.pluck(:id)) }
+  scope :public_for_api,     -> { where(proposal_id: Proposal.public_for_api.pluck(:id)) }
-  scope :sort_by_created_at,       -> { reorder(created_at: :desc) }
+  scope :sort_by_created_at, -> { reorder(created_at: :desc) }
-  scope :sort_by_moderated,       -> { reorder(moderated: :desc) }
+  scope :sort_by_moderated,  -> { reorder(moderated: :desc) }
 
   scope :moderated, -> { where(moderated: true) }
   scope :not_moderated, -> { where(moderated: false) }

app/models/site_customization/page.rb

@@ -18,7 +18,7 @@ class SiteCustomization::Page < ApplicationRecord
   scope :sort_desc, -> { order("id DESC") }
   scope :with_more_info_flag, -> { where(status: "published", more_info_flag: true).sort_asc }
   scope :with_same_locale, -> { joins(:translations).locale }
-  scope :locale, ->  { where("site_customization_page_translations.locale": I18n.locale) }
+  scope :locale, -> { where("site_customization_page_translations.locale": I18n.locale) }
 
   def url
     "/#{slug}"

app/models/votation_set_answer.rb

@@ -1,6 +1,6 @@
 class VotationSetAnswer < ApplicationRecord
   belongs_to :votation_type
-  belongs_to :author, ->   { with_hidden }, class_name: "User", foreign_key: "author_id"
+  belongs_to :author, -> { with_hidden }, class_name: "User", foreign_key: "author_id"
 
   scope :by_author, -> (author) { where(author: author) }
 end

spec/factories/budgets.rb

@@ -98,7 +98,7 @@ FactoryBot.define do
     unfeasibility_explanation { "" }
     skip_map             { "1" }
     terms_of_service     { "1" }
-    incompatible          { false }
+    incompatible         { false }
 
     trait :with_confidence_score do
       before(:save) { |i| i.calculate_confidence_score }

spec/features/admin/download_settings_spec.rb

@@ -247,7 +247,7 @@ describe "Admin download settings" do
   end
 
   context "Download budgets" do
-    let(:budget_finished)  { create(:budget, :finished) }
+    let(:budget_finished) { create(:budget, :finished) }
     let(:heading) { create(:budget_heading, budget: budget_finished, price: 1000) }
 
     let(:investment1) do

spec/features/admin/poll/polls_spec.rb

@@ -145,7 +145,7 @@ describe "Admin polls" do
       expect(Poll::Question::Answer.count). to eq(0)
     end
 
-    scenario "Can't destroy poll with votes", :js  do
+    scenario "Can't destroy poll with votes", :js do
       poll = create(:poll)
       create(:poll_question, poll: poll)
       create(:poll_voter, :from_booth, :valid_document, poll: poll)

spec/features/budgets/groups_spec.rb

@@ -2,7 +2,7 @@ require "rails_helper"
 
 describe "Budget Groups" do
   let(:budget) { create(:budget, slug: "budget_slug") }
-  let!(:group)  { create(:budget_group, slug: "group_slug", budget: budget) }
+  let!(:group) { create(:budget_group, slug: "group_slug", budget: budget) }
 
   context "Load" do
     scenario "finds group using budget slug and group slug" do

spec/features/budgets/investments_spec.rb

@@ -1899,7 +1899,7 @@ describe "Budget Investments" do
     end
 
     scenario "Display only investment's related to the current heading", :js do
-      heading_2 = create(:budget_heading, name: "Madrid",   group: group)
+      heading_2 = create(:budget_heading, name: "Madrid", group: group)
 
       investment1 = create(:budget_investment, heading: heading)
       investment2 = create(:budget_investment, heading: heading)
@@ -1923,7 +1923,7 @@ describe "Budget Investments" do
     end
 
     scenario "Do not display investment's, since they're all related to other heading", :js do
-      heading_2 = create(:budget_heading, name: "Madrid",   group: group)
+      heading_2 = create(:budget_heading, name: "Madrid", group: group)
 
       investment1 = create(:budget_investment, heading: heading_2)
       investment2 = create(:budget_investment, heading: heading_2)

spec/features/dashboard/polls_spec.rb

@@ -164,7 +164,7 @@ describe "Polls" do
     expect(page).not_to have_content(poll.name)
   end
 
-  scenario "Can't destroy poll with responses", :js  do
+  scenario "Can't destroy poll with responses", :js do
     poll = create(:poll, related: proposal)
     create(:poll_question, poll: poll)
     create(:poll_voter, poll: poll)

spec/i18n_spec.rb

@@ -60,7 +60,7 @@ describe "I18n" do
     end
 
     it "returns a String to avoid exception 'undefined method for Fixnum'" do
-      keys = { zero:  "No comments" }
+      keys = { zero: "No comments" }
       I18n.backend.store_translations(:en, { test_plural: keys })
 
       result = I18n.t("test_plural", count: 1)
@@ -69,7 +69,7 @@ describe "I18n" do
     end
 
     it "returns the number not pluralized for missing translations" do
-      keys = { zero:  "No comments" }
+      keys = { zero: "No comments" }
       I18n.backend.store_translations(:en, { test_plural: keys })
 
       expect(I18n.t("test_plural", count: 1).pluralize).to eq "1"

spec/models/abilities/administrator_spec.rb

@@ -74,7 +74,7 @@ describe Abilities::Administrator do
   it { should be_able_to(:create, Budget::ValuatorAssignment) }
 
   it { should be_able_to(:admin_update, Budget::Investment) }
-  it { should be_able_to(:hide,   Budget::Investment) }
+  it { should be_able_to(:hide, Budget::Investment) }
 
   it { should be_able_to(:valuate, create(:budget_investment, budget: create(:budget, :valuating))) }
   it { should be_able_to(:valuate, create(:budget_investment, budget: create(:budget, :finished))) }

spec/models/abilities/common_spec.rb

@@ -32,7 +32,7 @@ describe Abilities::Common do
   let(:ballot_in_selecting_budget) { create(:budget_ballot, budget: selecting_budget) }
   let(:ballot_in_balloting_budget) { create(:budget_ballot, budget: balloting_budget) }
 
-  let(:current_poll)  { create(:poll) }
+  let(:current_poll) { create(:poll) }
   let(:expired_poll) { create(:poll, :expired) }
   let(:expired_poll_from_own_geozone) { create(:poll, :expired, geozone_restricted: true, geozones: [geozone]) }
   let(:expired_poll_from_other_geozone) { create(:poll, :expired, geozone_restricted: true, geozones: [create(:geozone)]) }

spec/models/budget/investment_spec.rb

@@ -1206,7 +1206,7 @@ describe Budget::Investment do
   end
 
   describe "scoped_filter" do
-    let(:budget)   { create(:budget, :balloting)   }
+    let(:budget)     { create(:budget, :balloting) }
     let(:investment) { create(:budget_investment, budget: budget) }
 
     describe "with without_admin filter" do

spec/models/proposal_spec.rb

@@ -858,7 +858,7 @@ describe Proposal do
 
   describe "selected" do
     let!(:not_selected_proposal) { create(:proposal) }
-    let!(:selected_proposal)   { create(:proposal, :selected) }
+    let!(:selected_proposal)     { create(:proposal, :selected) }
 
     it "selected? is true" do
       expect(not_selected_proposal.selected?).to be false
@@ -916,7 +916,7 @@ describe Proposal do
   end
 
   describe "#recommendations" do
-    let(:user)     { create(:user) }
+    let(:user) { create(:user) }
 
     it "does not return any proposals when user has not interests" do
       create(:proposal)

spec/shared/features/nested_documentable.rb

@@ -11,7 +11,7 @@ shared_examples "nested documentable" do |login_as_name, documentable_factory_na
   else
     let!(:documentable)           { create(documentable_factory_name, author: user) }
   end
-  let!(:user_to_login)          { send(login_as_name) }
+  let!(:user_to_login) { send(login_as_name) }
 
   before do
     create(:administrator, user: administrator)

spec/shared/models/sanitizable.rb

@@ -1,5 +1,5 @@
 shared_examples "sanitizable" do
-  let(:sanitizable)        { build(model_name(described_class)) }
+  let(:sanitizable) { build(model_name(described_class)) }
 
   describe "#tag_list" do
     before do