consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't use comment_flags to cache comments

Browse Source 
Flagging a comment automatically updates the comment, so the cache
expires anyway, making the `comment_flags` variable redundant.
This commit is contained in:
Javi Martín
2020-05-10 02:34:20 +02:00
parent fbaa5c2388
commit 573f861ad1
11 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/views/comments/_comment.html.erb
View File

@@ -1,10 +1,9 @@
<% comment_flags ||= @comment_flags %>
<% valuation = local_assigns.fetch(:valuation, false) %>
<% allow_votes = local_assigns.fetch(:allow_votes, true) %>
<% allow_actions = local_assigns.fetch(:allow_actions, true) %>
<% allow_comments = local_assigns.fetch(:allow_comments, true) %>
<% admin_layout = local_assigns.fetch(:admin_layout, false) %>
<% cache [locale_and_user_status(comment), comment, commentable_cache_key(comment.commentable), comment.author, (comment_flags[comment.id] if comment_flags), (admin_layout if admin_layout)] do %>
<% cache [locale_and_user_status(comment), comment, commentable_cache_key(comment.commentable), comment.author, (admin_layout if admin_layout)] do %>
<ul id="<%= dom_id(comment) %>" class="comment no-bullet small-12">
<li class="comment-body">
<% if comment.hidden? || comment.user.hidden? %>