From 573e04ef8f3a7d00fc1a02c400135db14172b700 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Fri, 4 Jan 2019 19:17:33 +0100
Subject: [PATCH] Move common stats to partials

---
 app/views/polls/stats.html.erb                | 76 +------------------
 app/views/shared/stats/_links.html.erb        | 12 +++
 .../shared/stats/_participation.html.erb      | 62 +++++++++++++++
 3 files changed, 76 insertions(+), 74 deletions(-)
 create mode 100644 app/views/shared/stats/_links.html.erb
 create mode 100644 app/views/shared/stats/_participation.html.erb

diff --git a/app/views/polls/stats.html.erb b/app/views/polls/stats.html.erb
index 54ad19a59..e09780af0 100644
--- a/app/views/polls/stats.html.erb
+++ b/app/views/polls/stats.html.erb
@@ -11,85 +11,13 @@
         <div class="sticky" data-sticky
                             data-sticky-on="large"
                             data-anchor="participation_statistics">
-          <p><strong><%= link_to t("stats.title"), "#participation_statistics" %></strong></p>
-          <ul class="menu vertical">
-            <li>
-              <%= link_to t("stats.total_participants"), "#total_participants" %>
-            </li>
-            <li>
-              <%= link_to t("stats.by_gender"), "#participants_by_gender" %>
-            </li>
-            <li>
-              <%= link_to t("stats.by_age"), "#participants_by_age" %>
-            </li>
-          </ul>
+          <%= render "shared/stats/links" %>
         </div>
       </div>
     </div>
 
     <div class="small-12 medium-9 column" data-equalizer-watch>
-      <div id="participation_statistics">
-        <h3 class="section-title"><%= t("stats.title") %></h3>
-
-        <div id="total_participants" class="stats-group" >
-          <h4><%= t("stats.total_participants") %></h4>
-
-          <p class="participants">
-            <span class="number"><%= @stats[:total_participants] %></span>
-            <span class="info"><%= t("polls.show.stats.total_votes") %></span>
-          </p>
-        </div>
-
-        <div id="participants_by_gender" class="stats-group">
-          <h4><%= t("stats.by_gender") %></h4>
-
-          <p class="gender male participants">
-            <span class="number"><%= @stats[:total_male_participants] %></span>
-            <span class="info">
-              <%= I18n.t("stats.men_percentage",
-                         percentage: number_to_stats_percentage(@stats[:male_percentage])) %>
-            </span>
-          </p>
-
-          <p class="gender female participants">
-            <span class="number"><%= @stats[:total_female_participants] %></span>
-            <span class="info">
-              <%= I18n.t("stats.women_percentage",
-                         percentage: number_to_stats_percentage(@stats[:female_percentage])) %>
-            </span>
-          </p>
-        </div>
-
-        <div id="participants_by_age" class="stats-group">
-          <h4><%= t("stats.by_age") %></h4>
-
-          <table>
-            <thead>
-              <tr>
-                <th class="small-4"><%= t("stats.age") %></th>
-                <th><%= t("stats.total") %></th>
-              </tr>
-            </thead>
-
-            <tbody>
-              <% @stats[:age_groups].values.each do |group| %>
-                <tr>
-                  <td><%= group[:range] %></td>
-                  <td>
-                    <strong>
-                      <%= "#{group[:count]} (#{number_to_stats_percentage(group[:percentage])})" %>
-                    </strong>
-                    <div class="progress" tabindex="0">
-                      <span class="progress-meter" style="width: <%= group[:percentage] %>%">
-                      </span>
-                    </div>
-                  </td>
-                </tr>
-              <% end %>
-            </tbody>
-          </table>
-        </div>
-      </div>
+      <%= render "shared/stats/participation", stats: @stats %>
 
       <table>
         <thead>
diff --git a/app/views/shared/stats/_links.html.erb b/app/views/shared/stats/_links.html.erb
new file mode 100644
index 000000000..7b7d6d7ac
--- /dev/null
+++ b/app/views/shared/stats/_links.html.erb
@@ -0,0 +1,12 @@
+<p><strong><%= link_to t("stats.title"), "#participation_statistics" %></strong></p>
+<ul class="menu vertical">
+  <li>
+    <%= link_to t("stats.total_participants"), "#total_participants" %>
+  </li>
+  <li>
+    <%= link_to t("stats.by_gender"), "#participants_by_gender" %>
+  </li>
+  <li>
+    <%= link_to t("stats.by_age"), "#participants_by_age" %>
+  </li>
+</ul>
diff --git a/app/views/shared/stats/_participation.html.erb b/app/views/shared/stats/_participation.html.erb
new file mode 100644
index 000000000..cf31920db
--- /dev/null
+++ b/app/views/shared/stats/_participation.html.erb
@@ -0,0 +1,62 @@
+<div id="participation_statistics">
+  <h3 class="section-title"><%= t("stats.title") %></h3>
+
+  <div id="total_participants" class="stats-group">
+    <h4><%= t("stats.total_participants") %></h4>
+
+    <p class="participants">
+      <span class="number"><%= stats[:total_participants] %></span>
+      <span class="info"><%= t("polls.show.stats.total_votes") %></span>
+    </p>
+  </div>
+
+  <div id="participants_by_gender" class="stats-group">
+    <h4><%= t("stats.by_gender") %></h4>
+
+    <p class="gender male participants">
+      <span class="number"><%= stats[:total_male_participants] %></span>
+      <span class="info">
+        <%= I18n.t("stats.men_percentage",
+                   percentage: number_to_stats_percentage(stats[:male_percentage])) %>
+      </span>
+    </p>
+
+    <p class="gender female participants">
+      <span class="number"><%= stats[:total_female_participants] %></span>
+      <span class="info">
+        <%= I18n.t("stats.women_percentage",
+                   percentage: number_to_stats_percentage(stats[:female_percentage])) %>
+      </span>
+    </p>
+  </div>
+
+  <div id="participants_by_age" class="stats-group">
+    <h4><%= t("stats.by_age") %></h4>
+
+    <table>
+      <thead>
+        <tr>
+          <th class="small-4"><%= t("stats.age") %></th>
+          <th><%= t("stats.total") %></th>
+        </tr>
+      </thead>
+
+      <tbody>
+        <% stats[:age_groups].values.each do |group| %>
+          <tr>
+            <td><%= group[:range] %></td>
+            <td>
+              <strong>
+                <%= "#{group[:count]} (#{number_to_stats_percentage(group[:percentage])})" %>
+              </strong>
+              <div class="progress" tabindex="0">
+                <span class="progress-meter" style="width: <%= group[:percentage] %>%">
+                </span>
+              </div>
+            </td>
+          </tr>
+        <% end %>
+      </tbody>
+    </table>
+  </div>
+</div>