From 54fbdf4372b7e866c7d432edf39c387aef12b7ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 9 Feb 2023 19:05:11 +0100 Subject: [PATCH] Remove unnecessary condition in valuation investments The budget is loaded using a method which raises an exception if it isn't found, so `@budget.present?` will always return true. --- app/controllers/valuation/budget_investments_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/valuation/budget_investments_controller.rb b/app/controllers/valuation/budget_investments_controller.rb index 6ebb4dd94..4fcc990f1 100644 --- a/app/controllers/valuation/budget_investments_controller.rb +++ b/app/controllers/valuation/budget_investments_controller.rb @@ -16,7 +16,7 @@ class Valuation::BudgetInvestmentsController < Valuation::BaseController def index @heading_filters = heading_filters - @investments = if current_user.valuator? && @budget.present? + @investments = if current_user.valuator? @budget.investments.visible_to_valuator(current_user.valuator) .scoped_filter(params.permit(:budget_id, :heading_id), @current_filter) .order(cached_votes_up: :desc)