From 4fc4afa3a701457db9430311fb5c05e912dcc22f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 29 Aug 2023 18:53:40 +0200 Subject: [PATCH] Add RSpec/ExcessiveDocstringSpacing rubocop rule This rule was added in rubocop-rspec 2.5.0. --- .rubocop.yml | 3 +++ spec/controllers/users/confirmations_controller_spec.rb | 4 ++-- spec/lib/score_calculator_spec.rb | 2 +- spec/models/debate_spec.rb | 8 ++++---- spec/support/verifiable.rb | 2 +- spec/system/admin/emails/emails_download_spec.rb | 2 +- spec/system/admin/organizations_spec.rb | 2 +- 7 files changed, 13 insertions(+), 10 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index fb180b4c0..05efb4830 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -505,6 +505,9 @@ RSpec/EmptyLineAfterExampleGroup: RSpec/ExampleWording: Enabled: true +RSpec/ExcessiveDocstringSpacing: + Enabled: true + RSpec/FactoryBot/FactoryClassName: Enabled: true diff --git a/spec/controllers/users/confirmations_controller_spec.rb b/spec/controllers/users/confirmations_controller_spec.rb index d28188aa3..e9cb9acc3 100644 --- a/spec/controllers/users/confirmations_controller_spec.rb +++ b/spec/controllers/users/confirmations_controller_spec.rb @@ -10,7 +10,7 @@ describe Users::ConfirmationsController do expect { get :show, params: { token: "non_existent" } }.to raise_error ActiveRecord::RecordNotFound end - it "returns a 422 code with a existent and used token " do + it "returns a 422 code with a existent and used token" do user = create(:user, confirmation_token: "token1") get :show, params: { user: user, confirmation_token: "token1" } @@ -18,7 +18,7 @@ describe Users::ConfirmationsController do expect(response).to have_http_status(:unprocessable_entity) end - it "redirect to sign_in page with a existent and not used token " do + it "redirect to sign_in page with a existent and not used token" do user = create(:user, confirmation_token: "token1", confirmed_at: "") get :show, params: { user: user, confirmation_token: "token1" } diff --git a/spec/lib/score_calculator_spec.rb b/spec/lib/score_calculator_spec.rb index ef528082f..a1305cef5 100644 --- a/spec/lib/score_calculator_spec.rb +++ b/spec/lib/score_calculator_spec.rb @@ -14,7 +14,7 @@ describe ScoreCalculator do expect(ScoreCalculator.hot_score(resource)).to eq 1 end - it "ignores setting with negative value " do + it "ignores setting with negative value" do Setting["hot_score_period_in_days"] = -1 expect(ScoreCalculator.hot_score(resource)).to eq 1 diff --git a/spec/models/debate_spec.rb b/spec/models/debate_spec.rb index 0f086cc05..44fba2ec7 100644 --- a/spec/models/debate_spec.rb +++ b/spec/models/debate_spec.rb @@ -170,7 +170,7 @@ describe Debate do expect { debate.register_vote(user, "yes") }.to change { debate.reload.votes_for.size }.by(1) end - it "does not increase anonymous votes counter " do + it "does not increase anonymous votes counter" do user = create(:user, residence_verified_at: Time.current, confirmed_phone: "666333111") expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.total_anonymous_votes } end @@ -182,7 +182,7 @@ describe Debate do expect { debate.register_vote(user, "yes") }.to change { debate.reload.votes_for.size }.by(1) end - it "does not increase anonymous votes counter " do + it "does not increase anonymous votes counter" do user = create(:user, verified_at: Time.current) expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.total_anonymous_votes } end @@ -205,12 +205,12 @@ describe Debate do describe "from anonymous users when there are too many anonymous votes" do before { debate.update(cached_anonymous_votes_total: 520, cached_votes_total: 1000) } - it "does not register vote " do + it "does not register vote" do user = create(:user) expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.votes_for.size } end - it "does not increase anonymous votes counter " do + it "does not increase anonymous votes counter" do user = create(:user) expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.total_anonymous_votes } end diff --git a/spec/support/verifiable.rb b/spec/support/verifiable.rb index f8ffb97ea..cf34c14fe 100644 --- a/spec/support/verifiable.rb +++ b/spec/support/verifiable.rb @@ -217,7 +217,7 @@ shared_examples_for "verifiable" do end describe "#verification_sms_sent?" do - it "is true if skipped" do + it "is true if skipped" do user.update!(unconfirmed_phone: nil, sms_confirmation_code: "666") expect(user.verification_sms_sent?).to eq(true) diff --git a/spec/system/admin/emails/emails_download_spec.rb b/spec/system/admin/emails/emails_download_spec.rb index cabfcf5c3..7de835565 100644 --- a/spec/system/admin/emails/emails_download_spec.rb +++ b/spec/system/admin/emails/emails_download_spec.rb @@ -8,7 +8,7 @@ describe "Admin download user emails" do login_as(admin_user) end - context "Download only emails from segment users with newsletter flag & present email " do + context "Download only emails from segment users with newsletter flag & present email" do before do create(:user, email: "user@consul.dev") diff --git a/spec/system/admin/organizations_spec.rb b/spec/system/admin/organizations_spec.rb index e5818bf2d..6020ccd5a 100644 --- a/spec/system/admin/organizations_spec.rb +++ b/spec/system/admin/organizations_spec.rb @@ -205,7 +205,7 @@ describe "Admin::Organizations" do expect(page).not_to have_content("Verified Organization") end - scenario "Verifying organization links remembers parameters " do + scenario "Verifying organization links remembers parameters" do allow(Organization).to receive(:default_per_page).and_return(2) 4.times { create(:organization) }