Merge pull request #3057 from consul/backport-make-milestones-polymorphic

[Backport] Make milestones polymorphic

spec/lib/tasks/communities_spec.rb

@@ -1,15 +1,9 @@
 require 'rails_helper'
-require 'rake'
 
 describe 'Communities Rake' do
 
   describe '#associate_community' do
 
-    before do
-      Rake.application.rake_require "tasks/communities"
-      Rake::Task.define_task(:environment)
-    end
-
     let :run_rake_task do
       Rake::Task['communities:associate_community'].reenable
       Rake.application.invoke_task 'communities:associate_community'

spec/lib/tasks/dev_seed_spec.rb

@@ -1,7 +1,4 @@
-require 'rake'
 require 'rails_helper'
-Rake::Task.define_task(:environment)
-Rake.application.rake_require('tasks/db')
 
 describe 'rake db:dev_seed' do
   let :run_rake_task do

spec/lib/tasks/globalize_spec.rb

@@ -1,15 +1,9 @@
 require "rails_helper"
-require "rake"
 
 describe "Globalize tasks" do
 
   describe "#migrate_data" do
 
-    before do
-      Rake.application.rake_require "tasks/globalize"
-      Rake::Task.define_task(:environment)
-    end
-
     let :run_rake_task do
       Rake::Task["globalize:migrate_data"].reenable
       Rake.application.invoke_task "globalize:migrate_data"
@@ -151,7 +145,7 @@ describe "Globalize tasks" do
       before { I18n.locale = :"pt-BR" }
 
       let!(:milestone) do
-        create(:budget_investment_milestone).tap do |milestone|
+        create(:milestone).tap do |milestone|
           milestone.translations.delete_all
           milestone.update_column(:title, "Português")
           milestone.reload

spec/lib/tasks/map_location_spec.rb

@@ -1,6 +1,4 @@
-require 'rake'
 require 'rails_helper'
-Rails.application.load_tasks
 
 describe 'rake map_locations:destroy' do
   before do

spec/lib/tasks/milestones_spec.rb

@@ -0,0 +1,147 @@
+require "rails_helper"
+
+describe "Milestones tasks" do
+  describe "#migrate" do
+    let :run_rake_task do
+      Rake::Task["milestones:migrate"].reenable
+      Rake.application.invoke_task "milestones:migrate"
+    end
+
+    let!(:investment) { create(:budget_investment) }
+
+    before do
+      ActiveRecord::Base.connection.execute(
+        "INSERT INTO budget_investment_statuses " +
+        "(name, description, hidden_at, created_at, updated_at) " +
+        "VALUES ('open', 'Good', NULL, '#{Time.current - 1.day}', '#{Time.current}');"
+      )
+
+      status_id = ActiveRecord::Base.connection.execute(
+        "SELECT MAX(id) FROM budget_investment_statuses;"
+      ).to_a.first["max"]
+
+      milestone_attributes = {
+        investment_id:     investment.id,
+        title:             "First",
+        description:       "Interesting",
+        publication_date:  Date.yesterday,
+        status_id:         status_id,
+        created_at:        Time.current - 1.day,
+        updated_at:        Time.current
+      }
+
+      ActiveRecord::Base.connection.execute(
+        "INSERT INTO budget_investment_milestones " +
+        "(#{milestone_attributes.keys.join(", ")}) " +
+        "VALUES (#{milestone_attributes.values.map { |value| "'#{value}'"}.join(", ")})"
+      )
+    end
+
+    it "migrates statuses" do
+      run_rake_task
+
+      expect(Milestone::Status.count).to be 1
+
+      status = Milestone::Status.first
+      expect(status.name).to eq "open"
+      expect(status.description).to eq "Good"
+      expect(status.hidden_at).to be nil
+      expect(status.created_at.to_date).to eq Date.yesterday
+      expect(status.updated_at.to_date).to eq Date.current
+    end
+
+    it "migrates milestones" do
+      run_rake_task
+
+      expect(Milestone.count).to be 1
+
+      milestone = Milestone.first
+      expect(milestone.milestoneable_id).to eq investment.id
+      expect(milestone.milestoneable_type).to eq "Budget::Investment"
+      expect(milestone.title).to eq "First"
+      expect(milestone.description).to eq "Interesting"
+      expect(milestone.publication_date).to eq Date.yesterday
+      expect(milestone.status_id).to eq Milestone::Status.first.id
+      expect(milestone.created_at.to_date).to eq Date.yesterday
+      expect(milestone.updated_at.to_date).to eq Date.current
+    end
+
+    it "Updates the primary key sequence correctly" do
+      run_rake_task
+      expect { create(:milestone) }.not_to raise_exception
+    end
+
+    context "Milestone has images and documents" do
+      let(:milestone_id) do
+        ActiveRecord::Base.connection.execute(
+          "SELECT MAX(id) FROM budget_investment_milestones;"
+        ).to_a.first["max"]
+      end
+
+      let!(:image) do
+        create(:image, imageable_id: milestone_id).tap do |image|
+          image.update_column(:imageable_type, "Budget::Investment::Milestone")
+        end
+      end
+
+      let!(:document) do
+        create(:document, documentable_id: milestone_id).tap do |document|
+          document.update_column(:documentable_type, "Budget::Investment::Milestone")
+        end
+      end
+
+      it "migrates images and documents" do
+        run_rake_task
+
+        expect(Milestone.last.image).to eq image
+        expect(Milestone.last.documents).to eq [document]
+      end
+    end
+
+    context "Statuses had been deleted" do
+      before do
+        ActiveRecord::Base.connection.execute(
+          "INSERT INTO budget_investment_statuses " +
+          "(name, description, hidden_at, created_at, updated_at) " +
+          "VALUES ('deleted', 'Del', NULL, '#{Time.current - 1.day}', '#{Time.current}');"
+        )
+
+        ActiveRecord::Base.connection.execute(
+          "DELETE FROM budget_investment_statuses WHERE name='deleted'"
+        )
+
+        ActiveRecord::Base.connection.execute(
+          "INSERT INTO budget_investment_statuses " +
+          "(name, description, hidden_at, created_at, updated_at) " +
+          "VALUES ('new', 'New', NULL, '#{Time.current - 1.day}', '#{Time.current}');"
+        )
+
+        status_id = ActiveRecord::Base.connection.execute(
+          "SELECT MAX(id) FROM budget_investment_statuses;"
+        ).to_a.first["max"]
+
+        milestone_attributes = {
+          investment_id:     investment.id,
+          title:             "Last",
+          description:       "Different",
+          publication_date:  Date.yesterday,
+          status_id:         status_id,
+          created_at:        Time.current - 1.day,
+          updated_at:        Time.current
+        }
+
+        ActiveRecord::Base.connection.execute(
+          "INSERT INTO budget_investment_milestones " +
+          "(#{milestone_attributes.keys.join(", ")}) " +
+          "VALUES (#{milestone_attributes.values.map { |value| "'#{value}'"}.join(", ")})"
+        )
+      end
+
+      it "migrates the status id correctly" do
+        run_rake_task
+
+        expect(Milestone.last.status_id).to eq Milestone::Status.last.id
+      end
+    end
+  end
+end

spec/lib/tasks/settings_spec.rb

@@ -1,15 +1,9 @@
 require 'rails_helper'
-require 'rake'
 
 describe 'Settings Rake' do
 
   describe '#per_page_code_migration' do
 
-    before do
-      Rake.application.rake_require "tasks/settings"
-      Rake::Task.define_task(:environment)
-    end
-
     let :run_rake_task do
       Rake::Task['settings:per_page_code_migration'].reenable
       Rake.application.invoke_task 'settings:per_page_code_migration'

spec/lib/tasks/sitemap_spec.rb

@@ -1,7 +1,4 @@
-require 'rake'
 require 'rails_helper'
-Rails.application.load_tasks
-Rake::Task.define_task(:environment)
 
 feature 'rake sitemap:create' do
   before do