consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify LEFT JOIN using ActiveRecord#left_joins

Browse Source 
This method is available since Rails 5.0.
This commit is contained in:
Javi Martín
2019-06-21 00:14:39 +02:00
parent d3fa00b1e6
commit 4e76f90afd
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/poll.rb
View File

@@ -99,8 +99,8 @@ class Poll < ApplicationRecord
def self.answerable_by(user) def self.answerable_by(user)
return none if user.nil? || user.unverified? return none if user.nil? || user.unverified?
current.joins('LEFT JOIN "geozones_polls" ON "geozones_polls"."poll_id" = "polls"."id"') current.left_joins(:geozones)
.where("geozone_restricted = ? OR geozones_polls.geozone_id = ?", false, user.geozone_id) .where("geozone_restricted = ? OR geozones.id = ?", false, user.geozone_id)
end end
def self.votable_by(user) def self.votable_by(user)