consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename User.by_authors to with_ids

Browse Source 
The "by_authors" scope was the last remaining name from the removed
family of `by_author` scopes. It no longer reflects its purpose: it
simply loads users by IDs.
This commit is contained in:
taitus
2025-11-14 11:46:11 +01:00
parent a9129158c1
commit 4e455578d1
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/community.rb
View File

@@ -49,8 +49,8 @@ class Community < ApplicationRecord
end end
def users_who_topics_author def users_who_topics_author
author_ids = topics.pluck(:author_id) ids = topics.pluck(:author_id)
User.by_authors(author_ids) User.with_ids(ids)
end end
def author_from_community def author_from_community

2
app/models/user.rb
View File

@@ -111,7 +111,7 @@ class User < ApplicationRecord
scope :erased, -> { where.not(erased_at: nil) } scope :erased, -> { where.not(erased_at: nil) }
scope :active, -> { excluding(erased) } scope :active, -> { excluding(erased) }
scope :public_for_api, -> { all } scope :public_for_api, -> { all }
scope :by_authors, ->(author_ids) { where(id: author_ids) } scope :with_ids, ->(ids) { where(id: ids) }
scope :by_comments, ->(commentables) do scope :by_comments, ->(commentables) do
joins(:comments).where("comments.commentable": commentables).distinct joins(:comments).where("comments.commentable": commentables).distinct
end end