From 4c0deb0eca89a95bc4cd79f07785b24d5ce962f9 Mon Sep 17 00:00:00 2001 From: Angel Perez Date: Fri, 18 May 2018 09:43:43 -0400 Subject: [PATCH] Remove `video_url` attr from Admin::Poll::Question form --- app/controllers/admin/poll/questions_controller.rb | 2 +- app/views/admin/poll/questions/_form.html.erb | 13 ------------- spec/features/admin/poll/questions_spec.rb | 3 --- 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/app/controllers/admin/poll/questions_controller.rb b/app/controllers/admin/poll/questions_controller.rb index 64ecf4009..399c72788 100644 --- a/app/controllers/admin/poll/questions_controller.rb +++ b/app/controllers/admin/poll/questions_controller.rb @@ -55,7 +55,7 @@ class Admin::Poll::QuestionsController < Admin::Poll::BaseController private def question_params - params.require(:poll_question).permit(:poll_id, :title, :question, :proposal_id, :video_url) + params.require(:poll_question).permit(:poll_id, :title, :question, :proposal_id) end def search_params diff --git a/app/views/admin/poll/questions/_form.html.erb b/app/views/admin/poll/questions/_form.html.erb index 17ebde59d..eeb38a405 100644 --- a/app/views/admin/poll/questions/_form.html.erb +++ b/app/views/admin/poll/questions/_form.html.erb @@ -14,19 +14,6 @@ <%= f.text_field :title %> -
- <%= f.label :video_url, t("proposals.form.proposal_video_url") %> - -

- <%= t("proposals.form.proposal_video_url_note") %> -

- - <%= f.text_field :video_url, - placeholder: t("proposals.form.proposal_video_url"), - label: false, - aria: {describedby: "video-url-help-text"} %> -
-
<%= f.submit(class: "button expanded", value: t("shared.save")) %>
diff --git a/spec/features/admin/poll/questions_spec.rb b/spec/features/admin/poll/questions_spec.rb index 4399e3e64..d499869b9 100644 --- a/spec/features/admin/poll/questions_spec.rb +++ b/spec/features/admin/poll/questions_spec.rb @@ -36,19 +36,16 @@ feature 'Admin poll questions' do Pursued by the Empire's sinister agents, Princess Leia races home aboard her starship, custodian of the stolen plans that can save her people and restore freedom to the galaxy.... } - video_url = "https://puppyvideos.com" visit admin_questions_path click_link "Create question" select 'Movies', from: 'poll_question_poll_id' fill_in 'poll_question_title', with: title - fill_in 'poll_question_video_url', with: video_url click_button 'Save' expect(page).to have_content(title) - expect(page).to have_content(video_url) end scenario 'Create from successful proposal index' do