From 49b4a0c71dbb30e1827f258b9aa18192e6246447 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 8 Jul 2019 01:05:48 +0200 Subject: [PATCH] Simplify banners JavaScript There were functions which were just simple wrappers to common jQuery functions. --- app/assets/javascripts/banners.js.coffee | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/app/assets/javascripts/banners.js.coffee b/app/assets/javascripts/banners.js.coffee index 50b6db3d5..7ebbaf540 100644 --- a/app/assets/javascripts/banners.js.coffee +++ b/app/assets/javascripts/banners.js.coffee @@ -1,28 +1,18 @@ App.Banners = - - update_banner: (selector, text) -> - $(selector).html(text) - - update_background_color: (selector, background_color) -> - $(selector).css("background-color", background_color) - - update_font_color: (selector, font_color) -> - $(selector).css("color", font_color) - initialize: -> $("[data-js-banner-title]").on change: -> - App.Banners.update_banner("#js-banner-title", $(this).val()) + $("#js-banner-title").html($(this).val()) $("[data-js-banner-description]").on change: -> - App.Banners.update_banner("#js-banner-description", $(this).val()) + $("#js-banner-description").html($(this).val()) $("[name='banner[background_color]']").on change: -> - App.Banners.update_background_color("#js-banner-background", $(this).val()) + $("#js-banner-background").css("background-color", $(this).val()) $("[name='banner[font_color]']").on change: -> - App.Banners.update_font_color("#js-banner-title", $(this).val()) - App.Banners.update_font_color("#js-banner-description", $(this).val()) + $("#js-banner-title").css("color", $(this).val()) + $("#js-banner-description").css("color", $(this).val())