Use truncate_all instead of DatabaseCleaner

Performance tests show both methods of truncating the database take
about the same time, so we can remove one dependency and we don't lose
anything in the process.
This commit is contained in:
Javi Martín
2021-09-19 22:18:11 +02:00
parent f8ec98c2a6
commit 480ab6a9da
4 changed files with 2 additions and 13 deletions

View File

@@ -72,7 +72,6 @@ end
group :development, :test do group :development, :test do
gem "bullet", "~> 6.1.4" gem "bullet", "~> 6.1.4"
gem "byebug", "~> 11.1.3" gem "byebug", "~> 11.1.3"
gem "database_cleaner", "~> 2.0.1"
gem "factory_bot_rails", "~> 6.2.0" gem "factory_bot_rails", "~> 6.2.0"
gem "faker", "~> 2.18.0" gem "faker", "~> 2.18.0"
gem "i18n-tasks", "~> 0.9.34" gem "i18n-tasks", "~> 0.9.34"

View File

@@ -168,12 +168,6 @@ GEM
crass (1.0.6) crass (1.0.6)
daemons (1.4.0) daemons (1.4.0)
dalli (2.7.11) dalli (2.7.11)
database_cleaner (2.0.1)
database_cleaner-active_record (~> 2.0.0)
database_cleaner-active_record (2.0.1)
activerecord (>= 5.a)
database_cleaner-core (~> 2.0.0)
database_cleaner-core (2.0.1)
delayed_job (4.1.9) delayed_job (4.1.9)
activesupport (>= 3.0, < 6.2) activesupport (>= 3.0, < 6.2)
delayed_job_active_record (4.1.6) delayed_job_active_record (4.1.6)
@@ -730,7 +724,6 @@ DEPENDENCIES
coveralls (~> 0.8.23) coveralls (~> 0.8.23)
daemons (~> 1.4.0) daemons (~> 1.4.0)
dalli (~> 2.7.11) dalli (~> 2.7.11)
database_cleaner (~> 2.0.1)
delayed_job_active_record (~> 4.1.6) delayed_job_active_record (~> 4.1.6)
devise (~> 4.8.0) devise (~> 4.8.0)
devise-security (~> 0.16.0) devise-security (~> 0.16.0)

View File

@@ -1,7 +1,4 @@
unless Rails.env.test? ActiveRecord::Tasks::DatabaseTasks.truncate_all unless Rails.env.test?
require "database_cleaner"
DatabaseCleaner.clean_with :truncation
end
@logger = Logger.new(STDOUT) @logger = Logger.new(STDOUT)
@logger.formatter = proc do |_severity, _datetime, _progname, msg| @logger.formatter = proc do |_severity, _datetime, _progname, msg|
msg unless @avoid_log msg unless @avoid_log

View File

@@ -45,7 +45,7 @@ RSpec.configure do |config|
example.run example.run
self.use_transactional_tests = true self.use_transactional_tests = true
DatabaseCleaner.clean_with(:truncation) ActiveRecord::Tasks::DatabaseTasks.truncate_all
Rails.application.load_seed Rails.application.load_seed
end end