From 457ec11e6d003b8ddf9d7cbbeec96a55b4afb1e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Tue, 2 Jul 2019 02:39:49 +0200
Subject: [PATCH] Remove unnecessary `return false` statements

The `initialize` functions don't need to return anything, since their
returned value is never used.

Returning false is a common practice in jQuery to stop an event, but in
plain JavaScript methods it doesn't have any side effects.
---
 app/assets/javascripts/allow_participation.js.coffee            | 1 -
 app/assets/javascripts/forms.js.coffee                          | 1 -
 app/assets/javascripts/prevent_double_submission.js.coffee      | 2 --
 app/assets/javascripts/users.js.coffee                          | 1 -
 .../javascripts/valuation_budget_investment_form.js.coffee      | 1 -
 app/assets/javascripts/votations.js.coffee                      | 2 --
 app/assets/javascripts/votes.js.coffee                          | 1 -
 app/assets/javascripts/watch_form_changes.js.coffee             | 2 --
 8 files changed, 11 deletions(-)

diff --git a/app/assets/javascripts/allow_participation.js.coffee b/app/assets/javascripts/allow_participation.js.coffee
index 9482826ca..0427ae730 100644
--- a/app/assets/javascripts/allow_participation.js.coffee
+++ b/app/assets/javascripts/allow_participation.js.coffee
@@ -9,4 +9,3 @@ App.AllowParticipation =
         $(this).find(".js-participation-not-allowed").hide()
         $(this).find(".js-participation-allowed").show()
     }, ".js-participation"
-    false
diff --git a/app/assets/javascripts/forms.js.coffee b/app/assets/javascripts/forms.js.coffee
index 5cf403e59..2ce43367c 100644
--- a/app/assets/javascripts/forms.js.coffee
+++ b/app/assets/javascripts/forms.js.coffee
@@ -58,4 +58,3 @@ App.Forms =
     App.Forms.toggleLink()
     App.Forms.synchronizeInputs()
     App.Forms.hideOrShowFieldsAfterSelection()
-    false
diff --git a/app/assets/javascripts/prevent_double_submission.js.coffee b/app/assets/javascripts/prevent_double_submission.js.coffee
index c47b40b70..eefb8a9fe 100644
--- a/app/assets/javascripts/prevent_double_submission.js.coffee
+++ b/app/assets/javascripts/prevent_double_submission.js.coffee
@@ -34,5 +34,3 @@ App.PreventDoubleSubmission =
         buttons = $(this).find(":button, :submit")
         App.PreventDoubleSubmission.reset_buttons(buttons)
     )
-
-    false
diff --git a/app/assets/javascripts/users.js.coffee b/app/assets/javascripts/users.js.coffee
index cae04abaf..29039de95 100644
--- a/app/assets/javascripts/users.js.coffee
+++ b/app/assets/javascripts/users.js.coffee
@@ -2,4 +2,3 @@ App.Users =
 
   initialize: ->
     $(".initialjs-avatar").initial()
-    false
diff --git a/app/assets/javascripts/valuation_budget_investment_form.js.coffee b/app/assets/javascripts/valuation_budget_investment_form.js.coffee
index 6e9910cb3..51fb1d156 100644
--- a/app/assets/javascripts/valuation_budget_investment_form.js.coffee
+++ b/app/assets/javascripts/valuation_budget_investment_form.js.coffee
@@ -29,4 +29,3 @@ App.ValuationBudgetInvestmentForm =
   initialize: ->
     App.ValuationBudgetInvestmentForm.showFeasibilityFields()
     App.ValuationBudgetInvestmentForm.showFeasibilityFieldsOnChange()
-    false
diff --git a/app/assets/javascripts/votations.js.coffee b/app/assets/javascripts/votations.js.coffee
index 80f026c10..48f3873fd 100644
--- a/app/assets/javascripts/votations.js.coffee
+++ b/app/assets/javascripts/votations.js.coffee
@@ -41,5 +41,3 @@ App.Votations =
         url = "/admin/get_options_traductions.json"
         params = { enum_type: $("#votation_type_enum_type").val() }
         $.get(url, params, (response) -> App.Votations.setTraduction response, "json")
-
-false
diff --git a/app/assets/javascripts/votes.js.coffee b/app/assets/javascripts/votes.js.coffee
index 003187bca..d0bed54ad 100644
--- a/app/assets/javascripts/votes.js.coffee
+++ b/app/assets/javascripts/votes.js.coffee
@@ -15,4 +15,3 @@ App.Votes =
     App.Votes.hoverize "div.supports"
     App.Votes.hoverize "div.debate-questions"
     App.Votes.hoverize "div.comment-footer"
-    false
diff --git a/app/assets/javascripts/watch_form_changes.js.coffee b/app/assets/javascripts/watch_form_changes.js.coffee
index 740876506..f2ee99569 100644
--- a/app/assets/javascripts/watch_form_changes.js.coffee
+++ b/app/assets/javascripts/watch_form_changes.js.coffee
@@ -26,5 +26,3 @@ App.WatchFormChanges =
     App.WatchFormChanges.forms().each ->
       form = $(this)
       form.data("watchChanges", form.serialize())
-
-    false