From 449f8102551be9910de9fa94f33637b5565d09fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Wed, 28 Nov 2018 16:18:54 +0100 Subject: [PATCH] Edit only existing languages in milestones summary Adding languages using this form would result in validation errors since there's no way to fill in the title for the new translation. --- app/views/admin/legislation/milestones/_summary_form.html.erb | 4 +++- spec/features/admin/legislation/processes_spec.rb | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/views/admin/legislation/milestones/_summary_form.html.erb b/app/views/admin/legislation/milestones/_summary_form.html.erb index 0adb00ecc..952926572 100644 --- a/app/views/admin/legislation/milestones/_summary_form.html.erb +++ b/app/views/admin/legislation/milestones/_summary_form.html.erb @@ -1,4 +1,6 @@ -<%= render "admin/shared/globalize_locales", resource: @process %> +<%= render "admin/shared/globalize_tabs", + resource: @process, + display_style: lambda { |locale| enable_translation_style(@process, locale) } %> <%= translatable_form_for [:admin, @process] do |f| %> <%= f.translatable_fields do |translations_form| %> diff --git a/spec/features/admin/legislation/processes_spec.rb b/spec/features/admin/legislation/processes_spec.rb index 0599c40ce..a0a869595 100644 --- a/spec/features/admin/legislation/processes_spec.rb +++ b/spec/features/admin/legislation/processes_spec.rb @@ -192,6 +192,9 @@ feature 'Admin legislation processes' do scenario "Edit milestones summary", :js do visit admin_legislation_process_milestones_path(process) + expect(page).not_to have_link "Remove language" + expect(page).not_to have_field "translation_locale" + within(".translatable-fields[data-locale='en']") do fill_in_ckeditor find("textarea", visible: false)[:id], with: "There is still a long journey ahead of us"