From 42c9645fb79066da1e573691f62d35e4c09cf90f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Wed, 16 Jun 2021 15:36:45 +0200
Subject: [PATCH] Improve label in dashboard actions link form

We were using a placeholder to indicate content which should be part of
a label.

It might be better to actually use "Link address" as a label instead of
"URL". I'm using "URL" because it's used in other places in the admin
section.
---
 app/views/links/_link_fields.html.erb | 3 +--
 config/locales/en/activerecord.yml    | 2 +-
 config/locales/en/general.yml         | 2 --
 config/locales/es/activerecord.yml    | 2 +-
 config/locales/es/general.yml         | 2 --
 5 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/app/views/links/_link_fields.html.erb b/app/views/links/_link_fields.html.erb
index eec22ac5f..498b5ca2b 100644
--- a/app/views/links/_link_fields.html.erb
+++ b/app/views/links/_link_fields.html.erb
@@ -1,8 +1,7 @@
 <div id="<%= dom_id(f.object) %>" class="nested-fields">
   <div class="small-12 column attachment-actions">
     <%= f.text_field :label %>
-
-    <%= f.text_field :url, placeholder: t("links.link_fields.url_placeholder") %>
+    <%= f.text_field :url %>
 
     <div class="action-remove text-right">
       <%= render_destroy_element_link(f, f.object) %>
diff --git a/config/locales/en/activerecord.yml b/config/locales/en/activerecord.yml
index 5b12917fd..c2057e07b 100644
--- a/config/locales/en/activerecord.yml
+++ b/config/locales/en/activerecord.yml
@@ -500,7 +500,7 @@ en:
         user: Executed by
       link:
         label: Title
-        url: Link
+        url: URL
       valuator:
         description: Description
         valuator_group_id: Valuator group
diff --git a/config/locales/en/general.yml b/config/locales/en/general.yml
index b7f73cbe4..47616b616 100644
--- a/config/locales/en/general.yml
+++ b/config/locales/en/general.yml
@@ -952,8 +952,6 @@ en:
       title: Links
       note: Add the links that are of interest
       add_new_link: Add new link
-    link_fields:
-      url_placeholder: Link address
   communities:
     show:
       surveys: Surveys
diff --git a/config/locales/es/activerecord.yml b/config/locales/es/activerecord.yml
index 43bd93700..a6454e6e3 100644
--- a/config/locales/es/activerecord.yml
+++ b/config/locales/es/activerecord.yml
@@ -500,7 +500,7 @@ es:
         user: Ejecutado por
       link:
         label: Título
-        url: Enlace
+        url: URL
       valuator:
         description: Descripción
         valuator_group_id: Grupo de evaluación
diff --git a/config/locales/es/general.yml b/config/locales/es/general.yml
index 76f09c03a..903e96d07 100644
--- a/config/locales/es/general.yml
+++ b/config/locales/es/general.yml
@@ -952,8 +952,6 @@ es:
       title: Enlaces
       note: Añade los enlaces que sean de interés.
       add_new_link: Añadir nuevo enlace
-    link_fields:
-      url_placeholder: Dirección del enlace
   communities:
     show:
       surveys: Encuestas