From ceed02eb9294aa91c02d04e7d9c921e209bc80e3 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 12 Aug 2021 23:40:08 +0000 Subject: [PATCH 1/2] Bump knapsack_pro from 2.11.0 to 3.0.0 Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby) from 2.11.0 to 3.0.0. - [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases) - [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md) - [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v2.11.0...v3.0.0) --- updated-dependencies: - dependency-name: knapsack_pro dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- Gemfile | 2 +- Gemfile.lock | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Gemfile b/Gemfile index ea85542f2..0fea7d4a2 100644 --- a/Gemfile +++ b/Gemfile @@ -76,7 +76,7 @@ group :development, :test do gem "factory_bot_rails", "~> 6.2.0" gem "faker", "~> 1.8.7" gem "i18n-tasks", "~> 0.9.34" - gem "knapsack_pro", "~> 2.11.0" + gem "knapsack_pro", "~> 3.0.0" gem "launchy", "~> 2.5.0" gem "letter_opener_web", "~> 1.4.0" gem "spring", "~> 2.1.1" diff --git a/Gemfile.lock b/Gemfile.lock index dbda517e7..43c5b46eb 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -349,7 +349,7 @@ GEM activerecord kaminari-core (= 1.2.1) kaminari-core (1.2.1) - knapsack_pro (2.11.0) + knapsack_pro (3.0.0) rake kramdown (2.3.1) rexml @@ -750,7 +750,7 @@ DEPENDENCIES jquery-rails (~> 4.4.0) jquery-ui-rails (~> 6.0.1) kaminari (~> 1.2.1) - knapsack_pro (~> 2.11.0) + knapsack_pro (~> 3.0.0) launchy (~> 2.5.0) letter_opener_web (~> 1.4.0) mdl (~> 0.11.0) From 28c7c5de660f33e83d06e74684106d0026e1ca34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 13 Aug 2021 01:48:53 +0200 Subject: [PATCH 2/2] Use `filter_run_when_matching` option in RSpec The `run_all_when_everything_filtered` is deprecated [1]. [1] https://knapsackpro.com/faq/question/how-to-split-slow-rspec-test-files-by-test-examples-by-individual-it#warning-dont-use-deprecated-rspec-run_all_when_everything_filtered-option --- spec/spec_helper.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 3af6ef138..732165bef 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -10,8 +10,7 @@ Dir["./spec/shared/**/*.rb"].sort.each { |f| require f } RSpec.configure do |config| config.use_transactional_fixtures = true - config.filter_run :focus - config.run_all_when_everything_filtered = true + config.filter_run_when_matching :focus config.include RequestSpecHelper, type: :request config.include Devise::Test::ControllerHelpers, type: :controller config.include Devise::Test::ControllerHelpers, type: :view