test added for changes at documentable's view

app/assets/javascripts/documentable.js.coffee

@@ -11,10 +11,9 @@ App.Documentable =
 
     $('#nested-documents').on 'cocoon:after-insert', (e, nested_document) ->
       input = $(nested_document).find('.js-document-attachment')
+      input["lockUpload"] = $(nested_document).closest('#nested-documents').find('.document:visible').length >= $('#nested-documents').data('max-documents-allowed')
       App.Documentable.initializeDirectUploadInput(input)
-
+      App.Documentable.lockUploads() if input["lockUpload"]
-      if $(nested_document).closest('#nested-documents').find('.document:visible').length >= $('#nested-documents').data('max-documents-allowed')
-        App.Documentable.lockUploads()
 
   initializeDirectUploadInput: (input) ->
 
@@ -65,6 +64,9 @@ App.Documentable =
           e.stopPropagation()
           App.Documentable.doDeleteCachedAttachmentRequest(this.href, data)
 
+        App.Documentable.showNotice() if input["lockUpload"]
+
+
       progress: (e, data) ->
         progress = parseInt(data.loaded / data.total * 100, 10)
         $(data.progressBar).find('.loading-bar').css 'width', progress + '%'
@@ -114,13 +116,15 @@ App.Documentable =
     $(data.errorContainer).append(errors)
 
   lockUploads: ->
-    $('#max-documents-notice').removeClass('hide')
     $('#new_document_link').addClass('hide')
 
   unlockUploads: ->
     $('#max-documents-notice').addClass('hide')
     $('#new_document_link').removeClass('hide')
 
+  showNotice: ->
+    $('#max-documents-notice').removeClass('hide')
+
   doDeleteCachedAttachmentRequest: (url, data) ->
     $.ajax
       type: "POST"

app/helpers/documents_helper.rb

@@ -27,7 +27,7 @@ module DocumentsHelper
                   remote: true,
                   class: "delete remove-cached-attachment"
     else
-      link_to_remove_association t('documents.form.delete_button'), builder, class: "delete remove-document"
+      link_to_remove_association document.new_record? ? t('documents.form.cancel_button') : t('documents.form.delete_button') , builder, class: "delete remove-document"
     end
   end
 

app/views/documents/_nested_documents.html.erb

@@ -17,7 +17,7 @@
                                 association_insertion_method: "append"
                               } %>
 
-  <div id="max-documents-notice" class="max-documents-notice callout warning text-center <%= "hide" unless max_documents_allowed?(documentable) %>">
+  <div id="max-documents-notice" class="max-documents-notice callout primary text-center <%= "hide" unless max_documents_allowed?(documentable) %>">
     <%= t "documents.max_documents_allowed_reached_html" %>
   </div>
 </div>

config/locales/en/documents.yml

@@ -8,6 +8,7 @@ en:
       title_placeholder: Add a descriptive title for the document
       attachment_label: Choose document
       delete_button: Remove document
+      cancel_button: Cancelar
       note: "You can upload up to a maximum of %{max_documents_allowed} documents of following content types: %{accepted_content_types}, up to %{max_file_size} MB per file."
       add_new_document: Add new document
     actions:

config/locales/es/documents.yml

@@ -8,6 +8,7 @@ es:
       title_placeholder: Añade un título descriptivo para el documento
       attachment_label: Selecciona un documento
       delete_button: Eliminar documento
+      cancel_button: Cancelar
       note: 'Puedes subir hasta un máximo de %{max_documents_allowed} documentos en los formatos: %{accepted_content_types}, y de hasta %{max_file_size} MB por archivo.'
       add_new_document: Añadir nuevo documento
     actions:

spec/controllers/application_controller_spec.rb

@@ -16,4 +16,4 @@ describe ApplicationController do
 
   end
 
-end
+end

spec/shared/features/nested_documentable.rb

@@ -52,6 +52,13 @@ shared_examples "nested documentable" do |login_as_name, documentable_factory_na
         click_link "Add new document"
       end
 
+      within "#nested-documents" do
+        find_all(".document input[type=file]", visible: true).each do |document|
+        attach_file(document, "spec/fixtures/files/empty.pdf", make_visible: true)
+        end
+      end
+
+      expect(page).to have_content I18n.t 'documents.buttons.destroy_document'
       expect(page).to have_css ".max-documents-notice", visible: true
     end