consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move relationable expectations to controller tests

Browse Source 
Having expectations related to database operations in system tests after
the process running the browser has started might result in exceptions
while running our test suite.
This commit is contained in:
Javi Martín
2023-07-19 20:59:35 +02:00
parent 2113c00db8
commit 3fe292dfe2
2 changed files with 46 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/shared/system/relationable.rb
View File

@@ -136,7 +136,7 @@ shared_examples "relationable" do |relationable_model_name|
end
scenario "related content can be scored positively" do
related_content = create(:related_content, parent_relationable: relationable, child_relationable: related1, author: build(:user))
create(:related_content, parent_relationable: relationable, child_relationable: related1, author: build(:user))
login_as(user)
visit polymorphic_path(relationable)
@@ -147,13 +147,10 @@ shared_examples "relationable" do |relationable_model_name|
expect(page).not_to have_link "Yes"
expect(page).not_to have_link "No"
end
expect(related_content.related_content_scores.find_by(user_id: user.id, related_content_id: related_content.id).value).to eq(1)
expect(related_content.opposite_related_content.related_content_scores.find_by(user_id: user.id, related_content_id: related_content.opposite_related_content.id).value).to eq(1)
end
scenario "related content can be scored negatively" do
related_content = create(:related_content, parent_relationable: relationable, child_relationable: related1, author: build(:user))
create(:related_content, parent_relationable: relationable, child_relationable: related1, author: build(:user))
login_as(user)
visit polymorphic_path(relationable)
@@ -164,9 +161,6 @@ shared_examples "relationable" do |relationable_model_name|
expect(page).not_to have_link "Yes"
expect(page).not_to have_link "No"
end
expect(related_content.related_content_scores.find_by(user_id: user.id, related_content_id: related_content.id).value).to eq(-1)
expect(related_content.opposite_related_content.related_content_scores.find_by(user_id: user.id, related_content_id: related_content.opposite_related_content.id).value).to eq(-1)
end
scenario "if related content has negative score it will be hidden" do