Simplify tests requiring admin login

We were repeating the same code over and over (with a few variants) to
setup tests which require an administrator. We can use a tag and
simplify the code.
This commit is contained in:
Javi Martín
2020-11-20 21:54:18 +01:00
parent 64205ab15f
commit 3da4ee00b8
82 changed files with 110 additions and 468 deletions

View File

@@ -1,10 +1,6 @@
require "rails_helper"
describe "Admin proposals" do
before do
login_as create(:administrator).user
end
describe "Admin proposals", :admin do
it_behaves_like "admin_milestoneable",
:proposal,
"admin_polymorphic_path"
@@ -64,9 +60,6 @@ describe "Admin proposals" do
scenario "Successful proposals show create question button" do
successful_proposals = create_successful_proposals
admin = create(:administrator)
login_as(admin.user)
visit admin_proposals_path