From 60ea12de76b6cfd84090521273051072cc109e6c Mon Sep 17 00:00:00 2001
From: Alberto Garcia Cabeza <alberto@decabeza.es>
Date: Tue, 21 Mar 2017 18:44:51 +0100
Subject: [PATCH] improves accessibility on proposals embed videos

---
 app/helpers/embed_videos_helper.rb | 3 ++-
 config/locales/en.yml              | 1 +
 config/locales/es.yml              | 1 +
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/app/helpers/embed_videos_helper.rb b/app/helpers/embed_videos_helper.rb
index 8633549f4..22b1d878f 100644
--- a/app/helpers/embed_videos_helper.rb
+++ b/app/helpers/embed_videos_helper.rb
@@ -2,6 +2,7 @@ module EmbedVideosHelper
 
   def embedded_video_code
     link = @proposal.video_url
+    title = t('proposals.show.embed_video_title', proposal: @proposal.title)
     if link.match(/vimeo.*/)
       server = "Vimeo"
     elsif link.match(/youtu*.*/)
@@ -21,7 +22,7 @@ module EmbedVideosHelper
     end
 
     if match and match[2]
-      '<iframe src="' + src + match[2] + '" frameborder="0" allowfullscreen></iframe>'
+      '<iframe src="' + src + match[2] + '" style="border:0;" allowfullscreen title="' + title + '"></iframe>'
     else
       ''
     end
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 7d5b5a8f2..200386daa 100755
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -384,6 +384,7 @@ en:
       share: Share
       send_notification: Send notification
       no_notifications: "This proposal has any notifications."
+      embed_video_title: "Video on %{proposal}"
     update:
       form:
         submit_button: Save changes
diff --git a/config/locales/es.yml b/config/locales/es.yml
index 495a940a3..75cb67f38 100755
--- a/config/locales/es.yml
+++ b/config/locales/es.yml
@@ -384,6 +384,7 @@ es:
       send_notification: Enviar notificación
       share: Compartir
       no_notifications: "Esta propuesta no tiene notificaciones."
+      embed_video_title: "Vídeo en %{proposal}"
     update:
       form:
         submit_button: Guardar cambios