diff --git a/app/helpers/user_segments_helper.rb b/app/helpers/user_segments_helper.rb index 6431216ef..796ff03da 100644 --- a/app/helpers/user_segments_helper.rb +++ b/app/helpers/user_segments_helper.rb @@ -4,4 +4,12 @@ module UserSegmentsHelper [t("admin.segment_recipient.#{user_segment_name}"), user_segment_name] end end + + def segment_name(user_segment) + if user_segment && UserSegments.respond_to?(user_segment) + I18n.t("admin.segment_recipient.#{user_segment}") + else + I18n.t("admin.segment_recipient.invalid_recipients_segment") + end + end end diff --git a/app/views/admin/newsletters/index.html.erb b/app/views/admin/newsletters/index.html.erb index c94a2c046..00a94e336 100644 --- a/app/views/admin/newsletters/index.html.erb +++ b/app/views/admin/newsletters/index.html.erb @@ -19,7 +19,7 @@ <%= newsletter.subject %> - <%= t("admin.segment_recipient.#{newsletter.segment_recipient}") %> + <%= segment_name(newsletter.segment_recipient) %> <% if newsletter.draft? %> diff --git a/app/views/admin/newsletters/show.html.erb b/app/views/admin/newsletters/show.html.erb index a4da2a746..7f95bacde 100644 --- a/app/views/admin/newsletters/show.html.erb +++ b/app/views/admin/newsletters/show.html.erb @@ -27,7 +27,7 @@
<%= t("admin.newsletters.show.segment_recipient") %>
- <%= t("admin.segment_recipient.#{@newsletter.segment_recipient}") %> + <%= segment_name(@newsletter.segment_recipient) %> <%= t("admin.newsletters.show.affected_users", n: recipients_count) %>
diff --git a/config/locales/en/admin.yml b/config/locales/en/admin.yml index 2a0e0b502..4b135a1b4 100644 --- a/config/locales/en/admin.yml +++ b/config/locales/en/admin.yml @@ -523,6 +523,7 @@ en: feasible_and_undecided_investment_authors: Authors of feasible or undecided investments in the current budget selected_investment_authors: Authors of selected investments in the current budget winner_investment_authors: Authors of winner investments in the current budget + invalid_recipients_segment: "Recipients user segment is invalid" newsletters: create_success: Newsletter created successfully update_success: Newsletter updated successfully diff --git a/config/locales/es/admin.yml b/config/locales/es/admin.yml index df4588bc8..0059768ae 100644 --- a/config/locales/es/admin.yml +++ b/config/locales/es/admin.yml @@ -522,6 +522,7 @@ es: feasible_and_undecided_investment_authors: Usuarios autores de proyectos de gasto viables o sin decidir en los actuales presupuestos selected_investment_authors: Usuarios autores de proyectos de gasto seleccionadas en los actuales presupuestos winner_investment_authors: Usuarios autores de proyectos de gasto ganadoras en los actuales presupuestos + invalid_recipients_segment: "El segmento de destinatarios es inválido" newsletters: create_success: Newsletter creada correctamente update_success: Newsletter actualizada correctamente