From 37bc39e1c6f3647aaf3a73cdeb20fcb2e8804478 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Thu, 11 Apr 2024 23:00:55 +0200
Subject: [PATCH] Extract methods to render user links in management menu

So this is similar to what we're doing in the `Admin::MenuComponent`
class.
---
 .../management/menu_component.html.erb        | 46 +-----------
 app/components/management/menu_component.rb   | 70 +++++++++++++++++++
 2 files changed, 71 insertions(+), 45 deletions(-)

diff --git a/app/components/management/menu_component.html.erb b/app/components/management/menu_component.html.erb
index 938df24a1..f544ad0b2 100644
--- a/app/components/management/menu_component.html.erb
+++ b/app/components/management/menu_component.html.erb
@@ -1,50 +1,6 @@
 <ul id="admin_menu" data-accordion-menu>
   <li class="section-title">
-    <a href="#" class="users-link"><%= t("management.menu.users") %></a>
-    <%= link_list(
-      [
-        t("management.menu.select_user"),
-        management_document_verifications_path,
-        users?
-      ],
-      (
-        [
-          t("management.account.menu.reset_password_email"),
-          edit_password_email_management_account_path,
-          edit_password_email?
-        ] if managed_user.email
-      ),
-      [
-        t("management.account.menu.reset_password_manually"),
-        edit_password_manually_management_account_path,
-        edit_password_manually?
-      ],
-      [
-        t("management.menu.create_proposal"),
-        new_management_proposal_path,
-        create_proposal?
-      ],
-      [
-        t("management.menu.support_proposals"),
-        management_proposals_path,
-        support_proposal?
-      ],
-      (
-        [
-          t("management.menu.create_budget_investment"),
-          create_investments_management_budgets_path,
-          create_investments?
-        ] if Setting["process.budgets"]
-      ),
-      (
-        [
-          t("management.menu.support_budget_investments"),
-          support_investments_management_budgets_path,
-          support_investments?
-        ] if Setting["process.budgets"]
-      ),
-      class: "is-active"
-    ) %>
+    <%= user_links %>
   </li>
 
   <% if Setting["process.budgets"] %>
diff --git a/app/components/management/menu_component.rb b/app/components/management/menu_component.rb
index fdc85effe..5890fde08 100644
--- a/app/components/management/menu_component.rb
+++ b/app/components/management/menu_component.rb
@@ -3,6 +3,76 @@ class Management::MenuComponent < ApplicationComponent
 
   private
 
+    def user_links
+      link_to(t("management.menu.users"), "#", class: "users-link") +
+        link_list(
+          select_user_link,
+          (reset_password_email_link if managed_user.email),
+          reset_password_manually_link,
+          create_proposal_link,
+          support_proposals_link,
+          (create_budget_investment_link if Setting["process.budgets"]),
+          (support_budget_investments_link  if Setting["process.budgets"]),
+          class: "is-active"
+        )
+    end
+
+    def select_user_link
+      [
+        t("management.menu.select_user"),
+        management_document_verifications_path,
+        users?
+      ]
+    end
+
+    def reset_password_email_link
+      [
+        t("management.account.menu.reset_password_email"),
+        edit_password_email_management_account_path,
+        edit_password_email?
+      ]
+    end
+
+    def reset_password_manually_link
+      [
+        t("management.account.menu.reset_password_manually"),
+        edit_password_manually_management_account_path,
+        edit_password_manually?
+      ]
+    end
+
+    def create_proposal_link
+      [
+        t("management.menu.create_proposal"),
+        new_management_proposal_path,
+        create_proposal?
+      ]
+    end
+
+    def support_proposals_link
+      [
+        t("management.menu.support_proposals"),
+        management_proposals_path,
+        support_proposal?
+      ]
+    end
+
+    def create_budget_investment_link
+      [
+        t("management.menu.create_budget_investment"),
+        create_investments_management_budgets_path,
+        create_investments?
+      ]
+    end
+
+    def support_budget_investments_link
+      [
+        t("management.menu.support_budget_investments"),
+        support_investments_management_budgets_path,
+        support_investments?
+      ]
+    end
+
     def users?
       ["users", "email_verifications", "document_verifications"].include?(controller_name)
     end