diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss index 6dbf15537..dabfb2330 100644 --- a/app/assets/stylesheets/layout.scss +++ b/app/assets/stylesheets/layout.scss @@ -2287,6 +2287,22 @@ table { // 18. Banners // ----------- +.banner { + + a > * { + @include grid-row; + padding: 0 rem-calc(16); + + &:empty { + display: none; + } + } + + + .budget.expanded, + + .jumbo { + margin-top: 0; + } +} // 19. Recommendations // ------------------- diff --git a/app/assets/stylesheets/participation.scss b/app/assets/stylesheets/participation.scss index 8485b5468..2a8ed17c1 100644 --- a/app/assets/stylesheets/participation.scss +++ b/app/assets/stylesheets/participation.scss @@ -909,6 +909,8 @@ .help-header { background: #fafafa; border-bottom: 1px solid #eee; + margin-top: -$line-height; + margin-bottom: $line-height; padding-bottom: $line-height / 2; padding-top: $line-height; @@ -1142,6 +1144,7 @@ &.budget { background: $budget; + margin-top: -$line-height; h1, h2, diff --git a/app/helpers/banners_helper.rb b/app/helpers/banners_helper.rb index c43bc7e13..42cdb240d 100644 --- a/app/helpers/banners_helper.rb +++ b/app/helpers/banners_helper.rb @@ -3,22 +3,6 @@ module BannersHelper @banners.present? && @banners.count > 0 end - def banner_default_bg_color - "#e7f2fc" - end - - def banner_default_font_color - "#222222" - end - - def banner_bg_color_or_default - @banner.background_color.presence || banner_default_bg_color - end - - def banner_font_color_or_default - @banner.font_color.presence || banner_default_font_color - end - def banner_target_link(banner) link_to banner.target_url do tag.h2(banner.title, style: "color:#{banner.font_color}") + diff --git a/app/models/banner.rb b/app/models/banner.rb index f4b9b1d09..b5484e397 100644 --- a/app/models/banner.rb +++ b/app/models/banner.rb @@ -2,6 +2,9 @@ class Banner < ApplicationRecord acts_as_paranoid column: :hidden_at include ActsAsParanoidAliases + attribute :background_color, default: "#e7f2fc" + attribute :font_color, default: "#222222" + translates :title, touch: true translates :description, touch: true include Globalizable diff --git a/app/views/admin/banners/_form.html.erb b/app/views/admin/banners/_form.html.erb index bf8fc89b7..e6b607650 100644 --- a/app/views/admin/banners/_form.html.erb +++ b/app/views/admin/banners/_form.html.erb @@ -56,8 +56,7 @@

<%= t("admin.shared.color_help") %>

- <%= f.text_field :background_color, label: false, type: :color, - value: banner_bg_color_or_default %> + <%= f.text_field :background_color, label: false, type: :color %>
<%= f.text_field :background_color, label: false, id: "background_color_input" %> @@ -70,8 +69,7 @@

<%= t("admin.shared.color_help") %>

- <%= f.text_field :font_color, label: false, type: :color, - value: banner_font_color_or_default %> + <%= f.text_field :font_color, label: false, type: :color %>
<%= f.text_field :font_color, label: false, id: "font_color_input" %> diff --git a/app/views/budgets/index.html.erb b/app/views/budgets/index.html.erb index b24d67e16..1beeb1179 100644 --- a/app/views/budgets/index.html.erb +++ b/app/views/budgets/index.html.erb @@ -7,7 +7,7 @@ <% end %> <% if current_budget.present? %> -
+
diff --git a/app/views/shared/_section_header.html.erb b/app/views/shared/_section_header.html.erb index 6ae7580ce..fbda3c408 100644 --- a/app/views/shared/_section_header.html.erb +++ b/app/views/shared/_section_header.html.erb @@ -1,4 +1,4 @@ -
+
<%= image_tag "help/help_icon_#{image}.png", alt: t("#{i18n_namespace}.icon_alt"), class: "align-top" %> diff --git a/spec/models/banner_spec.rb b/spec/models/banner_spec.rb index 92e3ef407..75c05d918 100644 --- a/spec/models/banner_spec.rb +++ b/spec/models/banner_spec.rb @@ -11,4 +11,11 @@ describe Banner do it "is valid" do expect(banner).to be_valid end + + it "assigns default values to new banners" do + banner = Banner.new + + expect(banner.background_color).to be_present + expect(banner.font_color).to be_present + end end