From 231a7aa8eee1a506f3ce70c3ee3f461a3cba97a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sun, 26 Sep 2021 00:30:03 +0200 Subject: [PATCH 1/2] Remove unused code to track events We forgot to remove it in commit f28a5cc49. The generated HTML was invalid, with the error: > Element meta is missing one or more of the following attributes: > content, property. --- app/helpers/tracks_helper.rb | 12 -- app/views/layouts/_tracking_data.html.erb | 1 - app/views/layouts/application.html.erb | 1 - app/views/layouts/dashboard.html.erb | 1 - app/views/verification/letter/edit.html.erb | 1 - app/views/verification/letter/new.html.erb | 1 - app/views/verification/letter/show.html.erb | 1 - app/views/verification/residence/new.html.erb | 1 - app/views/verification/sms/edit.html.erb | 1 - app/views/verification/sms/new.html.erb | 1 - spec/system/tracks_spec.rb | 115 ------------------ 11 files changed, 136 deletions(-) delete mode 100644 app/helpers/tracks_helper.rb delete mode 100644 app/views/layouts/_tracking_data.html.erb delete mode 100644 spec/system/tracks_spec.rb diff --git a/app/helpers/tracks_helper.rb b/app/helpers/tracks_helper.rb deleted file mode 100644 index 8236751d5..000000000 --- a/app/helpers/tracks_helper.rb +++ /dev/null @@ -1,12 +0,0 @@ -module TracksHelper - def track_event(data = {}) - track_data = "" - prefix = " data-track-event-" - data.each do |key, value| - track_data = "#{track_data}#{prefix}#{key}=#{value} " - end - content_for :track_event do - track_data - end - end -end diff --git a/app/views/layouts/_tracking_data.html.erb b/app/views/layouts/_tracking_data.html.erb deleted file mode 100644 index eef99b5cb..000000000 --- a/app/views/layouts/_tracking_data.html.erb +++ /dev/null @@ -1 +0,0 @@ - /> diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 6cc32f447..04fa2920a 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -2,7 +2,6 @@ lang="<%= I18n.locale %>" data-current-user-id="<%= current_user&.id %>"> <%= render "layouts/common_head", default_title: setting["org_name"] %> - <%= render "layouts/tracking_data" %> <%= render "layouts/meta_tags" %> <%= content_for :canonical %> <%= favicon_link_tag image_path_for("apple-touch-icon-200.png"), diff --git a/app/views/layouts/dashboard.html.erb b/app/views/layouts/dashboard.html.erb index 045f061b8..2460ba948 100644 --- a/app/views/layouts/dashboard.html.erb +++ b/app/views/layouts/dashboard.html.erb @@ -4,7 +4,6 @@ - <%= render "layouts/tracking_data" %> <%= render "layouts/meta_tags" %> <%= content_for?(:title) ? yield(:title) : setting["org_name"] %> <%= content_for :canonical %> diff --git a/app/views/verification/letter/edit.html.erb b/app/views/verification/letter/edit.html.erb index d8bcb0879..b3e1af4e9 100644 --- a/app/views/verification/letter/edit.html.erb +++ b/app/views/verification/letter/edit.html.erb @@ -1,5 +1,4 @@
- <% track_event(category: "verification", action: "edit_letter") %>

diff --git a/app/views/verification/letter/new.html.erb b/app/views/verification/letter/new.html.erb index b7a442f99..a60a762d7 100644 --- a/app/views/verification/letter/new.html.erb +++ b/app/views/verification/letter/new.html.erb @@ -1,5 +1,4 @@