consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change single quotes to double quotes

Browse Source
This commit is contained in:
Julian Herrero
2019-02-01 16:48:49 +01:00
parent 4a12425987
commit 31ac8b7f55
302 changed files with 6403 additions and 6403 deletions
Download Patch File Download Diff File Expand all files Collapse all files

132
spec/features/comments/proposals_spec.rb
View File

@@ -1,26 +1,26 @@
require 'rails_helper'
require "rails_helper"
include ActionView::Helpers::DateHelper
feature 'Commenting proposals' do
feature "Commenting proposals" do
let(:user) { create :user }
let(:proposal) { create :proposal }
scenario 'Index' do
scenario "Index" do
3.times { create(:comment, commentable: proposal) }
visit proposal_path(proposal)
expect(page).to have_css('.comment', count: 3)
expect(page).to have_css(".comment", count: 3)
comment = Comment.last
within first('.comment') do
within first(".comment") do
expect(page).to have_content comment.user.name
expect(page).to have_content I18n.l(comment.created_at, format: :datetime)
expect(page).to have_content comment.body
end
end
scenario 'Show' do
scenario "Show" do
parent_comment = create(:comment, commentable: proposal)
first_child = create(:comment, commentable: proposal, parent: parent_comment)
second_child = create(:comment, commentable: proposal, parent: parent_comment)
@@ -38,33 +38,33 @@ feature 'Commenting proposals' do
expect(page).to have_selector("ul#comment_#{second_child.id}>li", count: 1)
end
scenario 'Collapsable comments', :js do
scenario "Collapsable comments", :js do
parent_comment = create(:comment, body: "Main comment", commentable: proposal)
child_comment = create(:comment, body: "First subcomment", commentable: proposal, parent: parent_comment)
grandchild_comment = create(:comment, body: "Last subcomment", commentable: proposal, parent: child_comment)
visit proposal_path(proposal)
expect(page).to have_css('.comment', count: 3)
expect(page).to have_css(".comment", count: 3)
find("#comment_#{child_comment.id}_children_arrow").click
expect(page).to have_css('.comment', count: 2)
expect(page).to have_css(".comment", count: 2)
expect(page).not_to have_content grandchild_comment.body
find("#comment_#{child_comment.id}_children_arrow").click
expect(page).to have_css('.comment', count: 3)
expect(page).to have_css(".comment", count: 3)
expect(page).to have_content grandchild_comment.body
find("#comment_#{parent_comment.id}_children_arrow").click
expect(page).to have_css('.comment', count: 1)
expect(page).to have_css(".comment", count: 1)
expect(page).not_to have_content child_comment.body
expect(page).not_to have_content grandchild_comment.body
end
scenario 'Comment order' do
scenario "Comment order" do
c1 = create(:comment, :with_confidence_score, commentable: proposal, cached_votes_up: 100,
cached_votes_total: 120, created_at: Time.current - 2)
c2 = create(:comment, :with_confidence_score, commentable: proposal, cached_votes_up: 10,
@@ -88,7 +88,7 @@ feature 'Commenting proposals' do
expect(c2.body).to appear_before(c3.body)
end
scenario 'Creation date works differently in roots and in child comments, when sorting by confidence_score' do
scenario "Creation date works differently in roots and in child comments, when sorting by confidence_score" do
old_root = create(:comment, commentable: proposal, created_at: Time.current - 10)
new_root = create(:comment, commentable: proposal, created_at: Time.current)
old_child = create(:comment, commentable: proposal, parent_id: new_root.id, created_at: Time.current - 10)
@@ -110,39 +110,39 @@ feature 'Commenting proposals' do
expect(old_child.body).to appear_before(new_child.body)
end
scenario 'Turns links into html links' do
create :comment, commentable: proposal, body: 'Built with http://rubyonrails.org/'
scenario "Turns links into html links" do
create :comment, commentable: proposal, body: "Built with http://rubyonrails.org/"
visit proposal_path(proposal)
within first('.comment') do
expect(page).to have_content 'Built with http://rubyonrails.org/'
expect(page).to have_link('http://rubyonrails.org/', href: 'http://rubyonrails.org/')
expect(find_link('http://rubyonrails.org/')[:rel]).to eq('nofollow')
expect(find_link('http://rubyonrails.org/')[:target]).to eq('_blank')
within first(".comment") do
expect(page).to have_content "Built with http://rubyonrails.org/"
expect(page).to have_link("http://rubyonrails.org/", href: "http://rubyonrails.org/")
expect(find_link("http://rubyonrails.org/")[:rel]).to eq("nofollow")
expect(find_link("http://rubyonrails.org/")[:target]).to eq("_blank")
end
end
scenario 'Sanitizes comment body for security' do
scenario "Sanitizes comment body for security" do
create :comment, commentable: proposal,
body: "<script>alert('hola')</script> <a href=\"javascript:alert('sorpresa!')\">click me<a/> http://www.url.com"
visit proposal_path(proposal)
within first('.comment') do
within first(".comment") do
expect(page).to have_content "click me http://www.url.com"
expect(page).to have_link('http://www.url.com', href: 'http://www.url.com')
expect(page).not_to have_link('click me')
expect(page).to have_link("http://www.url.com", href: "http://www.url.com")
expect(page).not_to have_link("click me")
end
end
scenario 'Paginated comments' do
scenario "Paginated comments" do
per_page = 10
(per_page + 2).times { create(:comment, commentable: proposal)}
visit proposal_path(proposal)
expect(page).to have_css('.comment', count: per_page)
expect(page).to have_css(".comment", count: per_page)
within("ul.pagination") do
expect(page).to have_content("1")
expect(page).to have_content("2")
@@ -150,50 +150,50 @@ feature 'Commenting proposals' do
click_link "Next", exact: false
end
expect(page).to have_css('.comment', count: 2)
expect(page).to have_css(".comment", count: 2)
end
feature 'Not logged user' do
scenario 'can not see comments forms' do
feature "Not logged user" do
scenario "can not see comments forms" do
create(:comment, commentable: proposal)
visit proposal_path(proposal)
expect(page).to have_content 'You must Sign in or Sign up to leave a comment'
within('#comments') do
expect(page).not_to have_content 'Write a comment'
expect(page).not_to have_content 'Reply'
expect(page).to have_content "You must Sign in or Sign up to leave a comment"
within("#comments") do
expect(page).not_to have_content "Write a comment"
expect(page).not_to have_content "Reply"
end
end
end
scenario 'Create', :js do
scenario "Create", :js do
login_as(user)
visit proposal_path(proposal)
fill_in "comment-body-proposal_#{proposal.id}", with: 'Have you thought about...?'
click_button 'Publish comment'
fill_in "comment-body-proposal_#{proposal.id}", with: "Have you thought about...?"
click_button "Publish comment"
within "#comments" do
expect(page).to have_content 'Have you thought about...?'
expect(page).to have_content "Have you thought about...?"
end
within "#tab-comments-label" do
expect(page).to have_content 'Comments (1)'
expect(page).to have_content "Comments (1)"
end
end
scenario 'Errors on create', :js do
scenario "Errors on create", :js do
login_as(user)
visit proposal_path(proposal)
click_button 'Publish comment'
click_button "Publish comment"
expect(page).to have_content "Can't be blank"
end
scenario 'Reply', :js do
citizen = create(:user, username: 'Ana')
manuela = create(:user, username: 'Manuela')
scenario "Reply", :js do
citizen = create(:user, username: "Ana")
manuela = create(:user, username: "Manuela")
comment = create(:comment, commentable: proposal, user: citizen)
login_as(manuela)
@@ -202,18 +202,18 @@ feature 'Commenting proposals' do
click_link "Reply"
within "#js-comment-form-comment_#{comment.id}" do
fill_in "comment-body-comment_#{comment.id}", with: 'It will be done next week.'
click_button 'Publish reply'
fill_in "comment-body-comment_#{comment.id}", with: "It will be done next week."
click_button "Publish reply"
end
within "#comment_#{comment.id}" do
expect(page).to have_content 'It will be done next week.'
expect(page).to have_content "It will be done next week."
end
expect(page).not_to have_selector("#js-comment-form-comment_#{comment.id}", visible: true)
end
scenario 'Errors on reply', :js do
scenario "Errors on reply", :js do
comment = create(:comment, commentable: proposal, user: user)
login_as(user)
@@ -222,7 +222,7 @@ feature 'Commenting proposals' do
click_link "Reply"
within "#js-comment-form-comment_#{comment.id}" do
click_button 'Publish reply'
click_button "Publish reply"
expect(page).to have_content "Can't be blank"
end
@@ -294,8 +294,8 @@ feature 'Commenting proposals' do
visit proposal_path(proposal)
within "#comment_#{comment.id}" do
expect(page).to have_content('User deleted')
expect(page).to have_content('this should be visible')
expect(page).to have_content("User deleted")
expect(page).to have_content("this should be visible")
end
end
@@ -332,7 +332,7 @@ feature 'Commenting proposals' do
within "#js-comment-form-comment_#{comment.id}" do
fill_in "comment-body-comment_#{comment.id}", with: "I am moderating!"
check "comment-as-moderator-comment_#{comment.id}"
click_button 'Publish reply'
click_button "Publish reply"
end
within "#comment_#{comment.id}" do
@@ -388,7 +388,7 @@ feature 'Commenting proposals' do
within "#js-comment-form-comment_#{comment.id}" do
fill_in "comment-body-comment_#{comment.id}", with: "Top of the world!"
check "comment-as-administrator-comment_#{comment.id}"
click_button 'Publish reply'
click_button "Publish reply"
end
within "#comment_#{comment.id}" do
@@ -411,7 +411,7 @@ feature 'Commenting proposals' do
end
end
feature 'Voting comments' do
feature "Voting comments" do
background do
@manuela = create(:user, verified_at: Time.current)
@@ -422,7 +422,7 @@ feature 'Commenting proposals' do
login_as(@manuela)
end
scenario 'Show' do
scenario "Show" do
create(:vote, voter: @manuela, votable: @comment, vote_flag: true)
create(:vote, voter: @pablo, votable: @comment, vote_flag: false)
@@ -441,7 +441,7 @@ feature 'Commenting proposals' do
end
end
scenario 'Create', :js do
scenario "Create", :js do
visit proposal_path(@proposal)
within("#comment_#{@comment.id}_votes") do
@@ -459,23 +459,23 @@ feature 'Commenting proposals' do
end
end
scenario 'Update', :js do
scenario "Update", :js do
visit proposal_path(@proposal)
within("#comment_#{@comment.id}_votes") do
find('.in_favor a').click
find(".in_favor a").click
within('.in_favor') do
within(".in_favor") do
expect(page).to have_content "1"
end
find('.against a').click
find(".against a").click
within('.in_favor') do
within(".in_favor") do
expect(page).to have_content "0"
end
within('.against') do
within(".against") do
expect(page).to have_content "1"
end
@@ -483,18 +483,18 @@ feature 'Commenting proposals' do
end
end
scenario 'Trying to vote multiple times', :js do
scenario "Trying to vote multiple times", :js do
visit proposal_path(@proposal)
within("#comment_#{@comment.id}_votes") do
find('.in_favor a').click
find('.in_favor a').click
find(".in_favor a").click
find(".in_favor a").click
within('.in_favor') do
within(".in_favor") do
expect(page).to have_content "1"
end
within('.against') do
within(".against") do
expect(page).to have_content "0"
end