From 316c81683670c8acfce43ea79ac27d706030f08e Mon Sep 17 00:00:00 2001
From: decabeza <alberto@decabeza.es>
Date: Mon, 28 May 2018 18:52:59 +0200
Subject: [PATCH] Expands cards if feed processes is not enabled

---
 app/assets/stylesheets/layout.scss            | 10 +++++++++-
 app/helpers/feeds_helper.rb                   |  4 ++++
 app/views/welcome/_card.html.erb              |  2 +-
 app/views/welcome/_feeds.html.erb             | 16 +++++++++-------
 app/views/welcome/index.html.erb              |  2 +-
 spec/features/admin/homepage/homepage_spec.rb |  2 +-
 6 files changed, 25 insertions(+), 11 deletions(-)

diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss
index 5ad5e963c..1ada8d1d8 100644
--- a/app/assets/stylesheets/layout.scss
+++ b/app/assets/stylesheets/layout.scss
@@ -2644,7 +2644,10 @@ table {
 }
 
 .feed-description {
-  padding-top: $line-height;
+
+  @include breakpoint(medium) {
+    padding-top: $line-height;
+  }
 
   p {
     font-size: $small-font-size;
@@ -2669,6 +2672,11 @@ table {
   margin: 0 0 $line-height;
   position: relative;
 
+  @include breakpoint(medium) {
+    max-height: rem-calc(185);
+    overflow: hidden;
+  }
+
   a {
 
     h3,
diff --git a/app/helpers/feeds_helper.rb b/app/helpers/feeds_helper.rb
index b83efb70a..3a5ee8f3d 100644
--- a/app/helpers/feeds_helper.rb
+++ b/app/helpers/feeds_helper.rb
@@ -12,4 +12,8 @@ module FeedsHelper
     feed.kind == "processes"
   end
 
+  def feed_processes_enabled?
+    Setting['feature.homepage.widgets.feeds.processes'].present?
+  end
+
 end
diff --git a/app/views/welcome/_card.html.erb b/app/views/welcome/_card.html.erb
index dec54b193..365575da4 100644
--- a/app/views/welcome/_card.html.erb
+++ b/app/views/welcome/_card.html.erb
@@ -1,4 +1,4 @@
-<div id="<%= dom_id(card) %>" class="card small-12 medium-6 column margin-bottom end">
+<div id="<%= dom_id(card) %>" class="card small-12 medium-6 column margin-bottom end <%= 'large-4' unless feed_processes_enabled? %>">
   <%= link_to card.link_url do %>
     <figure class="figure-card">
       <% if card.image.present? %>
diff --git a/app/views/welcome/_feeds.html.erb b/app/views/welcome/_feeds.html.erb
index 8a0804705..a71a7dbb1 100644
--- a/app/views/welcome/_feeds.html.erb
+++ b/app/views/welcome/_feeds.html.erb
@@ -7,14 +7,16 @@
           <h3 class="title"><%= t("welcome.feed.most_active.#{feed.kind}") %></h3>
 
           <% feed.items.each do |item| %>
-            <div class="<%= item.class.to_s.parameterize('_') %>">
-              <div class="feed-image small-12 medium-2 column">
-                <% if feature?(:allow_images) && item.image.present? %>
-                  <%= image_tag item.image_url(:thumb),
-                                alt: item.image.title.unicode_normalize %>
-                <% end %>
+            <div class="<%= item.class.to_s.parameterize('_') %> row">
+              <div class="small-12 large-3 column">
+                <div class="feed-image">
+                  <% if feature?(:allow_images) && item.image.present? %>
+                    <%= image_tag item.image_url(:thumb),
+                                  alt: item.image.title.unicode_normalize %>
+                  <% end %>
+                </div>
               </div>
-              <div class="feed-description small-12 medium-10 column">
+              <div class="feed-description small-12 large-9 column">
                 <strong><%= link_to item.title, url_for(item) %></strong><br>
                 <p><%= item.summary %></p>
               </div>
diff --git a/app/views/welcome/index.html.erb b/app/views/welcome/index.html.erb
index ab4148712..4796a6d47 100644
--- a/app/views/welcome/index.html.erb
+++ b/app/views/welcome/index.html.erb
@@ -16,7 +16,7 @@
 
 
   <div class="row">
-    <div class="small-12 medium-8 column">
+    <div class="small-12 column <%= 'medium-8' if feed_processes_enabled? %>">
       <%= render "cards" %>
     </div>
 
diff --git a/spec/features/admin/homepage/homepage_spec.rb b/spec/features/admin/homepage/homepage_spec.rb
index 089b7fd5f..efb5f4a4f 100644
--- a/spec/features/admin/homepage/homepage_spec.rb
+++ b/spec/features/admin/homepage/homepage_spec.rb
@@ -67,7 +67,7 @@ feature 'Homepage' do
 
       visit root_path
 
-      expect(page).to have_content "Most active processes"
+      expect(page).to have_content "Open processes"
       expect(page).to have_css(".legislation_process", count: 3)
     end