From 2fe663ef8f6aa7c0e3c9030cc63f098fec1cb1c9 Mon Sep 17 00:00:00 2001
From: taitus <sebastia.roig@gmail.com>
Date: Fri, 23 Jun 2017 13:18:13 +0200
Subject: [PATCH] Fix syntax and indentation errors.

---
 .../budgets/investments/_filter_subnav.html.erb      | 12 ++++++------
 spec/factories.rb                                    |  2 +-
 spec/features/budgets/investments_spec.rb            |  6 ++----
 spec/models/budget/investment/milestone_spec.rb      |  6 +++---
 4 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/app/views/budgets/investments/_filter_subnav.html.erb b/app/views/budgets/investments/_filter_subnav.html.erb
index 7fc87fc82..a46c33b2d 100644
--- a/app/views/budgets/investments/_filter_subnav.html.erb
+++ b/app/views/budgets/investments/_filter_subnav.html.erb
@@ -10,12 +10,12 @@
         <% end %>
       </li>
       <li class="tabs-title">
-      <%= link_to "#tab-milestones" do %>
-        <h3>
-          <%= t("budgets.investments.show.milestones_tab") %>
-          (<%= @investment.milestones.count %>)
-        </h3>
-      <% end %>
+        <%= link_to "#tab-milestones" do %>
+          <h3>
+            <%= t("budgets.investments.show.milestones_tab") %>
+            (<%= @investment.milestones.count %>)
+          </h3>
+        <% end %>
       </li>
     </ul>
   </div>
diff --git a/spec/factories.rb b/spec/factories.rb
index 1d842e299..07e6c2c3e 100644
--- a/spec/factories.rb
+++ b/spec/factories.rb
@@ -324,7 +324,7 @@ FactoryGirl.define do
 
   factory :budget_investment_milestone, class: 'Budget::Investment::Milestone' do
     association :investment, factory: :budget_investment
-    sequence(:title)     { |n| "Budget Investment Milestone #{n} title" }
+    sequence(:title)     { |n| "Budget investment milestone #{n} title" }
     description          'Milestone description'
   end
 
diff --git a/spec/features/budgets/investments_spec.rb b/spec/features/budgets/investments_spec.rb
index c8ad40bfb..c795984c7 100644
--- a/spec/features/budgets/investments_spec.rb
+++ b/spec/features/budgets/investments_spec.rb
@@ -391,11 +391,10 @@ feature 'Budget Investments' do
 
   scenario "Show milestones", :js do
     user = create(:user)
-    login_as(user)
-
     investment = create(:budget_investment)
     milestone = create(:budget_investment_milestone, investment: investment, title: "New text to show")
 
+    login_as(user)
     visit budget_investment_path(budget_id: investment.budget.id, id: investment.id)
 
     find("#tab-milestones-label").trigger('click')
@@ -408,10 +407,9 @@ feature 'Budget Investments' do
 
   scenario "Show no_milestones text", :js do
     user = create(:user)
-    login_as(user)
-
     investment = create(:budget_investment)
 
+    login_as(user)
     visit budget_investment_path(budget_id: investment.budget.id, id: investment.id)
 
     find("#tab-milestones-label").trigger('click')
diff --git a/spec/models/budget/investment/milestone_spec.rb b/spec/models/budget/investment/milestone_spec.rb
index 5fc749d36..32f040eaf 100644
--- a/spec/models/budget/investment/milestone_spec.rb
+++ b/spec/models/budget/investment/milestone_spec.rb
@@ -5,16 +5,16 @@ describe "Budget::Investment::Milestone" do
   describe "Validations" do
     let(:milestone) { build(:budget_investment_milestone) }
 
-    it "should be valid" do
+    it "Should be valid" do
       expect(milestone).to be_valid
     end
 
-    it "should not be valid without a title" do
+    it "Should not be valid without a title" do
       milestone.title = nil
       expect(milestone).to_not be_valid
     end
 
-    it "should not be valid without an investment" do
+    it "Should not be valid without an investment" do
       milestone.investment_id = nil
       expect(milestone).to_not be_valid
     end