From 2f636eaf7753a9ab13dfee60f533b419b62530a0 Mon Sep 17 00:00:00 2001
From: decabeza <alberto@decabeza.es>
Date: Mon, 16 Mar 2020 12:54:00 +0100
Subject: [PATCH] Add completed info on finished budgets

---
 .../stylesheets/admin/budgets/index.scss      | 24 +++++++++++++++++++
 app/views/admin/budgets/index.html.erb        | 11 ++++++---
 config/locales/en/admin.yml                   |  1 +
 config/locales/es/admin.yml                   |  1 +
 spec/system/admin/budgets_spec.rb             |  6 ++++-
 5 files changed, 39 insertions(+), 4 deletions(-)
 create mode 100644 app/assets/stylesheets/admin/budgets/index.scss

diff --git a/app/assets/stylesheets/admin/budgets/index.scss b/app/assets/stylesheets/admin/budgets/index.scss
new file mode 100644
index 000000000..183439343
--- /dev/null
+++ b/app/assets/stylesheets/admin/budgets/index.scss
@@ -0,0 +1,24 @@
+.admin .budgets-table {
+
+  .budget-completed {
+    @include has-fa-icon(lock, solid);
+    padding-left: calc(1em + #{rem-calc(10)});
+    position: relative;
+
+    &::before {
+      color: $admin-border-color;
+      left: rem-calc(4);
+      position: absolute;
+      transform: translateY(50%);
+    }
+
+    span {
+      color: $admin-text;
+      display: block;
+      font-size: $tiny-font-size;
+      font-weight: bold;
+      line-height: rem-calc(12);
+      text-transform: uppercase;
+    }
+  }
+}
diff --git a/app/views/admin/budgets/index.html.erb b/app/views/admin/budgets/index.html.erb
index 841bcb0da..64e6cb946 100644
--- a/app/views/admin/budgets/index.html.erb
+++ b/app/views/admin/budgets/index.html.erb
@@ -9,7 +9,7 @@
 <% if @budgets.any? %>
   <h3><%= page_entries_info @budgets %></h3>
 
-  <table>
+  <table class="budgets-table">
     <thead>
       <tr>
         <th><%= t("admin.budgets.index.table_name") %></th>
@@ -20,8 +20,13 @@
     <tbody>
       <% @budgets.each do |budget| %>
         <tr id="<%= dom_id(budget) %>" class="budget">
-          <td>
-            <%= budget.name %>
+          <td class="<%= "budget-completed" if budget.finished? %>">
+            <% if budget.finished? %>
+              <span>
+                <%= t("admin.budgets.index.table_completed") %>
+              </span>
+            <% end %>
+            <strong><%= budget.name %></strong>
           </td>
           <td class="small">
             <%= t("budgets.phase.#{budget.phase}") %>
diff --git a/config/locales/en/admin.yml b/config/locales/en/admin.yml
index 22332f663..05ead4211 100644
--- a/config/locales/en/admin.yml
+++ b/config/locales/en/admin.yml
@@ -75,6 +75,7 @@ en:
           finished: Finished
         help: "Participatory budgets allow citizens to propose and decide directly how to spend part of the budget, with monitoring and rigorous evaluation of proposals by the institution."
         budget_investments: Manage projects
+        table_completed: Completed
         table_name: Name
         table_phase: Phase
         edit_groups: Edit headings groups
diff --git a/config/locales/es/admin.yml b/config/locales/es/admin.yml
index 252705474..527d31f0a 100644
--- a/config/locales/es/admin.yml
+++ b/config/locales/es/admin.yml
@@ -75,6 +75,7 @@ es:
           finished: Terminados
         help: "Los presupuestos participativos permiten que los ciudadanos propongan y decidan de manera directa cómo gastar parte del presupuesto, con un seguimiento y evaluación riguroso de las propuestas por parte de la institución."
         budget_investments: Gestionar proyectos de gasto
+        table_completed: Completado
         table_name: Nombre
         table_phase: Fase
         edit_groups: Editar grupos de partidas
diff --git a/spec/system/admin/budgets_spec.rb b/spec/system/admin/budgets_spec.rb
index ad2a9e2f0..0fb597c31 100644
--- a/spec/system/admin/budgets_spec.rb
+++ b/spec/system/admin/budgets_spec.rb
@@ -60,7 +60,11 @@ describe "Admin budgets", :admin do
       expect(page).to have_content(accepting_budget.name)
       expect(page).to have_content(selecting_budget.name)
       expect(page).to have_content(balloting_budget.name)
-      expect(page).not_to have_content(finished_budget.name)
+      expect(page).to have_content(finished_budget.name)
+
+      within "#budget_#{finished_budget.id}" do
+        expect(page).to have_content("Completed")
+      end
 
       click_link "Finished"
       expect(page).not_to have_content(drafting_budget.name)