From 2e9973cd4a4daa99dbe75cf6d4e27d71aa27b8ab Mon Sep 17 00:00:00 2001 From: Alessandro Cuoghi Date: Mon, 4 Feb 2019 16:04:45 +0100 Subject: [PATCH] Add new texts - Changed texts - Fixed Spec --- app/views/dashboard/_recommended_actions_by_status.html.erb | 2 +- config/locales/en/general.yml | 6 ++++-- config/locales/es/general.yml | 6 ++++-- spec/features/dashboard/dashboard_spec.rb | 6 +++--- 4 files changed, 12 insertions(+), 8 deletions(-) diff --git a/app/views/dashboard/_recommended_actions_by_status.html.erb b/app/views/dashboard/_recommended_actions_by_status.html.erb index a1a9a5020..6d1833014 100644 --- a/app/views/dashboard/_recommended_actions_by_status.html.erb +++ b/app/views/dashboard/_recommended_actions_by_status.html.erb @@ -12,7 +12,7 @@ <% else %> <%= link_to recommended_actions_proposal_dashboard_path(proposal.to_param) do %> - <%= t("dashboard.recommended_actions.see_proposed_actions") %> + <%= t("dashboard.recommended_actions.goto_proposed_actions") %> <% end %> <% end %> diff --git a/config/locales/en/general.yml b/config/locales/en/general.yml index b9bc95107..845ae090d 100644 --- a/config/locales/en/general.yml +++ b/config/locales/en/general.yml @@ -516,11 +516,13 @@ en: resource_locked: Resource locked recommended_actions: title: Recommended actions + goto_proposed_actions: Go to recommended actions see_proposed_actions: Check out recommended actions hide_proposed_actions: Hide recommended actions - pending_title: Recommended actions pending + pending_title: Pending + show_description: Show description without_pending_actions: No recommended actions pending - done_title: Recommended actions done + done_title: Done without_done_actions: No recommended actions done next_goal: title: Goal diff --git a/config/locales/es/general.yml b/config/locales/es/general.yml index b76d05804..4d79c8321 100644 --- a/config/locales/es/general.yml +++ b/config/locales/es/general.yml @@ -516,11 +516,13 @@ es: resource_locked: Recurso bloqueado recommended_actions: title: Acciones recomendadas + goto_proposed_actions: Ir a las acciones recomendadas see_proposed_actions: Ver todas las acciones recomendadas hide_proposed_actions: Ocultar acciones recomendadas - pending_title: Acciones recomendadas pendientes + pending_title: Pendientes + show_description: Mostrar descripción without_pending_actions: No hay acciones recomendadas pendientes - done_title: Acciones recomendadas realizadas + done_title: Realizadas without_done_actions: No hay acciones recomendadas realizadas next_goal: title: Meta diff --git a/spec/features/dashboard/dashboard_spec.rb b/spec/features/dashboard/dashboard_spec.rb index 8f1043dc2..45b9c4f28 100644 --- a/spec/features/dashboard/dashboard_spec.rb +++ b/spec/features/dashboard/dashboard_spec.rb @@ -70,7 +70,7 @@ feature "Proposal's dashboard" do visit progress_proposal_dashboard_path(proposal) - expect(page).to have_link("Check out recommended actions") + expect(page).to have_link("Go to recommended actions") end scenario "Dashboard progress do not display link to new page for proposed actions @@ -233,8 +233,8 @@ feature "Proposal's dashboard" do click_link "Recommended actions" expect(page).to have_content("Recommended actions") - expect(page).to have_content("Recommended actions pending") - expect(page).to have_content("Recommended actions done") + expect(page).to have_content("Pending") + expect(page).to have_content("Done") end scenario "On recommended actions section display from the fourth proposed actions