From 2d56415048c4968e2f33e5caea367b91599810c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= Date: Wed, 7 Sep 2016 15:13:39 +0200 Subject: [PATCH] adds feature flag for admin/budgets management --- app/controllers/admin/budget_headings_controller.rb | 2 ++ app/controllers/admin/budget_investments_controller.rb | 2 ++ app/controllers/admin/budgets_controller.rb | 2 ++ app/controllers/budgets_controller.rb | 3 +++ spec/features/admin/budget_investments_spec.rb | 9 +++++++++ 5 files changed, 18 insertions(+) diff --git a/app/controllers/admin/budget_headings_controller.rb b/app/controllers/admin/budget_headings_controller.rb index 3c8ccafa0..56903b744 100644 --- a/app/controllers/admin/budget_headings_controller.rb +++ b/app/controllers/admin/budget_headings_controller.rb @@ -1,4 +1,6 @@ class Admin::BudgetHeadingsController < Admin::BaseController + include FeatureFlags + feature_flag :budgets def create @budget = Budget.find params[:budget_id] diff --git a/app/controllers/admin/budget_investments_controller.rb b/app/controllers/admin/budget_investments_controller.rb index 17cc76923..399ec0ec8 100644 --- a/app/controllers/admin/budget_investments_controller.rb +++ b/app/controllers/admin/budget_investments_controller.rb @@ -1,4 +1,6 @@ class Admin::BudgetInvestmentsController < Admin::BaseController + include FeatureFlags + feature_flag :budgets before_action :load_budget before_action :load_investment, only: [:show, :edit, :update] diff --git a/app/controllers/admin/budgets_controller.rb b/app/controllers/admin/budgets_controller.rb index 144b43a7f..2dd210947 100644 --- a/app/controllers/admin/budgets_controller.rb +++ b/app/controllers/admin/budgets_controller.rb @@ -1,4 +1,6 @@ class Admin::BudgetsController < Admin::BaseController + include FeatureFlags + feature_flag :budgets has_filters %w{open finished}, only: :index diff --git a/app/controllers/budgets_controller.rb b/app/controllers/budgets_controller.rb index db05aafea..9c8a2036b 100644 --- a/app/controllers/budgets_controller.rb +++ b/app/controllers/budgets_controller.rb @@ -1,4 +1,7 @@ class BudgetsController < ApplicationController + include FeatureFlags + feature_flag :budgets + load_and_authorize_resource respond_to :html, :js diff --git a/spec/features/admin/budget_investments_spec.rb b/spec/features/admin/budget_investments_spec.rb index c34354ede..a9ec45dba 100644 --- a/spec/features/admin/budget_investments_spec.rb +++ b/spec/features/admin/budget_investments_spec.rb @@ -9,6 +9,15 @@ feature 'Admin budget investments' do @budget = create(:budget) end + context "Feature flag" do + + scenario 'Disabled with a feature flag' do + Setting['feature.budgets'] = nil + expect{ visit admin_budgets_path }.to raise_exception(FeatureFlags::FeatureDisabled) + end + + end + context "Index" do scenario 'Displaying investmentss' do