consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enable RSpec/LetSetup cop & fix issues

Browse Source 
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
This commit is contained in:
Bertocq
2018-01-07 16:23:49 +01:00
parent 8be2df09b8
commit 2d355ce938
8 changed files with 74 additions and 96 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
spec/shared/features/documentable.rb
View File

@@ -1,10 +1,11 @@
shared_examples "documentable" do |documentable_factory_name, documentable_path, documentable_path_arguments|
include ActionView::Helpers
let!(:administrator) { create(:user) }
let!(:user) { create(:user) }
let!(:arguments) { {} }
let!(:documentable) { create(documentable_factory_name, author: user) }
let(:administrator) { create(:user) }
let(:user) { create(:user) }
let(:arguments) { {} }
let(:documentable) { create(documentable_factory_name, author: user) }
let!(:document) { create(:document, documentable: documentable, user: documentable.author) }
before do
create(:administrator, user: administrator)
@@ -16,8 +17,6 @@ shared_examples "documentable" do |documentable_factory_name, documentable_path,
context "Show documents tab" do
let!(:document) { create(:document, documentable: documentable, user: documentable.author)}
scenario "Download action should be able to anyone" do
visit send(documentable_path, arguments)
@@ -76,8 +75,6 @@ shared_examples "documentable" do |documentable_factory_name, documentable_path,
context "Destroy" do
let!(:document) { create(:document, documentable: documentable, user: documentable.author) }
scenario "Should show success notice after successfull document upload" do
login_as documentable.author