consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use the dir attribute in dashboard and mailer layouts

Browse Source 
We forgot to do so in commit d827768c0. In order to avoid the same
mistake in the future, we're extracting a method to get these
attributes. We're also adding tests, since we didn't have any tests to
check that the `dir` attribute was properly set.
This commit is contained in:
Javi Martín
2022-10-06 18:10:35 +02:00
parent 314ce70000
commit 2c0ede3aaa
11 changed files with 63 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/views/layouts/admin.html.erb
View File

@@ -1,6 +1,5 @@
<!DOCTYPE html>
<html <%= "dir=rtl" if rtl? %> lang="<%= I18n.locale %>">
<html <%= common_html_attributes %>>
<head>
<%= render "layouts/common_head", default_title: "Admin" %>
<%= content_for :head %>

2
app/views/layouts/application.html.erb
View File

@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html <%= "dir=rtl" if rtl? %> lang="<%= I18n.locale %>" data-current-user-id="<%= current_user&.id %>">
<html <%= common_html_attributes %> data-current-user-id="<%= current_user&.id %>">
<head>
<%= render "layouts/common_head", default_title: setting["org_name"] %>
<%= render "layouts/meta_tags" %>

2
app/views/layouts/dashboard.html.erb
View File

@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="<%= I18n.locale %>" data-current-user-id="<%= current_user&.id %>">
<html <%= common_html_attributes %> data-current-user-id="<%= current_user&.id %>">
<head>
<%= render "layouts/common_head", default_title: setting["org_name"] %>
<%= render "layouts/meta_tags" %>

2
app/views/layouts/devise.html.erb
View File

@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html <%= "dir=rtl" if rtl? %> lang="<%= I18n.locale %>">
<html <%= common_html_attributes %>>
<head>
<%= render "layouts/common_head", default_title: setting["org_name"] %>
<%= render "layouts/meta_tags" %>

2
app/views/layouts/mailer.html.erb
View File

@@ -1,5 +1,5 @@
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html lang="<%= I18n.locale %>">
<html <%= common_html_attributes %>>
<head>
<title><%= t("mailers.title") %></title>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">

3
app/views/layouts/management.html.erb
View File

@@ -1,6 +1,5 @@
<!DOCTYPE html>
<html <%= "dir=rtl" if rtl? %> lang="<%= I18n.locale %>">
<html <%= common_html_attributes %>>
<head>
<%= render "layouts/common_head", default_title: "Management" %>
<%= stylesheet_link_tag "print", media: "print" %>