From 2b35144540cacf618d86cc6774bd5beb1f4fb53d Mon Sep 17 00:00:00 2001 From: taitus Date: Wed, 3 Nov 2021 11:56:36 +0100 Subject: [PATCH] Unify expectations on spec components folder In this PR (https://github.com/consul/consul/pull/4683) a new syntax was introduced in the component specs to check that the component was not rendering. It seems interesting to add this syntax to the rest of the cases and thus unify the way we check that a component is not rendering. --- spec/components/admin/budgets/duration_component_spec.rb | 4 ++-- .../budgets_wizard/headings/group_switcher_component_spec.rb | 3 +-- spec/components/budgets/supports_info_component_spec.rb | 3 +-- spec/components/layout/locale_switcher_component_spec.rb | 3 +-- spec/components/layout/social_component_spec.rb | 2 +- spec/components/layout/top_links_component_spec.rb | 2 +- spec/components/sdg/goals/help_page_component_spec.rb | 2 +- spec/components/sdg/goals/plain_tag_list_component_spec.rb | 2 +- spec/components/sdg/goals/tag_list_component_spec.rb | 4 ++-- spec/components/sdg/goals/targets_component_spec.rb | 4 +--- spec/components/sdg/related_list_selector_component_spec.rb | 4 ++-- spec/components/sdg/targets/plain_tag_list_component_spec.rb | 4 ++-- spec/components/sdg/targets/tag_list_component_spec.rb | 4 ++-- spec/components/shared/banner_component_spec.rb | 4 ++-- spec/components/shared/link_list_component_spec.rb | 4 ++-- 15 files changed, 22 insertions(+), 27 deletions(-) diff --git a/spec/components/admin/budgets/duration_component_spec.rb b/spec/components/admin/budgets/duration_component_spec.rb index a95c44108..e581c3bbf 100644 --- a/spec/components/admin/budgets/duration_component_spec.rb +++ b/spec/components/admin/budgets/duration_component_spec.rb @@ -49,7 +49,7 @@ describe Admin::Budgets::DurationComponent do render Admin::Budgets::DurationComponent.new(durable).duration - expect(page.text).to be_empty + expect(page.native.inner_html).to be_empty end it "is not defined when no start date is defined" do @@ -57,7 +57,7 @@ describe Admin::Budgets::DurationComponent do render Admin::Budgets::DurationComponent.new(durable).duration - expect(page.text).to be_empty + expect(page.native.inner_html).to be_empty end end diff --git a/spec/components/admin/budgets_wizard/headings/group_switcher_component_spec.rb b/spec/components/admin/budgets_wizard/headings/group_switcher_component_spec.rb index a0e0ee1cb..13a6db846 100644 --- a/spec/components/admin/budgets_wizard/headings/group_switcher_component_spec.rb +++ b/spec/components/admin/budgets_wizard/headings/group_switcher_component_spec.rb @@ -6,8 +6,7 @@ describe Admin::BudgetsWizard::Headings::GroupSwitcherComponent do render_inline Admin::BudgetsWizard::Headings::GroupSwitcherComponent.new(group) - expect(page.text).to be_empty - expect(page).not_to have_css ".budget-group-switcher" + expect(page.native.inner_html).to be_empty end it "renders a link to switch group for budgets with two groups" do diff --git a/spec/components/budgets/supports_info_component_spec.rb b/spec/components/budgets/supports_info_component_spec.rb index 64b563877..9286976fd 100644 --- a/spec/components/budgets/supports_info_component_spec.rb +++ b/spec/components/budgets/supports_info_component_spec.rb @@ -28,8 +28,7 @@ describe Budgets::SupportsInfoComponent do render_inline component - expect(page).not_to have_selector ".supports-info" - expect(page.text).to be_empty + expect(page.native.inner_html).to be_empty end describe "#total_supports" do diff --git a/spec/components/layout/locale_switcher_component_spec.rb b/spec/components/layout/locale_switcher_component_spec.rb index d703aa62f..4c104525b 100644 --- a/spec/components/layout/locale_switcher_component_spec.rb +++ b/spec/components/layout/locale_switcher_component_spec.rb @@ -13,8 +13,7 @@ describe Layout::LocaleSwitcherComponent do it "doesn't render anything" do render_inline component - expect(page.text).to be_empty - expect(page).not_to have_css ".locale" + expect(page.native.inner_html).to be_empty end end diff --git a/spec/components/layout/social_component_spec.rb b/spec/components/layout/social_component_spec.rb index 757051538..f54ff1182 100644 --- a/spec/components/layout/social_component_spec.rb +++ b/spec/components/layout/social_component_spec.rb @@ -33,7 +33,7 @@ describe Layout::SocialComponent do render_inline Layout::SocialComponent.new - expect(page).not_to have_css "ul" + expect(page.native.inner_html).to be_empty end end end diff --git a/spec/components/layout/top_links_component_spec.rb b/spec/components/layout/top_links_component_spec.rb index e9e297d26..893d282f6 100644 --- a/spec/components/layout/top_links_component_spec.rb +++ b/spec/components/layout/top_links_component_spec.rb @@ -13,7 +13,7 @@ describe Layout::TopLinksComponent do it "does not render when no content block is defined" do render_inline Layout::TopLinksComponent.new - expect(page).not_to have_css "ul" + expect(page.native.inner_html).to be_empty end end end diff --git a/spec/components/sdg/goals/help_page_component_spec.rb b/spec/components/sdg/goals/help_page_component_spec.rb index 250dd4e91..7f713f0ee 100644 --- a/spec/components/sdg/goals/help_page_component_spec.rb +++ b/spec/components/sdg/goals/help_page_component_spec.rb @@ -13,7 +13,7 @@ describe SDG::Goals::HelpPageComponent do render_inline component - expect(page).not_to have_css ".sdg-help-content" + expect(page.native.inner_html).to be_empty end it "renders content when the feature is enabled" do diff --git a/spec/components/sdg/goals/plain_tag_list_component_spec.rb b/spec/components/sdg/goals/plain_tag_list_component_spec.rb index cd629f26b..76581c6c3 100644 --- a/spec/components/sdg/goals/plain_tag_list_component_spec.rb +++ b/spec/components/sdg/goals/plain_tag_list_component_spec.rb @@ -14,7 +14,7 @@ describe SDG::Goals::PlainTagListComponent do render_inline component - expect(page).not_to have_css "li" + expect(page.native.inner_html).to be_empty end it "does not render when the SDG process feature is disabled" do diff --git a/spec/components/sdg/goals/tag_list_component_spec.rb b/spec/components/sdg/goals/tag_list_component_spec.rb index b47bcd5b9..f55b1d479 100644 --- a/spec/components/sdg/goals/tag_list_component_spec.rb +++ b/spec/components/sdg/goals/tag_list_component_spec.rb @@ -14,7 +14,7 @@ describe SDG::Goals::TagListComponent do render_inline component - expect(page).not_to have_css "li" + expect(page.native.inner_html).to be_empty end it "does not render when the SDG process feature is disabled" do @@ -22,7 +22,7 @@ describe SDG::Goals::TagListComponent do render_inline component - expect(page).not_to have_css "li" + expect(page.native.inner_html).to be_empty end it "renders a list of goals" do diff --git a/spec/components/sdg/goals/targets_component_spec.rb b/spec/components/sdg/goals/targets_component_spec.rb index 072abf99f..5f00300aa 100644 --- a/spec/components/sdg/goals/targets_component_spec.rb +++ b/spec/components/sdg/goals/targets_component_spec.rb @@ -13,9 +13,7 @@ describe SDG::Goals::TargetsComponent do render_inline component - expect(page).not_to have_css ".targets" - expect(page).not_to have_css "#target_tabs" - expect(page).not_to have_css ".tabs-content" + expect(page.native.inner_html).to be_empty end it "renders tabs panel" do diff --git a/spec/components/sdg/related_list_selector_component_spec.rb b/spec/components/sdg/related_list_selector_component_spec.rb index 9d8509245..6aa1bb1b8 100644 --- a/spec/components/sdg/related_list_selector_component_spec.rb +++ b/spec/components/sdg/related_list_selector_component_spec.rb @@ -15,7 +15,7 @@ describe SDG::RelatedListSelectorComponent do render_inline component - expect(page).not_to have_css ".sdg-related-list-selector" + expect(page.native.inner_html).to be_empty end it "does not render when the SDG process feature is disabled" do @@ -23,7 +23,7 @@ describe SDG::RelatedListSelectorComponent do render_inline component - expect(page).not_to have_css ".sdg-related-list-selector" + expect(page.native.inner_html).to be_empty end it "renders related_sdg_list field" do diff --git a/spec/components/sdg/targets/plain_tag_list_component_spec.rb b/spec/components/sdg/targets/plain_tag_list_component_spec.rb index 801273bde..415ccc856 100644 --- a/spec/components/sdg/targets/plain_tag_list_component_spec.rb +++ b/spec/components/sdg/targets/plain_tag_list_component_spec.rb @@ -18,7 +18,7 @@ describe SDG::Targets::PlainTagListComponent do render_inline component - expect(page).not_to have_css "li" + expect(page.native.inner_html).to be_empty end it "does not render when the SDG process feature is disabled" do @@ -26,7 +26,7 @@ describe SDG::Targets::PlainTagListComponent do render_inline component - expect(page).not_to have_css "li" + expect(page.native.inner_html).to be_empty end it "renders a list of targets" do diff --git a/spec/components/sdg/targets/tag_list_component_spec.rb b/spec/components/sdg/targets/tag_list_component_spec.rb index 327c7aa56..cf2cb9546 100644 --- a/spec/components/sdg/targets/tag_list_component_spec.rb +++ b/spec/components/sdg/targets/tag_list_component_spec.rb @@ -18,7 +18,7 @@ describe SDG::Targets::TagListComponent do render_inline component - expect(page).not_to have_css "li" + expect(page.native.inner_html).to be_empty end it "does not render when the SDG process feature is disabled" do @@ -26,7 +26,7 @@ describe SDG::Targets::TagListComponent do render_inline component - expect(page).not_to have_css "li" + expect(page.native.inner_html).to be_empty end it "renders a list of targets" do diff --git a/spec/components/shared/banner_component_spec.rb b/spec/components/shared/banner_component_spec.rb index 9dc1113a2..dd11f9772 100644 --- a/spec/components/shared/banner_component_spec.rb +++ b/spec/components/shared/banner_component_spec.rb @@ -82,13 +82,13 @@ describe Shared::BannerComponent do render_inline Shared::BannerComponent.new("debates") - expect(page).not_to have_css ".banner" + expect(page.native.inner_html).to be_empty end end it "does not render anything given nil" do render_inline Shared::BannerComponent.new(nil) - expect(page).not_to have_css ".banner" + expect(page.native.inner_html).to be_empty end end diff --git a/spec/components/shared/link_list_component_spec.rb b/spec/components/shared/link_list_component_spec.rb index 8dea5fb90..dd23307d2 100644 --- a/spec/components/shared/link_list_component_spec.rb +++ b/spec/components/shared/link_list_component_spec.rb @@ -4,13 +4,13 @@ describe Shared::LinkListComponent do it "renders nothing with an empty list" do render_inline Shared::LinkListComponent.new - expect(page).not_to have_css "ul" + expect(page.native.inner_html).to be_empty end it "returns nothing with a list of nil elements" do render_inline Shared::LinkListComponent.new(nil, nil) - expect(page).not_to have_css "ul" + expect(page.native.inner_html).to be_empty end it "generates a list of links" do