From 2ad6ced12fca0b6d36c15ddea2f21626957d5e4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 24 Sep 2019 00:38:29 +0200 Subject: [PATCH] Create featured proposals if enabled We had a case where we created 5 extra records in pagination and checked 2 records were present, because the other 3 were automatically considered featured proposals. Explicitely creating featured proposals let us create 2 extra records and check 2 records are present, which is far more intuitive. --- spec/features/proposals_spec.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/spec/features/proposals_spec.rb b/spec/features/proposals_spec.rb index 52c1c15e4..84acf882d 100644 --- a/spec/features/proposals_spec.rb +++ b/spec/features/proposals_spec.rb @@ -31,9 +31,9 @@ describe "Proposals" do Setting["feature.featured_proposals"] = true Setting["featured_proposals_number"] = 3 end + let!(:featured_proposals) { create_featured_proposals } scenario "Lists featured and regular proposals" do - featured_proposals = create_featured_proposals proposals = [create(:proposal), create(:proposal), create(:proposal)] visit proposals_path @@ -57,7 +57,6 @@ describe "Proposals" do end scenario "Index view mode" do - featured_proposals = create_featured_proposals proposals = [create(:proposal), create(:proposal), create(:proposal)] visit proposals_path @@ -96,7 +95,7 @@ describe "Proposals" do scenario "Pagination" do per_page = Kaminari.config.default_per_page - (per_page + 5).times { create(:proposal) } + (per_page + 2).times { create(:proposal) } visit proposals_path @@ -114,7 +113,6 @@ describe "Proposals" do end scenario "Index should show proposal descriptive image only when is defined" do - featured_proposals = create_featured_proposals proposal = create(:proposal) proposal_with_image = create(:proposal) image = create(:image, imageable: proposal_with_image)